U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: don't spam console if phys property is absent in device node
@ 2024-12-03 20:57 Roger Quadros
  2024-12-06  6:49 ` Siddharth Vadapalli
  2024-12-19  3:10 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Roger Quadros @ 2024-12-03 20:57 UTC (permalink / raw)
  To: Tom Rini, vigneshr, nm
  Cc: j-humphreys, srk, s-vadapalli, u-boot, Roger Quadros

In generic_phy_get_bulk(), if 'phys' property is absent in
the device node then it is not an error condition.

Change print message verbosity to debug to avoid spamming
console in such cases.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/phy/phy-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c
index 777d952b041..714be123856 100644
--- a/drivers/phy/phy-uclass.c
+++ b/drivers/phy/phy-uclass.c
@@ -415,7 +415,7 @@ int generic_phy_get_bulk(struct udevice *dev, struct phy_bulk *bulk)
 	if (!dev_read_prop(dev, "phys", NULL)) {
 		phydev = dev->parent;
 		if (!dev_read_prop(phydev, "phys", NULL)) {
-			pr_err("%s : no phys property\n", __func__);
+			pr_debug("%s : no phys property\n", __func__);
 			return 0;
 		}
 	}

---
base-commit: 3073246d1be682071d8b3d07d06c2484907aed60
change-id: 20241203-nophys-0b539d183a16

Best regards,
-- 
Roger Quadros <rogerq@kernel.org>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: don't spam console if phys property is absent in device node
  2024-12-03 20:57 [PATCH] phy: don't spam console if phys property is absent in device node Roger Quadros
@ 2024-12-06  6:49 ` Siddharth Vadapalli
  2024-12-19  3:10 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Siddharth Vadapalli @ 2024-12-06  6:49 UTC (permalink / raw)
  To: Roger Quadros
  Cc: Tom Rini, vigneshr, nm, j-humphreys, srk, s-vadapalli, u-boot

On Tue, Dec 03, 2024 at 10:57:36PM +0200, Roger Quadros wrote:
> In generic_phy_get_bulk(), if 'phys' property is absent in
> the device node then it is not an error condition.
> 
> Change print message verbosity to debug to avoid spamming
> console in such cases.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: don't spam console if phys property is absent in device node
  2024-12-03 20:57 [PATCH] phy: don't spam console if phys property is absent in device node Roger Quadros
  2024-12-06  6:49 ` Siddharth Vadapalli
@ 2024-12-19  3:10 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2024-12-19  3:10 UTC (permalink / raw)
  To: vigneshr, nm, Roger Quadros; +Cc: j-humphreys, srk, s-vadapalli, u-boot

On Tue, 03 Dec 2024 22:57:36 +0200, Roger Quadros wrote:

> In generic_phy_get_bulk(), if 'phys' property is absent in
> the device node then it is not an error condition.
> 
> Change print message verbosity to debug to avoid spamming
> console in such cases.
> 
> 
> [...]

Applied to u-boot/next, thanks!

-- 
Tom



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-19  3:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03 20:57 [PATCH] phy: don't spam console if phys property is absent in device node Roger Quadros
2024-12-06  6:49 ` Siddharth Vadapalli
2024-12-19  3:10 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox