From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Dragan Simic <dsimic@manjaro.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties
Date: Tue, 18 Feb 2025 16:31:38 -0600 [thread overview]
Message-ID: <20250218223138.GA1618326@bill-the-cat> (raw)
In-Reply-To: <20250211133116.28833-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]
On Tue, Feb 11, 2025 at 02:31:08PM +0100, Marek Vasut wrote:
> Introduce a new function mmc_env_is_redundant_in_both_boot_hwparts()
> which replaces IS_ENABLED(ENV_MMC_HWPART_REDUND) and internally does
> almost the same check as the macro which assigned ENV_MMC_HWPART_REDUND
> did, and call it in place of IS_ENABLED(ENV_MMC_HWPART_REDUND).
>
> The difference compared to IS_ENABLED(ENV_MMC_HWPART_REDUND) is
> in the last conditional, which does not do plain macro compare
> (CONFIG_ENV_OFFSET == CONFIG_ENV_OFFSET_REDUND), but instead does
> mmc_offset(mmc, 0) == mmc_offset(mmc, 1). If OF_CONTROL is not
> in use, this gets optimized back to original macro compare, but
> if OF_CONTROL is in use, this also takes into account the DT
> properties u-boot,mmc-env-offset and u-boot,mmc-env-offset-redundant.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
This introduces a failure to build on a number of platforms including
verdin-am62_a53 with:
+(verdin-am62_a53) env/mmc.c:208:13: error: 'mmc_env_is_redundant_in_both_boot_hwparts' defined but not used [-Werror=unused-function]
+(verdin-am62_a53) 208 | static bool mmc_env_is_redundant_in_both_boot_hwparts(struct mmc *mmc)
+(verdin-am62_a53) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(verdin-am62_a53) cc1: all warnings being treated as errors
+(verdin-am62_a53) make[3]: *** [scripts/Makefile.build:257: spl/env/mmc.o] Error 1
+(verdin-am62_a53) make[2]: *** [scripts/Makefile.xpl:550: spl/env] Error 2
+(verdin-am62_a53) make[1]: *** [Makefile:2115: spl/u-boot-spl] Error 2
+(verdin-am62_a53) make: *** [Makefile:177: sub-make] Error 2
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2025-02-18 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 13:31 [PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties Marek Vasut
2025-02-11 13:47 ` Quentin Schulz
2025-02-11 16:06 ` Marek Vasut
2025-02-11 16:39 ` Quentin Schulz
2025-02-13 8:30 ` Mattijs Korpershoek
2025-02-18 22:31 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218223138.GA1618326@bill-the-cat \
--to=trini@konsulko.com \
--cc=dsimic@manjaro.org \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=mkorpershoek@baylibre.com \
--cc=quentin.schulz@cherry.de \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox