From: Marek Vasut <marex@denx.de>
To: Quentin Schulz <quentin.schulz@cherry.de>, u-boot@lists.denx.de
Cc: Dragan Simic <dsimic@manjaro.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties
Date: Tue, 11 Feb 2025 17:06:08 +0100 [thread overview]
Message-ID: <6d6d0241-9be7-4b1c-bd45-98fa50cf5d65@denx.de> (raw)
In-Reply-To: <ec7c85b2-9275-497b-abcb-3daeb39f796e@cherry.de>
On 2/11/25 2:47 PM, Quentin Schulz wrote:
Hi,
>> + if (CONFIG_SYS_MMC_ENV_PART != 1)
>
> Oof what a terrible name for the actual meaning :/
>
> MMC hardware partition device number on the platform where the
> environment is stored. Note that this is not related to any
> software
> defined partition table but instead if we are in the user
> area, which is
> partition 0 or the first boot partition, which is 1 or some
> other defined
> partition.
>
> Would benefit from a small comment making this less confusing in the code.
Maybe CONFIG_SYS_MMC_ENV_PART should be renamed instead ... to some
CONFIG_ENV_MMC_HW_PART
> In any case,
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Less obscure ifdefery makes me happy.
Thank you
next prev parent reply other threads:[~2025-02-11 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 13:31 [PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties Marek Vasut
2025-02-11 13:47 ` Quentin Schulz
2025-02-11 16:06 ` Marek Vasut [this message]
2025-02-11 16:39 ` Quentin Schulz
2025-02-13 8:30 ` Mattijs Korpershoek
2025-02-18 22:31 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d6d0241-9be7-4b1c-bd45-98fa50cf5d65@denx.de \
--to=marex@denx.de \
--cc=dsimic@manjaro.org \
--cc=joe.hershberger@ni.com \
--cc=mkorpershoek@baylibre.com \
--cc=quentin.schulz@cherry.de \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox