From: Tom Rini <trini@konsulko.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: tkuw584924@gmail.com, u-boot@lists.denx.de,
Marek Vasut <marek.vasut@mailbox.org>,
jagan@amarulasolutions.com, vigneshr@ti.com, pratyush@kernel.org,
ashok.reddy.soma@amd.com, venkatesh.abbarapu@amd.com,
Hiroyuki.Saito2@infineon.com, Shinsuke.Okada@infineon.com,
Daisuke.Nakata@infineon.com, Bacem.Daassi@infineon.com,
Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH 2/2] mtd: spi-nor-core: Rework spansion_sr_ready() for parallel memories support
Date: Fri, 14 Mar 2025 08:54:15 -0600 [thread overview]
Message-ID: <20250314145415.GP2640854@bill-the-cat> (raw)
In-Reply-To: <b4fa6dc3-d9c5-4543-8410-5125a6fc9b7f@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Fri, Mar 14, 2025 at 07:40:17AM +0000, Tudor Ambarus wrote:
> + Marek,
>
> Hi,
>
> On 3/14/25 5:53 AM, tkuw584924@gmail.com wrote:
> > spansion_sr_ready() needs to support parallel memories configuration,
> > that reads status register value from each devices and combines the
> > status bits, likewise read_sr() and read_fsr().
>
> SNOR_F_HAS_PARALLEL describes 2 flashes that work in parallel mode. And
> we hacked SPI NOR and used a single spi_nor object to handle both
> flashes which is obviously wrong.
>
> My 2c is that we shouldn't build on top of a crumbling foundation. Until
> everything's moved on top of SPI NOR, I'd accept just fixes on this
> subject, so no new support. Tom and Jagan to decide.
Yes, I believe I was expecting some patches to redo / rework what we
have in-tree currently.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-03-14 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 5:53 [PATCH 0/2] zynqmp parallel memories support for Infineon Flash tkuw584924
2025-03-14 5:53 ` [PATCH 1/2] spi: zynqmp_gqspi: Make WR_ANY_REG opcode not use striped access tkuw584924
2025-03-14 5:53 ` [PATCH 2/2] mtd: spi-nor-core: Rework spansion_sr_ready() for parallel memories support tkuw584924
2025-03-14 7:40 ` Tudor Ambarus
2025-03-14 14:54 ` Tom Rini [this message]
2025-03-15 0:12 ` Takahiro Kuwano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314145415.GP2640854@bill-the-cat \
--to=trini@konsulko.com \
--cc=Bacem.Daassi@infineon.com \
--cc=Daisuke.Nakata@infineon.com \
--cc=Hiroyuki.Saito2@infineon.com \
--cc=Shinsuke.Okada@infineon.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=ashok.reddy.soma@amd.com \
--cc=jagan@amarulasolutions.com \
--cc=marek.vasut@mailbox.org \
--cc=pratyush@kernel.org \
--cc=tkuw584924@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox