U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: Marek Vasut <marek.vasut@mailbox.org>,
	u-boot@lists.denx.de, Paul Barker <paul.barker.ct@bp.renesas.com>,
	Simon Glass <sjg@chromium.org>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH 2/8] env: Rename SYS_REDUNDAND_ENVIRONMENT to ENV_REDUNDAND_ENVIRONMENT
Date: Tue, 25 Mar 2025 11:02:05 -0600	[thread overview]
Message-ID: <20250325170205.GK93000@bill-the-cat> (raw)
In-Reply-To: <cc0f556c-e9ed-458d-83d3-0f459f6e6c25@cherry.de>

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

On Tue, Mar 25, 2025 at 10:02:46AM +0100, Quentin Schulz wrote:
> Hi Marek,
> 
> On 3/24/25 11:52 PM, Marek Vasut wrote:
> > On 3/24/25 1:33 PM, Quentin Schulz wrote:
> > > Hi Marek,
> > > 
> > > On 3/22/25 10:55 PM, Marek Vasut wrote:
> > > > Rename the variable and add ENV_ prefix, so that all configuration
> > > > options which are related to environment would have an CONFIG_ENV_
> > > > prefix. No functional change.
> > > > 
> > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> > > > ---
> > > [...]
> > > > diff --git a/env/Kconfig b/env/Kconfig
> > > > index a177a354c8b..9ef45a7e3fe 100644
> > > > --- a/env/Kconfig
> > > > +++ b/env/Kconfig
> > > > @@ -463,7 +463,7 @@ config ENV_IS_IN_UBI
> > > >         the environment in.  This will enable redundant
> > > > environments in UBI.
> > > >         It is assumed that both volumes are in the same MTD partition.
> > > > -config SYS_REDUNDAND_ENVIRONMENT
> > > > +config ENV_REDUNDAND_ENVIRONMENT
> > > 
> > > Do either of the following:
> > > 
> > > 1) fix typo: s/REDUNDAND/REDUNDANT/
> > > 2) shorten name to be consistent with other symbols and avoid
> > > "env[...]environment" redundancy: config ENV_REDUND
> > CONFIG_ENV_REDUNDANT works for you ?
> 
> Fine with me!

Me as well, thanks! And for v2, please make a cover letter for when I
merge this in.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2025-03-25 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-22 21:55 [PATCH 1/8] env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE Marek Vasut
2025-03-22 21:55 ` [PATCH 2/8] env: Rename SYS_REDUNDAND_ENVIRONMENT to ENV_REDUNDAND_ENVIRONMENT Marek Vasut
2025-03-24 12:33   ` Quentin Schulz
2025-03-24 22:52     ` Marek Vasut
2025-03-25  9:02       ` Quentin Schulz
2025-03-25 17:02         ` Tom Rini [this message]
2025-03-22 21:55 ` [PATCH 3/8] env: Rename SYS_RELOC_GD_ENV_ADDR to ENV_RELOC_GD_ENV_ADDR Marek Vasut
2025-03-25 17:02   ` Tom Rini
2025-03-22 21:55 ` [PATCH 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_SDMMC_DEVICE_INDEX Marek Vasut
2025-03-24 12:39   ` Quentin Schulz
2025-03-25 23:02     ` Marek Vasut
2025-03-26  0:15       ` Tom Rini
2025-03-26  1:37         ` Marek Vasut
2025-03-26  9:22           ` Quentin Schulz
2025-03-27 14:36             ` Tom Rini
2025-03-22 21:55 ` [PATCH 5/8] env: Rename SYS_MMC_ENV_PART to ENV_SDMMC_EMMC_HW_PARTITION Marek Vasut
2025-03-24 12:44   ` Quentin Schulz
2025-03-22 21:55 ` [PATCH 6/8] env: Rename ENV_MMC_PARTITION to ENV_SDMMC_SW_PARTITION Marek Vasut
2025-03-24 12:50   ` Quentin Schulz
2025-03-22 21:55 ` [PATCH 7/8] env: Rename DEFAULT_ENV_FILE to ENV_DEFAULT_ENV_TEXT_FILE Marek Vasut
2025-03-22 21:55 ` [PATCH 8/8] env: Drop DELAY_ENVIRONMENT Marek Vasut
2025-03-24 12:27 ` [PATCH 1/8] env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE Quentin Schulz
2025-03-25 17:01 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250325170205.GK93000@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=marek.vasut@mailbox.org \
    --cc=paul.barker.ct@bp.renesas.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox