From: Quentin Schulz <quentin.schulz@cherry.de>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, u-boot@lists.denx.de
Cc: Paul Barker <paul.barker.ct@bp.renesas.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_SDMMC_DEVICE_INDEX
Date: Mon, 24 Mar 2025 13:39:40 +0100 [thread overview]
Message-ID: <90254a96-5d67-4d34-afe6-772af42ee557@cherry.de> (raw)
In-Reply-To: <20250322215624.18994-4-marek.vasut+renesas@mailbox.org>
Hi Marek,
On 3/22/25 10:55 PM, Marek Vasut wrote:
> Rename the variable and add ENV_ prefix, so that all configuration
> options which are related to environment would have an CONFIG_ENV_
> prefix. No functional change.
>
> Use ENV_SDMMC_DEVICE_INDEX to clarify this is the SD/MMC device
> index, a number, as enumerated by U-Boot. Update the help text
> accordingly.
>
I disagree with this part of the rename (MMC->SDMMC), our drivers all
are using mmc (env/mmc.*, drivers/mmc/*, cmd/mmc.c, ...) for both SD and
MMC. We also have ENV_IS_IN_MMC which is for both. I don't think it's
worth the confusion.
SYS_ prefix to ENV_ is fine though!
DEVICE_INDEX could be DEV_IDX too if we want to shorten the symbol name.
Cheers,
Quentin
next prev parent reply other threads:[~2025-03-24 12:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 21:55 [PATCH 1/8] env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE Marek Vasut
2025-03-22 21:55 ` [PATCH 2/8] env: Rename SYS_REDUNDAND_ENVIRONMENT to ENV_REDUNDAND_ENVIRONMENT Marek Vasut
2025-03-24 12:33 ` Quentin Schulz
2025-03-24 22:52 ` Marek Vasut
2025-03-25 9:02 ` Quentin Schulz
2025-03-25 17:02 ` Tom Rini
2025-03-22 21:55 ` [PATCH 3/8] env: Rename SYS_RELOC_GD_ENV_ADDR to ENV_RELOC_GD_ENV_ADDR Marek Vasut
2025-03-25 17:02 ` Tom Rini
2025-03-22 21:55 ` [PATCH 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_SDMMC_DEVICE_INDEX Marek Vasut
2025-03-24 12:39 ` Quentin Schulz [this message]
2025-03-25 23:02 ` Marek Vasut
2025-03-26 0:15 ` Tom Rini
2025-03-26 1:37 ` Marek Vasut
2025-03-26 9:22 ` Quentin Schulz
2025-03-27 14:36 ` Tom Rini
2025-03-22 21:55 ` [PATCH 5/8] env: Rename SYS_MMC_ENV_PART to ENV_SDMMC_EMMC_HW_PARTITION Marek Vasut
2025-03-24 12:44 ` Quentin Schulz
2025-03-22 21:55 ` [PATCH 6/8] env: Rename ENV_MMC_PARTITION to ENV_SDMMC_SW_PARTITION Marek Vasut
2025-03-24 12:50 ` Quentin Schulz
2025-03-22 21:55 ` [PATCH 7/8] env: Rename DEFAULT_ENV_FILE to ENV_DEFAULT_ENV_TEXT_FILE Marek Vasut
2025-03-22 21:55 ` [PATCH 8/8] env: Drop DELAY_ENVIRONMENT Marek Vasut
2025-03-24 12:27 ` [PATCH 1/8] env: Rename OVERWRITE_ETHADDR_ONCE to ENV_OVERWRITE_ETHADDR_ONCE Quentin Schulz
2025-03-25 17:01 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90254a96-5d67-4d34-afe6-772af42ee557@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox