From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: Raymond Mao <raymond.mao@linaro.org>,
u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Ravi Minnikanti <rminnikanti@marvell.com>,
Matthias Brugger <mbrugger@suse.com>,
Evgeny Bachinin <EABachinin@salutedevices.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Paul HENRYS <paul.henrys_ext@softathome.com>,
Philippe Reynes <philippe.reynes@softathome.com>,
Peter Robinson <pbrobinson@gmail.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 2/2] env: point fdt address to the fdt in a bloblist
Date: Fri, 28 Mar 2025 17:53:54 -0600 [thread overview]
Message-ID: <20250328235354.GG93000@bill-the-cat> (raw)
In-Reply-To: <CAFLszTiATNSdLgJ-PCEFjyTbwsgxTXg06W4Lj3Fv+zYwtKWcEA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Fri, Mar 28, 2025 at 05:35:04AM -0600, Simon Glass wrote:
> Hi Raymond,
>
> On Thu, 27 Mar 2025 at 17:13, Raymond Mao <raymond.mao@linaro.org> wrote:
> >
> > Point fdt_addr to the fdt embedded in the bloblist since fdt_addr
> > is a default address for bootefi, bootm and booti to look for the
> > device tree when launching the kernel.
>
> I wonder if we can drop use of that environment variable at some
> point? It seems strange to set a variable to gd->fdt_addr only to use
> it later. Why not just use gd->fdt_addr ?
Doubtful. Both fdt_addr and fdt_addr_r are documented with what they are
for and we'll likely never not have those as valid use cases. While it's
possible some day that we might be able to allocate valid addresses
everywhere we would still want to expose that to the user to do as they
see fit.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-03-28 23:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 23:13 [PATCH 1/2] bloblist: fix the overriding of fdt from bloblist Raymond Mao
2025-03-27 23:13 ` [PATCH 2/2] env: point fdt address to the fdt in a bloblist Raymond Mao
2025-03-28 11:35 ` Simon Glass
2025-03-28 15:05 ` Raymond Mao
2025-03-28 23:39 ` Simon Glass
2025-03-29 0:03 ` Tom Rini
2025-03-29 0:51 ` Raymond Mao
2025-03-28 23:53 ` Tom Rini [this message]
2025-03-28 23:51 ` Tom Rini
2025-03-31 14:07 ` Raymond Mao
2025-03-31 14:10 ` Tom Rini
2025-03-28 10:44 ` [PATCH 1/2] bloblist: fix the overriding of fdt from bloblist Caleb Connolly
2025-03-28 12:27 ` Caleb Connolly
2025-03-28 14:28 ` Raymond Mao
2025-03-28 11:34 ` Simon Glass
2025-03-28 14:17 ` Raymond Mao
2025-03-28 14:26 ` Simon Glass
2025-03-28 14:38 ` Raymond Mao
2025-03-28 15:12 ` Simon Glass
2025-03-29 1:17 ` Raymond Mao
2025-03-28 12:20 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328235354.GG93000@bill-the-cat \
--to=trini@konsulko.com \
--cc=EABachinin@salutedevices.com \
--cc=caleb.connolly@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mbrugger@suse.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul.henrys_ext@softathome.com \
--cc=pbrobinson@gmail.com \
--cc=philippe.reynes@softathome.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=raymond.mao@linaro.org \
--cc=rminnikanti@marvell.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox