Re: [PATCH 2/2] env: point fdt address to the fdt in a bloblist

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Fri, Mar 28, 2025 at 11:39:13PM +0000, Simon Glass wrote:
> Hi Raymond,
> 
> On Fri, 28 Mar 2025 at 09:06, Raymond Mao <raymond.mao@linaro.org> wrote:
> >
> > Hi Simon,
> >
> > On Fri, 28 Mar 2025 at 07:35, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Raymond,
> > >
> > > On Thu, 27 Mar 2025 at 17:13, Raymond Mao <raymond.mao@linaro.org> wrote:
> > > >
> > > > Point fdt_addr to the fdt embedded in the bloblist since fdt_addr
> > > > is a default address for bootefi, bootm and booti to look for the
> > > > device tree when launching the kernel.
> > >
> > > I wonder if we can drop use of that environment variable at some
> > > point? It seems strange to set a variable to gd->fdt_addr only to use
> > > it later. Why not just use gd->fdt_addr ?
> > >
> >
> > First, the fdtdec happens in an early stage and it is not able to set
> > the env variable at that time.
> 
> No, I mean actually drop use of the environment var, so we wouldn't
> set it at all.

The environment is for humans and also other use cases. It's not going
away.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]