U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: usb: r8152: add device id of Linksys USB3GIGV1
@ 2025-03-31 15:06 Gabor Juhos
  2025-04-10 17:57 ` Marek Vasut
  0 siblings, 1 reply; 2+ messages in thread
From: Gabor Juhos @ 2025-03-31 15:06 UTC (permalink / raw)
  To: Marek Vasut, Tom Rini; +Cc: u-boot, Gabor Juhos

The Linksys USB3GIGV1 device is a USB 3.0 Wired Gigabit Adapter
supporting 10/100/1000 Mbits/sec transfer rates. It is based on
RTL8153 and it works correctly with the r8152 driver:

  uDPU>> usb start
  starting USB...
  Bus usb@58000: Register 2000104 NbrPorts 2
  Starting the controller
  USB XHCI 1.00
  scanning bus usb@58000 for devices... 2 USB Device(s) found
         scanning usb for storage devices... 0 Storage Device(s) found
  uDPU>> usb info 1
  config for device 1
  2: Vendor specific,  USB Revision 2.10
   - Linksys Linksys USB3GIGV1 000001000000
   - Class: (from Interface) Vendor specific
   - PacketSize: 64  Configurations: 2
   - Vendor: 0x13b1  Product 0x0041 Version 48.0
     Configuration: 1
     - Interfaces: 1 Bus Powered Remote Wakeup 180mA
       Interface: 0
       - Alternate Setting 0, Endpoints: 3
       - Class Vendor specific
       - Endpoint 1 In Bulk MaxPacket 512
       - Endpoint 2 Out Bulk MaxPacket 512
       - Endpoint 3 In Interrupt MaxPacket 2 Interval 8ms

  uDPU>> dm tree usb@58000
   Class     Seq    Probed  Driver                Name
  -----------------------------------------------------------
   usb           0  [ + ]   xhci_mvebu            usb@58000
   usb_hub       0  [ + ]   usb_hub               `-- usb_hub
   ethernet      2  [ + ]   r8152_eth                 `-- r8152_eth
   bootdev       3  [   ]   eth_bootdev                   `-- r8152_eth.bootdev
  uDPU>> setenv ethact r8152_eth
  uDPU>> setenv serverip 192.168.1.253
  uDPU>> setenv ipaddr 192.168.1.1
  uDPU>> ping 192.168.1.253
  Using r8152_eth device
  host 192.168.1.253 is alive
  uDPU>> tftpboot 0x10000000 random.bin
  Using r8152_eth device
  TFTP from server 192.168.1.253; our IP address is 192.168.1.1
  Filename 'random.bin'.
  Load address: 0x10000000
  Loading: #################################################################
  	 #################################################################
  	 #################################################################
  	 #################################################################
  	 #################################################################
  	 #################################################################
  	 #################################################################
  	 #################################################################
  	 ####################################################
  	 6.3 MiB/s
  done
  Bytes transferred = 8388608 (800000 hex)
  uDPU>>

Add the USB id of the device to the driver to allow using it
from U-Boot.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
Note: checkpatch.pl shows the following warnings:

WARNING: Possible repeated word: 'Linksys'
   - Linksys Linksys USB3GIGV1 000001000000

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
   bootdev       3  [   ]   eth_bootdev                   `-- r8152_eth.bootdev

total: 0 errors, 2 warnings, 0 checks, 9 lines checked

Since both warnings are related to actual lines from an U-Boot console log,
I have ignored those.
---
 drivers/usb/eth/r8152.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c
index e3f20e08c33cac4f8520dc670d22a1be6f3f10e7..d8f41dd1eb51cbf09c7da124ca8350e431c2b7fb 100644
--- a/drivers/usb/eth/r8152.c
+++ b/drivers/usb/eth/r8152.c
@@ -1599,6 +1599,9 @@ static const struct usb_device_id r8152_eth_id_table[] = {
 	/* Samsung */
 	{ USB_DEVICE(0x04e8, 0xa101) },
 
+	/* Linksys */
+	{ USB_DEVICE(0x13b1, 0x0041) },  /* USB3GIGV1 */
+
 	/* Lenovo */
 	{ USB_DEVICE(0x17ef, 0x304f) },
 	{ USB_DEVICE(0x17ef, 0x3052) },

---
base-commit: 3d8be1f5ec30180748259a251efe4f63c8b4b329
change-id: 20250331-usb3gigv1-5061f609abc0

Best regards,
-- 
Gabor Juhos <j4g8y7@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: usb: r8152: add device id of Linksys USB3GIGV1
  2025-03-31 15:06 [PATCH] net: usb: r8152: add device id of Linksys USB3GIGV1 Gabor Juhos
@ 2025-04-10 17:57 ` Marek Vasut
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2025-04-10 17:57 UTC (permalink / raw)
  To: Gabor Juhos, Tom Rini; +Cc: u-boot

On 3/31/25 5:06 PM, Gabor Juhos wrote:
> The Linksys USB3GIGV1 device is a USB 3.0 Wired Gigabit Adapter
> supporting 10/100/1000 Mbits/sec transfer rates. It is based on
> RTL8153 and it works correctly with the r8152 driver:
> 
>    uDPU>> usb start
>    starting USB...
>    Bus usb@58000: Register 2000104 NbrPorts 2
>    Starting the controller
>    USB XHCI 1.00
>    scanning bus usb@58000 for devices... 2 USB Device(s) found
>           scanning usb for storage devices... 0 Storage Device(s) found
>    uDPU>> usb info 1
>    config for device 1
>    2: Vendor specific,  USB Revision 2.10
>     - Linksys Linksys USB3GIGV1 000001000000
>     - Class: (from Interface) Vendor specific
>     - PacketSize: 64  Configurations: 2
>     - Vendor: 0x13b1  Product 0x0041 Version 48.0
>       Configuration: 1
>       - Interfaces: 1 Bus Powered Remote Wakeup 180mA
>         Interface: 0
>         - Alternate Setting 0, Endpoints: 3
>         - Class Vendor specific
>         - Endpoint 1 In Bulk MaxPacket 512
>         - Endpoint 2 Out Bulk MaxPacket 512
>         - Endpoint 3 In Interrupt MaxPacket 2 Interval 8ms
> 
>    uDPU>> dm tree usb@58000
>     Class     Seq    Probed  Driver                Name
>    -----------------------------------------------------------
>     usb           0  [ + ]   xhci_mvebu            usb@58000
>     usb_hub       0  [ + ]   usb_hub               `-- usb_hub
>     ethernet      2  [ + ]   r8152_eth                 `-- r8152_eth
>     bootdev       3  [   ]   eth_bootdev                   `-- r8152_eth.bootdev
>    uDPU>> setenv ethact r8152_eth
>    uDPU>> setenv serverip 192.168.1.253
>    uDPU>> setenv ipaddr 192.168.1.1
>    uDPU>> ping 192.168.1.253
>    Using r8152_eth device
>    host 192.168.1.253 is alive
>    uDPU>> tftpboot 0x10000000 random.bin
>    Using r8152_eth device
>    TFTP from server 192.168.1.253; our IP address is 192.168.1.1
>    Filename 'random.bin'.
>    Load address: 0x10000000
>    Loading: #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 #################################################################
>    	 ####################################################
>    	 6.3 MiB/s
>    done
>    Bytes transferred = 8388608 (800000 hex)
>    uDPU>>
> 
> Add the USB id of the device to the driver to allow using it
> from U-Boot.
> 
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Marek Vasut <marex@denx.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-10 18:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 15:06 [PATCH] net: usb: r8152: add device id of Linksys USB3GIGV1 Gabor Juhos
2025-04-10 17:57 ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox