[PATCH 0/2] acpi,smbios: select CONFIG_BLOBLIST

[PATCH 0/2] acpi,smbios: select CONFIG_BLOBLIST

[Heinrich Schuchardt]

Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
`make qemu-riscv64_smode_defconfig acpi.config` fails.

We need to enable CONFIG_BLOBLIST.

Heinrich Schuchardt (2):
  acpi: select CONFIG_BLOBLIST
  smbios: select CONFIG_BLOBLIST

 drivers/misc/Kconfig | 1 +
 lib/Kconfig          | 1 +
 2 files changed, 2 insertions(+)

-- 
2.48.1

[PATCH 1/2] acpi: select CONFIG_BLOBLIST

[Heinrich Schuchardt]

Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
`make qemu-riscv64_smode_defconfig acpi.config && make` fails with

    qfw_acpi.c:146:(.text.evt_write_acpi_tables+0xc):
    undefined reference to `bloblist_add'

Build with bloblist support.

Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Kconfig b/lib/Kconfig
index 1a683dea670..a348fccebdd 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -317,6 +317,7 @@ config SPL_ACPI
 config GENERATE_ACPI_TABLE
 	bool "Generate an ACPI (Advanced Configuration and Power Interface) table"
 	depends on ACPI
+	select BLOBLIST
 	select QFW if QEMU
 	help
 	  The Advanced Configuration and Power Interface (ACPI) specification
-- 
2.48.1

[PATCH 2/2] smbios: select CONFIG_BLOBLIST

[Heinrich Schuchardt]

Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
`make qemu-riscv64_smode_defconfig acpi.config && make` fails with

    drivers/misc/qfw_smbios.c:93:(.text.qfw_evt_write_smbios_tables+0xe):
    undefined reference to `bloblist_add'

Build with bloblist support.

Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 drivers/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index da84b35e804..6312f54a3ca 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -569,6 +569,7 @@ config QFW_SMBIOS
 	bool
 	default y
 	depends on QFW && SMBIOS && !SANDBOX && !SYSINFO_SMBIOS
+	select BLOBLIST
 	help
 	  Hidden option to read SMBIOS tables from QEMU.
 
-- 
2.48.1

Re: [PATCH 1/2] acpi: select CONFIG_BLOBLIST

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Mon, Apr 07, 2025 at 08:44:23AM +0200, Heinrich Schuchardt wrote:

> Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
> `make qemu-riscv64_smode_defconfig acpi.config && make` fails with
> 
>     qfw_acpi.c:146:(.text.evt_write_acpi_tables+0xc):
>     undefined reference to `bloblist_add'
> 
> Build with bloblist support.
> 
> Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 2/2] smbios: select CONFIG_BLOBLIST

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Mon, Apr 07, 2025 at 08:44:24AM +0200, Heinrich Schuchardt wrote:

> Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
> `make qemu-riscv64_smode_defconfig acpi.config && make` fails with
> 
>     drivers/misc/qfw_smbios.c:93:(.text.qfw_evt_write_smbios_tables+0xe):
>     undefined reference to `bloblist_add'
> 
> Build with bloblist support.
> 
> Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 1/2] acpi: select CONFIG_BLOBLIST

[Ilias Apalodimas]

On Mon, 7 Apr 2025 at 09:44, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
> `make qemu-riscv64_smode_defconfig acpi.config && make` fails with
>
>     qfw_acpi.c:146:(.text.evt_write_acpi_tables+0xc):
>     undefined reference to `bloblist_add'
>
> Build with bloblist support.
>
> Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 1a683dea670..a348fccebdd 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -317,6 +317,7 @@ config SPL_ACPI
>  config GENERATE_ACPI_TABLE
>         bool "Generate an ACPI (Advanced Configuration and Power Interface) table"
>         depends on ACPI
> +       select BLOBLIST
>         select QFW if QEMU
>         help
>           The Advanced Configuration and Power Interface (ACPI) specification
> --
> 2.48.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Re: [PATCH 2/2] smbios: select CONFIG_BLOBLIST

[Ilias Apalodimas]

On Mon, 7 Apr 2025 at 09:44, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since commit 53d5a221632e ("emulation: Use bloblist to hold tables")
> `make qemu-riscv64_smode_defconfig acpi.config && make` fails with
>
>     drivers/misc/qfw_smbios.c:93:(.text.qfw_evt_write_smbios_tables+0xe):
>     undefined reference to `bloblist_add'
>
> Build with bloblist support.
>
> Fixes: 53d5a221632e ("emulation: Use bloblist to hold tables")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  drivers/misc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index da84b35e804..6312f54a3ca 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -569,6 +569,7 @@ config QFW_SMBIOS
>         bool
>         default y
>         depends on QFW && SMBIOS && !SANDBOX && !SYSINFO_SMBIOS
> +       select BLOBLIST
>         help
>           Hidden option to read SMBIOS tables from QEMU.
>
> --
> 2.48.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>