U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Judith Mendez <jm@ti.com>
To: Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Cc: Bryan Brattlof <bb@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	<u-boot@lists.denx.de>
Subject: [PATCH 2/5] mmc: am654_sdhci: Fix HIGH_SPEED_ENA
Date: Tue, 8 Apr 2025 12:05:24 -0500	[thread overview]
Message-ID: <20250408170527.2832563-3-jm@ti.com> (raw)
In-Reply-To: <20250408170527.2832563-1-jm@ti.com>

High Speed enable bit switches data launch from the falling
clock edge (half cycle timing) to the rising clock edge (full
cycle timing). For all SD UHS modes, data launch must happen
at the rising clock edge, so set HIGH_SPEED_ENA for SDR12 and
SDR25 modes. For all HS modes, data launch must happen at the
falling clock edge, so do not set HIGH_SPEED_ENA for MMC_HS_52.

Signed-off-by: Judith Mendez <jm@ti.com>
---
 drivers/mmc/am654_sdhci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c
index e4fa8a88565..28d82afd012 100644
--- a/drivers/mmc/am654_sdhci.c
+++ b/drivers/mmc/am654_sdhci.c
@@ -412,8 +412,7 @@ static void am654_sdhci_write_b(struct sdhci_host *host, u8 val, int reg)
 		 */
 		case SD_HS:
 		case MMC_HS:
-		case UHS_SDR12:
-		case UHS_SDR25:
+		case MMC_HS_52:
 			val &= ~SDHCI_CTRL_HISPD;
 		default:
 			break;
-- 
2.49.0


  parent reply	other threads:[~2025-04-08 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 17:05 [PATCH 0/5] More MMC fixes Judith Mendez
2025-04-08 17:05 ` [PATCH 1/5] mmc: am654_sdhci: Add MMC_HS_52 to timing data Judith Mendez
2025-04-08 17:05 ` Judith Mendez [this message]
2025-04-08 17:05 ` [PATCH 3/5] mmc: am654_sdhci: Add am654_sdhci_set_control_reg Judith Mendez
2025-04-08 17:05 ` [PATCH 4/5] configs: am62px_evm_r5/a53_defconfig: Disable eMMC HS400 Judith Mendez
2025-04-08 17:05 ` [PATCH 5/5] configs: am62*_evm_a53_defconfig: Add TI_COMMON_CMD_OPTIONS Judith Mendez
2025-04-12 17:04 ` [PATCH 0/5] More MMC fixes Bryan Brattlof
2025-04-14 14:40   ` Judith Mendez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250408170527.2832563-3-jm@ti.com \
    --to=jm@ti.com \
    --cc=bb@ti.com \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox