[PATCH] mtd: ubi: Put MTD device after it is not used

[PATCH] mtd: ubi: Put MTD device after it is not used

[Alexander Vickberg]

The MTD device reference is dropped via put_mtd_device, however its
field ->index is read and passed to ubi_msg. To fix this, the patch
moves the reference dropping after calling ubi_msg.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

Upstream Linux commit: b95f83ab762dd6211351b9140f99f43644076ca8

Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
---
 drivers/mtd/ubi/build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 50e43928af0..4881287dd6b 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1152,10 +1152,10 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway)
 	ubi_wl_close(ubi);
 	ubi_free_internal_volumes(ubi);
 	vfree(ubi->vtbl);
-	put_mtd_device(ubi->mtd);
 	vfree(ubi->peb_buf);
 	vfree(ubi->fm_buf);
 	ubi_msg(ubi, "mtd%d is detached", ubi->mtd->index);
+	put_mtd_device(ubi->mtd);
 	put_device(&ubi->dev);
 	return 0;
 }
-- 
2.43.0

Re: [PATCH] mtd: ubi: Put MTD device after it is not used

[Heiko Schocher]

Hello Alexander,

On 10.04.25 13:37, Alexander Vickberg wrote:
> The MTD device reference is dropped via put_mtd_device, however its
> field ->index is read and passed to ubi_msg. To fix this, the patch
> moves the reference dropping after calling ubi_msg.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> Upstream Linux commit: b95f83ab762dd6211351b9140f99f43644076ca8
> 
> Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
> ---
>   drivers/mtd/ubi/build.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

Re: [PATCH] mtd: ubi: Put MTD device after it is not used

[Heiko Schocher]

Hello Alexander,

On 11.04.25 06:21, Heiko Schocher wrote:
> Hello Alexander,
> 
> On 10.04.25 13:37, Alexander Vickberg wrote:
>> The MTD device reference is dropped via put_mtd_device, however its
>> field ->index is read and passed to ubi_msg. To fix this, the patch
>> moves the reference dropping after calling ubi_msg.
>>
>> Signed-off-by: Pan Bian <bianpan2016@163.com>
>> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>
>> Upstream Linux commit: b95f83ab762dd6211351b9140f99f43644076ca8
>>
>> Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
>> ---
>>   drivers/mtd/ubi/build.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks!
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot-ubi master

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de