From: Martin Schiller <ms@dev.tdt.de>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, josua@solid-run.com, sr@denx.de,
Martin Schiller <ms@dev.tdt.de>
Subject: [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM
Date: Wed, 16 Apr 2025 08:13:16 +0200 [thread overview]
Message-ID: <20250416061316.1348271-1-ms@dev.tdt.de> (raw)
Commit f6eff35b8c19 ("cmd: tlv_eeprom: handle -ENODEV error from
read_eeprom function") removed the needed 'return 0' after a successful
read. As a result, the usage message is shown when 'tlv_eeprom read' is
successfully called.
Let's fix it by adding the needed 'return 0'.
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
---
cmd/tlv_eeprom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
index 0aec7521770..d7c229e5441 100644
--- a/cmd/tlv_eeprom.c
+++ b/cmd/tlv_eeprom.c
@@ -476,6 +476,7 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
printf("EEPROM data loaded from device to memory.\n");
has_been_read = 1;
+ return 0;
}
// Subsequent commands require that the EEPROM has already been read.
--
2.39.5
next reply other threads:[~2025-04-16 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 6:13 Martin Schiller [this message]
2025-04-17 7:03 ` [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM Stefan Roese
2025-05-16 11:39 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416061316.1348271-1-ms@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=josua@solid-run.com \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox