* [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM
@ 2025-04-16 6:13 Martin Schiller
2025-04-17 7:03 ` Stefan Roese
2025-05-16 11:39 ` Stefan Roese
0 siblings, 2 replies; 3+ messages in thread
From: Martin Schiller @ 2025-04-16 6:13 UTC (permalink / raw)
To: u-boot; +Cc: trini, josua, sr, Martin Schiller
Commit f6eff35b8c19 ("cmd: tlv_eeprom: handle -ENODEV error from
read_eeprom function") removed the needed 'return 0' after a successful
read. As a result, the usage message is shown when 'tlv_eeprom read' is
successfully called.
Let's fix it by adding the needed 'return 0'.
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
---
cmd/tlv_eeprom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
index 0aec7521770..d7c229e5441 100644
--- a/cmd/tlv_eeprom.c
+++ b/cmd/tlv_eeprom.c
@@ -476,6 +476,7 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
printf("EEPROM data loaded from device to memory.\n");
has_been_read = 1;
+ return 0;
}
// Subsequent commands require that the EEPROM has already been read.
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM
2025-04-16 6:13 [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM Martin Schiller
@ 2025-04-17 7:03 ` Stefan Roese
2025-05-16 11:39 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2025-04-17 7:03 UTC (permalink / raw)
To: Martin Schiller, u-boot; +Cc: trini, josua
On 16.04.25 08:13, Martin Schiller wrote:
> Commit f6eff35b8c19 ("cmd: tlv_eeprom: handle -ENODEV error from
> read_eeprom function") removed the needed 'return 0' after a successful
> read. As a result, the usage message is shown when 'tlv_eeprom read' is
> successfully called.
>
> Let's fix it by adding the needed 'return 0'.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> cmd/tlv_eeprom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
> index 0aec7521770..d7c229e5441 100644
> --- a/cmd/tlv_eeprom.c
> +++ b/cmd/tlv_eeprom.c
> @@ -476,6 +476,7 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>
> printf("EEPROM data loaded from device to memory.\n");
> has_been_read = 1;
> + return 0;
> }
>
> // Subsequent commands require that the EEPROM has already been read.
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM
2025-04-16 6:13 [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM Martin Schiller
2025-04-17 7:03 ` Stefan Roese
@ 2025-05-16 11:39 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2025-05-16 11:39 UTC (permalink / raw)
To: Martin Schiller, u-boot; +Cc: trini, josua
On 16.04.25 08:13, Martin Schiller wrote:
> Commit f6eff35b8c19 ("cmd: tlv_eeprom: handle -ENODEV error from
> read_eeprom function") removed the needed 'return 0' after a successful
> read. As a result, the usage message is shown when 'tlv_eeprom read' is
> successfully called.
>
> Let's fix it by adding the needed 'return 0'.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> cmd/tlv_eeprom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
> index 0aec7521770..d7c229e5441 100644
> --- a/cmd/tlv_eeprom.c
> +++ b/cmd/tlv_eeprom.c
> @@ -476,6 +476,7 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>
> printf("EEPROM data loaded from device to memory.\n");
> has_been_read = 1;
> + return 0;
> }
>
> // Subsequent commands require that the EEPROM has already been read.
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-16 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 6:13 [PATCH] cmd: tlv_eeprom: return after successful read from EEPROM Martin Schiller
2025-04-17 7:03 ` Stefan Roese
2025-05-16 11:39 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox