* [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[]
@ 2025-04-16 6:29 Martin Schiller
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin Schiller @ 2025-04-16 6:29 UTC (permalink / raw)
To: u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream, hs,
trini, ansuelsmth, Martin Schiller
This adds the missing empty entry at the end of mtk_i2c_ids[].
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
---
drivers/i2c/mtk_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/mtk_i2c.c b/drivers/i2c/mtk_i2c.c
index 3450177741a..6edf3f44eca 100644
--- a/drivers/i2c/mtk_i2c.c
+++ b/drivers/i2c/mtk_i2c.c
@@ -879,7 +879,7 @@ static const struct udevice_id mtk_i2c_ids[] = {
}, {
.compatible = "mediatek,mt8518-i2c",
.data = (ulong)&mt8518_soc_data,
- }
+ }, {}
};
U_BOOT_DRIVER(mtk_i2c) = {
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]
2025-04-16 6:29 [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Martin Schiller
@ 2025-04-16 6:29 ` Martin Schiller
2025-04-16 9:10 ` Heiko Schocher
2025-04-22 15:21 ` Heiko Schocher
2025-04-16 9:09 ` [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Heiko Schocher
2025-04-22 15:20 ` Heiko Schocher
2 siblings, 2 replies; 6+ messages in thread
From: Martin Schiller @ 2025-04-16 6:29 UTC (permalink / raw)
To: u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream, hs,
trini, ansuelsmth, Martin Schiller
This removes a duplicate entry in mt_i2c_regs_v1[].
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
---
drivers/i2c/mtk_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/mtk_i2c.c b/drivers/i2c/mtk_i2c.c
index 6edf3f44eca..55381dbeced 100644
--- a/drivers/i2c/mtk_i2c.c
+++ b/drivers/i2c/mtk_i2c.c
@@ -143,7 +143,6 @@ static const uint mt_i2c_regs_v1[] = {
[REG_RSV_DEBUG] = 0x44,
[REG_HS] = 0x48,
[REG_SOFTRESET] = 0x50,
- [REG_SOFTRESET] = 0x50,
[REG_DCM_EN] = 0x54,
[REG_DEBUGSTAT] = 0x64,
[REG_DEBUGCTRL] = 0x68,
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[]
2025-04-16 6:29 [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Martin Schiller
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
@ 2025-04-16 9:09 ` Heiko Schocher
2025-04-22 15:20 ` Heiko Schocher
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2025-04-16 9:09 UTC (permalink / raw)
To: Martin Schiller, u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream,
trini, ansuelsmth
Hello Martin,
On 16.04.25 08:29, Martin Schiller wrote:
> This adds the missing empty entry at the end of mtk_i2c_ids[].
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> ---
> drivers/i2c/mtk_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/mtk_i2c.c b/drivers/i2c/mtk_i2c.c
> index 3450177741a..6edf3f44eca 100644
> --- a/drivers/i2c/mtk_i2c.c
> +++ b/drivers/i2c/mtk_i2c.c
> @@ -879,7 +879,7 @@ static const struct udevice_id mtk_i2c_ids[] = {
> }, {
> .compatible = "mediatek,mt8518-i2c",
> .data = (ulong)&mt8518_soc_data,
> - }
> + }, {}
> };
>
> U_BOOT_DRIVER(mtk_i2c) = {
>
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
@ 2025-04-16 9:10 ` Heiko Schocher
2025-04-22 15:21 ` Heiko Schocher
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2025-04-16 9:10 UTC (permalink / raw)
To: Martin Schiller, u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream,
trini, ansuelsmth
Hello Martin,
On 16.04.25 08:29, Martin Schiller wrote:
> This removes a duplicate entry in mt_i2c_regs_v1[].
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> ---
> drivers/i2c/mtk_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/mtk_i2c.c b/drivers/i2c/mtk_i2c.c
> index 6edf3f44eca..55381dbeced 100644
> --- a/drivers/i2c/mtk_i2c.c
> +++ b/drivers/i2c/mtk_i2c.c
> @@ -143,7 +143,6 @@ static const uint mt_i2c_regs_v1[] = {
> [REG_RSV_DEBUG] = 0x44,
> [REG_HS] = 0x48,
> [REG_SOFTRESET] = 0x50,
> - [REG_SOFTRESET] = 0x50,
> [REG_DCM_EN] = 0x54,
> [REG_DEBUGSTAT] = 0x64,
> [REG_DEBUGCTRL] = 0x68,
>
good catch, thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[]
2025-04-16 6:29 [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Martin Schiller
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
2025-04-16 9:09 ` [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Heiko Schocher
@ 2025-04-22 15:20 ` Heiko Schocher
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2025-04-22 15:20 UTC (permalink / raw)
To: Martin Schiller, u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream,
trini, ansuelsmth
Hello Amrtin,
On 16.04.25 08:29, Martin Schiller wrote:
> This adds the missing empty entry at the end of mtk_i2c_ids[].
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> ---
> drivers/i2c/mtk_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-i2c master
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
2025-04-16 9:10 ` Heiko Schocher
@ 2025-04-22 15:21 ` Heiko Schocher
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2025-04-22 15:21 UTC (permalink / raw)
To: Martin Schiller, u-boot
Cc: ryder.lee, weijie.gao, chunfeng.yun, GSS_MTK_Uboot_upstream,
trini, ansuelsmth
Hello Martin,
On 16.04.25 08:29, Martin Schiller wrote:
> This removes a duplicate entry in mt_i2c_regs_v1[].
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> ---
> drivers/i2c/mtk_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to u-boot-i2c master
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-04-22 15:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 6:29 [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Martin Schiller
2025-04-16 6:29 ` [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[] Martin Schiller
2025-04-16 9:10 ` Heiko Schocher
2025-04-22 15:21 ` Heiko Schocher
2025-04-16 9:09 ` [PATCH 1/2] i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[] Heiko Schocher
2025-04-22 15:20 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox