U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions
@ 2025-04-28 14:49 Daniel Schultz
  2025-04-28 14:49 ` [PATCH 2/3] include: env: phytec: k3_net: Use get_cmd Daniel Schultz
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Daniel Schultz @ 2025-04-28 14:49 UTC (permalink / raw)
  To: ggiordano, w.egorov, trini, u-boot, joe.hershberger
  Cc: d.schultz, bb, nmorrisson, upstream

Extensions are now handled by the board-code. Remove this non-existing
function to proper boot from network.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 include/env/phytec/k3_net.env | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/env/phytec/k3_net.env b/include/env/phytec/k3_net.env
index 8ad1cb7b0c2..2ccdc9eaa59 100644
--- a/include/env/phytec/k3_net.env
+++ b/include/env/phytec/k3_net.env
@@ -18,5 +18,4 @@ netboot=run netargs;
 	run netloadimage;
 	run netloadfdt;
 	run net_apply_overlays;
-	run net_apply_extensions;
 	booti ${kernel_addr_r} - ${fdt_addr_r}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] include: env: phytec: k3_net: Use get_cmd
  2025-04-28 14:49 [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Daniel Schultz
@ 2025-04-28 14:49 ` Daniel Schultz
  2025-04-28 14:49 ` [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment Daniel Schultz
  2025-05-07 15:24 ` [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Tom Rini
  2 siblings, 0 replies; 7+ messages in thread
From: Daniel Schultz @ 2025-04-28 14:49 UTC (permalink / raw)
  To: ggiordano, w.egorov, trini, u-boot, joe.hershberger
  Cc: d.schultz, bb, nmorrisson, upstream

'net_fetch_cmd' is not defined by the K3 board files. They
use the more common 'get_cmd' from NXP products.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 include/env/phytec/k3_net.env | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/env/phytec/k3_net.env b/include/env/phytec/k3_net.env
index 2ccdc9eaa59..4d5c703cae9 100644
--- a/include/env/phytec/k3_net.env
+++ b/include/env/phytec/k3_net.env
@@ -10,8 +10,8 @@
 
 netargs=setenv bootargs console=${console} root=/dev/nfs ip=dhcp rw
 	nfsroot=${serverip}:${nfsroot},vers=4,tcp ${optargs}
-netloadimage=${net_fetch_cmd} ${kernel_addr_r} ${serverip}:/Image
-netloadfdt=${net_fetch_cmd} ${fdt_addr_r} ${serverip}:/${fdtfile}
+netloadimage=${get_cmd} ${kernel_addr_r} ${serverip}:/Image
+netloadfdt=${get_cmd} ${fdt_addr_r} ${serverip}:/${fdtfile}
 netboot=run netargs;
 	setenv autoload no;
 	dhcp;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment
  2025-04-28 14:49 [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Daniel Schultz
  2025-04-28 14:49 ` [PATCH 2/3] include: env: phytec: k3_net: Use get_cmd Daniel Schultz
@ 2025-04-28 14:49 ` Daniel Schultz
  2025-04-28 16:10   ` Tom Rini
  2025-05-07 15:24 ` [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Tom Rini
  2 siblings, 1 reply; 7+ messages in thread
From: Daniel Schultz @ 2025-04-28 14:49 UTC (permalink / raw)
  To: ggiordano, w.egorov, trini, u-boot, joe.hershberger
  Cc: d.schultz, bb, nmorrisson, upstream

Add fit_addr_r to the environment to allow us to boot from a FIT image.

Increase the maximum Image size from 23 MB to 26 MB by moving the
initramfs start address up. This gives us a bigger ranger to
provide kernel images which are not stripped down too much.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 board/phytec/phycore_am62ax/phycore_am62ax.env | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/phytec/phycore_am62ax/phycore_am62ax.env b/board/phytec/phycore_am62ax/phycore_am62ax.env
index a0eacd1dfc3..40787b0cbcb 100644
--- a/board/phytec/phycore_am62ax/phycore_am62ax.env
+++ b/board/phytec/phycore_am62ax/phycore_am62ax.env
@@ -10,6 +10,7 @@ fdt_addr_r=0x88000000
 kernel_addr_r=0x82000000
 ramdisk_addr_r=0x88080000
 fdtoverlay_addr_r=0x89000000
+fit_addr_r=0x90000000
 
 fdtfile=CONFIG_DEFAULT_FDT_FILE
 mmcdev=1
@@ -22,4 +23,4 @@ get_cmd=tftp
 
 spi_fdt_addr=0x700000
 spi_image_addr=0x800000
-spi_ramdisk_addr=0x1e00000
+spi_ramdisk_addr=0x2200000
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment
  2025-04-28 14:49 ` [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment Daniel Schultz
@ 2025-04-28 16:10   ` Tom Rini
  2025-04-29 12:14     ` Daniel Schultz
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2025-04-28 16:10 UTC (permalink / raw)
  To: Daniel Schultz
  Cc: ggiordano, w.egorov, u-boot, joe.hershberger, bb, nmorrisson,
	upstream

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On Mon, Apr 28, 2025 at 07:49:04AM -0700, Daniel Schultz wrote:

> Add fit_addr_r to the environment to allow us to boot from a FIT image.
> 
> Increase the maximum Image size from 23 MB to 26 MB by moving the
> initramfs start address up. This gives us a bigger ranger to
> provide kernel images which are not stripped down too much.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  board/phytec/phycore_am62ax/phycore_am62ax.env | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What is the minimum memory configuration you have to work with here?
That's still a very small window unless you're shipping modules with
512MiB or so.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment
  2025-04-28 16:10   ` Tom Rini
@ 2025-04-29 12:14     ` Daniel Schultz
  2025-04-29 14:17       ` Tom Rini
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Schultz @ 2025-04-29 12:14 UTC (permalink / raw)
  To: Tom Rini
  Cc: ggiordano, w.egorov, u-boot, joe.hershberger, bb, nmorrisson,
	upstream


On 4/28/25 18:10, Tom Rini wrote:
> On Mon, Apr 28, 2025 at 07:49:04AM -0700, Daniel Schultz wrote:
>
>> Add fit_addr_r to the environment to allow us to boot from a FIT image.
>>
>> Increase the maximum Image size from 23 MB to 26 MB by moving the
>> initramfs start address up. This gives us a bigger ranger to
>> provide kernel images which are not stripped down too much.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>>   board/phytec/phycore_am62ax/phycore_am62ax.env | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
> What is the minimum memory configuration you have to work with here?
> That's still a very small window unless you're shipping modules with
> 512MiB or so.
>
We currently support SPI boot on devices with a minimum size of 64MB. 
Our kernel image is ~22MB. So, this change will make sure the kernel 
image still fits with future releases.

BTW, Wadim sent patches to enable standard boot for this product. So, 
this patch series fixes some minor issues with the legacy boot flow. We 
just wanna make sure we don't have broken boot flows upstream.

- Daniel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment
  2025-04-29 12:14     ` Daniel Schultz
@ 2025-04-29 14:17       ` Tom Rini
  0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2025-04-29 14:17 UTC (permalink / raw)
  To: Daniel Schultz
  Cc: ggiordano, w.egorov, u-boot, joe.hershberger, bb, nmorrisson,
	upstream

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On Tue, Apr 29, 2025 at 02:14:54PM +0200, Daniel Schultz wrote:
> 
> On 4/28/25 18:10, Tom Rini wrote:
> > On Mon, Apr 28, 2025 at 07:49:04AM -0700, Daniel Schultz wrote:
> > 
> > > Add fit_addr_r to the environment to allow us to boot from a FIT image.
> > > 
> > > Increase the maximum Image size from 23 MB to 26 MB by moving the
> > > initramfs start address up. This gives us a bigger ranger to
> > > provide kernel images which are not stripped down too much.
> > > 
> > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> > > ---
> > >   board/phytec/phycore_am62ax/phycore_am62ax.env | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > What is the minimum memory configuration you have to work with here?
> > That's still a very small window unless you're shipping modules with
> > 512MiB or so.
> > 
> We currently support SPI boot on devices with a minimum size of 64MB. Our
> kernel image is ~22MB. So, this change will make sure the kernel image still
> fits with future releases.
> 
> BTW, Wadim sent patches to enable standard boot for this product. So, this
> patch series fixes some minor issues with the legacy boot flow. We just
> wanna make sure we don't have broken boot flows upstream.

OK thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions
  2025-04-28 14:49 [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Daniel Schultz
  2025-04-28 14:49 ` [PATCH 2/3] include: env: phytec: k3_net: Use get_cmd Daniel Schultz
  2025-04-28 14:49 ` [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment Daniel Schultz
@ 2025-05-07 15:24 ` Tom Rini
  2 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2025-05-07 15:24 UTC (permalink / raw)
  To: ggiordano, w.egorov, u-boot, joe.hershberger, Daniel Schultz
  Cc: bb, nmorrisson, upstream

On Mon, 28 Apr 2025 07:49:02 -0700, Daniel Schultz wrote:

> Extensions are now handled by the board-code. Remove this non-existing
> function to proper boot from network.
> 
> 

Applied to u-boot/master, thanks!

[1/3] include: env: phytec: k3_net: Remove net_apply_extensions
      commit: e75070a8f46f9e154f1ede8132ff3b8c7cfad604
[2/3] include: env: phytec: k3_net: Use get_cmd
      commit: ad2ae4d2b250e25e305ddad9b9337abb4d796137
[3/3] board: phytec: phycore_am62ax: Update Environment
      commit: fd446b0c84478b4673b41a1440cd9116fdd41d92
-- 
Tom



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-05-07 15:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 14:49 [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Daniel Schultz
2025-04-28 14:49 ` [PATCH 2/3] include: env: phytec: k3_net: Use get_cmd Daniel Schultz
2025-04-28 14:49 ` [PATCH 3/3] board: phytec: phycore_am62ax: Update Environment Daniel Schultz
2025-04-28 16:10   ` Tom Rini
2025-04-29 12:14     ` Daniel Schultz
2025-04-29 14:17       ` Tom Rini
2025-05-07 15:24 ` [PATCH 1/3] include: env: phytec: k3_net: Remove net_apply_extensions Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox