From: Lukasz Majewski <lukma@denx.de>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v3 16/22] liebherr: Include env.h to permit reading the environment
Date: Fri, 16 May 2025 07:29:01 +0200 [thread overview]
Message-ID: <20250516072901.5fc2e2f9@wsk> (raw)
In-Reply-To: <20250515234154.1859366-17-trini@konsulko.com>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
On Thu, 15 May 2025 17:31:45 -0600
Tom Rini <trini@konsulko.com> wrote:
> From: Simon Glass <sjg@chromium.org>
>
> This file reads from the environment but does not include the correct
> header. Update it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
> ---
> Changes in v3:
> - None
> ---
> board/liebherr/xea/xea.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c
> index 1d4f165fd13a..9630e7f576b2 100644
> --- a/board/liebherr/xea/xea.c
> +++ b/board/liebherr/xea/xea.c
> @@ -13,6 +13,7 @@
> *
> */
>
> +#include <env.h>
> #include <fdt_support.h>
> #include <init.h>
> #include <log.h>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-16 5:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 22:45 [PATCH 0/5] Start removing <env.h> from headers when not required Tom Rini
2025-05-14 22:46 ` [PATCH 1/5] global: Add <linux/string.h> instead of long indirect include path Tom Rini
2025-05-14 22:46 ` [PATCH 2/5] cmd/mem.c, test/cmd/mem_copy.c: Add <compiler.h> Tom Rini
2025-05-14 22:46 ` [PATCH 3/5] gpio: pca953x: Add missing <asm/byteorder.h> Tom Rini
2025-05-14 22:46 ` [PATCH 4/5] global: Avoid indirect inclusion of <env.h> from <command.h> Tom Rini
2025-05-15 8:01 ` Mattijs Korpershoek
2025-05-15 11:52 ` Jerome Forissier
2025-05-14 22:46 ` [PATCH 5/5] include/command.h: Drop <env.h> Tom Rini
2025-05-15 23:31 ` [PATCH v3 00/22] Remove <env.h> from <net.h> Tom Rini
2025-05-15 23:31 ` [PATCH v3 01/22] net: Remove env_get_ip helper() function Tom Rini
2025-05-15 23:31 ` [PATCH v3 02/22] congatec: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 03/22] dhelectronics: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 04/22] imx8ulp_evk: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 05/22] net: Include string.h in net-legacy.h Tom Rini
2025-05-15 23:31 ` [PATCH v3 06/22] venice: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 07/22] phytec: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 08/22] ronetix: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 09/22] toradex: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 10/22] advantech: Include env.h in imx8qm_dmsse20_a1 Tom Rini
2025-05-15 23:31 ` [PATCH v3 11/22] tegra: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 12/22] synology: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 13/22] amlogic: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 14/22] freescale: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 15/22] google: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 16/22] liebherr: " Tom Rini
2025-05-16 5:29 ` Lukasz Majewski [this message]
2025-05-15 23:31 ` [PATCH v3 17/22] technexion: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 18/22] net: Include byteorder in net6.h Tom Rini
2025-05-15 23:31 ` [PATCH v3 19/22] net: Include env.h in pcap.c Tom Rini
2025-05-15 23:31 ` [PATCH v3 20/22] net: dc2114x: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 21/22] global: Avoid indirect inclusion of <env.h> from <net.h> Tom Rini
2025-05-16 12:48 ` Jerome Forissier
2025-05-16 14:20 ` Martyn Welch
2025-05-19 8:19 ` Wolfgang Wallner
2025-05-19 8:23 ` Ilias Apalodimas
2025-05-15 23:31 ` [PATCH v3 22/22] include/net.h: Drop <env.h> Tom Rini
2025-05-29 17:55 ` [PATCH v3 00/22] Remove <env.h> from <net.h> Tom Rini
2025-05-29 17:55 ` [PATCH 0/5] Start removing <env.h> from headers when not required Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516072901.5fc2e2f9@wsk \
--to=lukma@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox