From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Anatolij Gustschin <agust@denx.de>, Bin Meng <bmeng.cn@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jerome Forissier <jerome.forissier@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Lukasz Majewski <lukma@denx.de>, Marek Vasut <marex@denx.de>,
Mark Kettenis <kettenis@openbsd.org>,
Masahisa Kojima <kojima.masahisa@socionext.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Simon Glass <sjg@chromium.org>,
Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
Stefan Bosch <stefan_b@posteo.net>,
Tien Fong Chee <tien.fong.chee@altera.com>,
Tingting Meng <tingting.meng@altera.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH 4/5] global: Avoid indirect inclusion of <env.h> from <command.h>
Date: Thu, 15 May 2025 10:01:50 +0200 [thread overview]
Message-ID: <87a57e5mkx.fsf@kernel.org> (raw)
In-Reply-To: <20250514225002.15361-5-trini@konsulko.com>
Hi Tom,
Thank you for the patch.
On Wed, May 14, 2025 at 16:46, Tom Rini <trini@konsulko.com> wrote:
> The include file <command.h> does not need anything from <env.h>.
> Furthermore, include/env.h itself includes other headers which can lead
> to longer indirect inclusion paths. To prepare to remove <env.h> from
> <command.h> fix all of the places which had relied on this indirect
> inclusion to instead include <env.h> directly.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org> # android, bcb
> ---
next prev parent reply other threads:[~2025-05-15 8:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 22:45 [PATCH 0/5] Start removing <env.h> from headers when not required Tom Rini
2025-05-14 22:46 ` [PATCH 1/5] global: Add <linux/string.h> instead of long indirect include path Tom Rini
2025-05-14 22:46 ` [PATCH 2/5] cmd/mem.c, test/cmd/mem_copy.c: Add <compiler.h> Tom Rini
2025-05-14 22:46 ` [PATCH 3/5] gpio: pca953x: Add missing <asm/byteorder.h> Tom Rini
2025-05-14 22:46 ` [PATCH 4/5] global: Avoid indirect inclusion of <env.h> from <command.h> Tom Rini
2025-05-15 8:01 ` Mattijs Korpershoek [this message]
2025-05-15 11:52 ` Jerome Forissier
2025-05-14 22:46 ` [PATCH 5/5] include/command.h: Drop <env.h> Tom Rini
2025-05-15 23:31 ` [PATCH v3 00/22] Remove <env.h> from <net.h> Tom Rini
2025-05-15 23:31 ` [PATCH v3 01/22] net: Remove env_get_ip helper() function Tom Rini
2025-05-15 23:31 ` [PATCH v3 02/22] congatec: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 03/22] dhelectronics: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 04/22] imx8ulp_evk: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 05/22] net: Include string.h in net-legacy.h Tom Rini
2025-05-15 23:31 ` [PATCH v3 06/22] venice: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 07/22] phytec: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 08/22] ronetix: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 09/22] toradex: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 10/22] advantech: Include env.h in imx8qm_dmsse20_a1 Tom Rini
2025-05-15 23:31 ` [PATCH v3 11/22] tegra: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 12/22] synology: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 13/22] amlogic: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 14/22] freescale: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 15/22] google: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 16/22] liebherr: " Tom Rini
2025-05-16 5:29 ` Lukasz Majewski
2025-05-15 23:31 ` [PATCH v3 17/22] technexion: " Tom Rini
2025-05-15 23:31 ` [PATCH v3 18/22] net: Include byteorder in net6.h Tom Rini
2025-05-15 23:31 ` [PATCH v3 19/22] net: Include env.h in pcap.c Tom Rini
2025-05-15 23:31 ` [PATCH v3 20/22] net: dc2114x: Include env.h to permit reading the environment Tom Rini
2025-05-15 23:31 ` [PATCH v3 21/22] global: Avoid indirect inclusion of <env.h> from <net.h> Tom Rini
2025-05-16 12:48 ` Jerome Forissier
2025-05-16 14:20 ` Martyn Welch
2025-05-19 8:19 ` Wolfgang Wallner
2025-05-19 8:23 ` Ilias Apalodimas
2025-05-15 23:31 ` [PATCH v3 22/22] include/net.h: Drop <env.h> Tom Rini
2025-05-29 17:55 ` [PATCH v3 00/22] Remove <env.h> from <net.h> Tom Rini
2025-05-29 17:55 ` [PATCH 0/5] Start removing <env.h> from headers when not required Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a57e5mkx.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=agust@denx.de \
--cc=bmeng.cn@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kettenis@openbsd.org \
--cc=kojima.masahisa@socionext.com \
--cc=linus.walleij@linaro.org \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sjg@chromium.org \
--cc=stefan_b@posteo.net \
--cc=tien.fong.chee@altera.com \
--cc=tingting.meng@altera.com \
--cc=tobias@waldekranz.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox