U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/10] sc5xx: Add complete board support for all ADI SC5xx boards
@ 2025-06-02 19:44 Greg Malysa
  2025-06-02 19:44 ` [PATCH 01/10] mach-sc5xx: Introduce Kconfig symbols for image addresses Greg Malysa
                   ` (9 more replies)
  0 siblings, 10 replies; 19+ messages in thread
From: Greg Malysa @ 2025-06-02 19:44 UTC (permalink / raw)
  To: u-boot
  Cc: adsp-linux, Greg Malysa, Arturs Artamonovs, Heinrich Schuchardt,
	Ian Roberts, Igor Opaniuk, Jerome Forissier, Mattijs Korpershoek,
	Nathan Barrett-Morrison, Oliver Gaskell, Patrice Chotard,
	Robert Marko, Sebastian Reichel, Simon Glass, Sumit Garg,
	Tom Rini, Trevor Woerner, Utsav Agarwal, Vasileios Bimpikas

This series adds the final pieces to enable mainline U-Boot to build and
boot all Analog Devices SC5xx SoCs and supports the associated carrier
board options. At this point it should be viable for new users for these
platforms to start with the latest version of U-Boot rather than our
vendor fork, however some features (such as OSPI support and falcon
boot) remain unavailable until we are able to unify our implementations
with the mainline implementations.


Greg Malysa (8):
  docker: add ADI build-related tools to docker image
  board: adi: Add SOMCRR infrastructure
  board: adi: Add support for SC573-ezkit
  board: adi: Add support for SC589 boards
  board: adi: Add support for SC584
  board: adi: Add support for SC598
  board: adi: Add support for SC594
  MAINTAINERS: Update ADI entries for new boards

Utsav Agarwal (2):
  mach-sc5xx: Introduce Kconfig symbols for image addresses
  mach-sc5xx: Add binman support

 MAINTAINERS                                   |   1 +
 arch/arm/dts/sc573-ezkit.dts                  | 227 +++++++++++++++++
 arch/arm/dts/sc57x.dtsi                       | 123 ++++++++-
 arch/arm/dts/sc584-ezkit.dts                  | 230 +++++++++++++++++
 arch/arm/dts/sc589-ezkit.dts                  | 198 +++++++++++++++
 arch/arm/dts/sc589-mini.dts                   |  18 +-
 arch/arm/dts/sc58x.dtsi                       | 153 ++++++++++-
 arch/arm/dts/sc594-som-ezkit.dts              | 126 ++++++++++
 arch/arm/dts/sc594-som-ezlite.dts             |  83 ++++++
 arch/arm/dts/sc594-som.dtsi                   | 184 +++++++++++++-
 arch/arm/dts/sc598-som-ezkit.dts              | 166 ++++++++++++
 arch/arm/dts/sc598-som-ezlite.dts             |  82 ++++++
 arch/arm/dts/sc598-som.dtsi                   | 237 +++++++++++++++++-
 arch/arm/dts/sc59x.dtsi                       | 183 ++++++++++++++
 arch/arm/dts/sc5xx.dtsi                       | 189 +++++++++++++-
 arch/arm/mach-sc5xx/Kconfig                   |  63 +++++
 board/adi/carriers/Makefile                   |   8 +
 board/adi/carriers/somcrr.h                   |  14 ++
 board/adi/carriers/somcrr_common.c            |  19 ++
 board/adi/carriers/somcrr_ezkit.c             |  38 +++
 board/adi/carriers/somcrr_ezlite.c            |  24 ++
 board/adi/common-sc594-som/sc594-som.c        |  34 +++
 board/adi/common-sc598-som/sc598-som.c        |  34 +++
 board/adi/sc573-ezkit/Makefile                |   6 +
 board/adi/sc573-ezkit/sc573-ezkit.c           |  21 ++
 board/adi/sc573-ezkit/sc573-ezkit.env         |  17 +-
 board/adi/sc584-ezkit/Makefile                |   6 +
 board/adi/sc584-ezkit/sc584-ezkit.c           |  21 ++
 board/adi/sc584-ezkit/sc584-ezkit.env         |  16 +-
 board/adi/sc589-ezkit/Makefile                |   6 +
 board/adi/sc589-ezkit/sc589-ezkit.c           |  21 ++
 board/adi/sc589-ezkit/sc589-ezkit.env         |  17 +-
 board/adi/sc589-mini/Makefile                 |   6 +
 board/adi/sc589-mini/sc589-mini.c             |  21 ++
 board/adi/sc589-mini/sc589-mini.env           |  17 +-
 board/adi/sc594-som-ezkit/Makefile            |   8 +
 board/adi/sc594-som-ezkit/sc594-som-ezkit.env |  18 +-
 board/adi/sc594-som-ezlite/Makefile           |   8 +
 .../adi/sc594-som-ezlite/sc594-som-ezlite.env |  18 +-
 board/adi/sc598-som-ezkit/Makefile            |   8 +
 board/adi/sc598-som-ezkit/sc598-som-ezkit.env |  18 +-
 board/adi/sc598-som-ezlite/Makefile           |   8 +
 .../adi/sc598-som-ezlite/sc598-som-ezlite.env |  12 +-
 configs/sc573-ezkit_defconfig                 | 102 ++++++++
 configs/sc584-ezkit_defconfig                 | 108 ++++++++
 configs/sc589-ezkit_defconfig                 | 113 +++++++++
 configs/sc589-mini_defconfig                  | 109 ++++++++
 configs/sc594-som-ezkit-spl_defconfig         |  90 +++++++
 configs/sc594-som-ezlite-spl_defconfig        |  98 ++++++++
 configs/sc598-som-ezkit-spl_defconfig         | 123 +++++++++
 configs/sc598-som-ezlite-spl_defconfig        | 123 +++++++++
 tools/docker/Dockerfile                       |   8 +
 52 files changed, 3508 insertions(+), 73 deletions(-)
 create mode 100644 arch/arm/dts/sc59x.dtsi
 create mode 100644 board/adi/carriers/Makefile
 create mode 100644 board/adi/carriers/somcrr.h
 create mode 100644 board/adi/carriers/somcrr_common.c
 create mode 100644 board/adi/carriers/somcrr_ezkit.c
 create mode 100644 board/adi/carriers/somcrr_ezlite.c
 create mode 100644 board/adi/common-sc594-som/sc594-som.c
 create mode 100644 board/adi/common-sc598-som/sc598-som.c
 create mode 100644 board/adi/sc573-ezkit/Makefile
 create mode 100644 board/adi/sc573-ezkit/sc573-ezkit.c
 create mode 100644 board/adi/sc584-ezkit/Makefile
 create mode 100644 board/adi/sc584-ezkit/sc584-ezkit.c
 create mode 100644 board/adi/sc589-ezkit/Makefile
 create mode 100644 board/adi/sc589-ezkit/sc589-ezkit.c
 create mode 100644 board/adi/sc589-mini/Makefile
 create mode 100644 board/adi/sc589-mini/sc589-mini.c
 create mode 100644 board/adi/sc594-som-ezkit/Makefile
 create mode 100644 board/adi/sc594-som-ezlite/Makefile
 create mode 100644 board/adi/sc598-som-ezkit/Makefile
 create mode 100644 board/adi/sc598-som-ezlite/Makefile
 create mode 100644 configs/sc573-ezkit_defconfig
 create mode 100644 configs/sc584-ezkit_defconfig
 create mode 100644 configs/sc589-ezkit_defconfig
 create mode 100644 configs/sc589-mini_defconfig
 create mode 100644 configs/sc594-som-ezkit-spl_defconfig
 create mode 100644 configs/sc594-som-ezlite-spl_defconfig
 create mode 100644 configs/sc598-som-ezkit-spl_defconfig
 create mode 100644 configs/sc598-som-ezlite-spl_defconfig

-- 
2.45.2

base-commit: 2f3766949bbea7aa5a472157561d387fd94205d2
branch: dev/sc5xx-boards-v1

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH 08/10] board: adi: Add support for SC598
@ 2025-07-04 15:04 Philip Molloy
  0 siblings, 0 replies; 19+ messages in thread
From: Philip Molloy @ 2025-07-04 15:04 UTC (permalink / raw)
  To: Greg Malysa, u-boot
  Cc: adsp-linux, Vasileios Bimpikas, Utsav Agarwal, Arturs Artamonovs,
	Nathan Barrett-Morrison, Ian Roberts, Oliver Gaskell, Tom Rini,
	Trevor Woerner, Philip Molloy

On Mon, 2025-06-02 at 15:44 -0400, Greg Malysa wrote:
> >  &clk {
> >   compatible = "adi,sc598-clocks";
> >   reg = <0x3108d000 0x1000>,
> > -       <0x3108e000 0x1000>,
> > -       <0x3108f000 0x1000>,
> > -       <0x310a9000 0x1000>;
> > + <0x3108e000 0x1000>,
> > + <0x3108f000 0x1000>,
> > + <0x310a9000 0x1000>;

Could it be that everything is indented with 4 space tabs rather than 8?

> > + gpio_expander1: mcp23018@20 {
> > + compatible = "microchip,mcp23018";

It looks like this corresponds to Rev D of the SOM. There is a Rev E of the SOM with a adi,adp5588 like on the ezlite and a 1Gb SPI flash. I imagine Rev D is no longer being manufactured, but I'm waiting to hear back internally at ADI. Changes for Rev E can be made in another series, but it might be nice to add a `Link: <...>` to the schematics in the commit message so it is clear which revision this corresponds to.

> > + uart0 {
> > + gpio-hog;
> > + gpios = <5 GPIO_ACTIVE_HIGH>;

It looks like the PI3C3125 bus switch has active LOW enables. That would explain why `output-low` and GPIO_ACTIVE_HIGH result in a functional UART.

> > + output-low;
> > + line-name = "~uart0-en";

I couldn't find any other examples of ~ being used as a prefix for `line-name` in U-Boot or in the Kernel.

> > + bootph-pre-ram;

Unfortunately, SPL doesn't currently configure the GPIO expander before using the UART so there is no output until U-Boot proper is booted. I did a little JTAG debugging and neither the GPIO expander was probed, nor the ADI I2C driver.

By probing before the bus switch I could see the following getting output:

U-Boot SPL 2025.07-rc4 (Jul 04 2025 - 13:31:08 +0200)
ADI Boot Mode: 0x0 (JTAG/BOOTROM)

Unfortunately, the ADI UART driver does not support DEBUG_UART. I also tried adding devicetree entries for uart2 (which is routed to the carrier board) without luck.

Ideally, this would be documented somewhere, otherwise anyone booting SPL over JTAG may think something is wrong.

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH 08/10] board: adi: Add support for SC598
@ 2025-07-09  9:24 Philip Molloy
  2025-07-09 10:20 ` Artamonovs, Arturs
  0 siblings, 1 reply; 19+ messages in thread
From: Philip Molloy @ 2025-07-09  9:24 UTC (permalink / raw)
  To: Greg Malysa, u-boot
  Cc: adsp-linux, Vasileios Bimpikas, Utsav Agarwal, Arturs Artamonovs,
	Nathan Barrett-Morrison, Ian Roberts, Oliver Gaskell, Tom Rini,
	Trevor Woerner

On Mon, 2025-06-02 at 15:44 -0400, Greg Malysa wrote:
> > This adds support for the Analog Devices SC598-SOM and configurations
> > for using it with both the SOMCRR-EZKIT and SOMCRR-EZLITE.
> >
> > Signed-off-by: Vasileios Bimpikas <vasileios.bimpikas@analog.com>
> > Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>
> > Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>
> > Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
> > Signed-off-by: Greg Malysa <malysagreg@gmail.com>
> > ---
> >
> >  arch/arm/dts/sc598-som-ezkit.dts              | 166 ++++++++++++
> >  arch/arm/dts/sc598-som-ezlite.dts             |  82 ++++++
> >  arch/arm/dts/sc598-som.dtsi                   | 237
> > +++++++++++++++++-
> >  arch/arm/dts/sc59x.dtsi                       | 183 ++++++++++++++
> >  arch/arm/dts/sc5xx.dtsi                       | 137 +++++++++-
> >  board/adi/common-sc598-som/sc598-som.c        |  34 +++
> >  board/adi/sc598-som-ezkit/Makefile            |   8 +
> >  board/adi/sc598-som-ezkit/sc598-som-ezkit.env |  18 +-
> >  board/adi/sc598-som-ezlite/Makefile           |   8 +
> >  .../adi/sc598-som-ezlite/sc598-som-ezlite.env |  12 +-
> >  configs/sc598-som-ezkit-spl_defconfig         | 123 +++++++++
> >  configs/sc598-som-ezlite-spl_defconfig        | 123 +++++++++

I assume `-spl` was added to the defconfig name to distinguish it from the defconfig enabling falcon mode? Seems like it makes sense to remove it for mainline.

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2025-07-11 15:48 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02 19:44 [PATCH 00/10] sc5xx: Add complete board support for all ADI SC5xx boards Greg Malysa
2025-06-02 19:44 ` [PATCH 01/10] mach-sc5xx: Introduce Kconfig symbols for image addresses Greg Malysa
2025-06-02 19:44 ` [PATCH 02/10] mach-sc5xx: Add binman support Greg Malysa
2025-06-02 19:44 ` [PATCH 03/10] docker: add ADI build-related tools to docker image Greg Malysa
2025-06-02 20:11   ` Heinrich Schuchardt
     [not found]     ` <CABdDSeV0D2n223hu+2pAp0x_UksGU=15m09pwY7edgpP5kZ9_w@mail.gmail.com>
2025-06-03  7:06       ` Greg Malysa
2025-06-02 19:44 ` [PATCH 04/10] board: adi: Add SOMCRR infrastructure Greg Malysa
2025-06-02 19:44 ` [PATCH 05/10] board: adi: Add support for SC573-ezkit Greg Malysa
2025-06-02 19:44 ` [PATCH 06/10] board: adi: Add support for SC589 boards Greg Malysa
2025-06-02 19:44 ` [PATCH 07/10] board: adi: Add support for SC584 Greg Malysa
2025-06-02 19:44 ` [PATCH 08/10] board: adi: Add support for SC598 Greg Malysa
2025-06-02 19:44 ` [PATCH 09/10] board: adi: Add support for SC594 Greg Malysa
2025-06-02 19:44 ` [PATCH 10/10] MAINTAINERS: Update ADI entries for new boards Greg Malysa
2025-06-05 17:12   ` Tom Rini
2025-07-09 19:14     ` Greg Malysa
2025-07-11 15:48       ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2025-07-04 15:04 [PATCH 08/10] board: adi: Add support for SC598 Philip Molloy
2025-07-09  9:24 Philip Molloy
2025-07-09 10:20 ` Artamonovs, Arturs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox