From: WeiHao Li <cn.liweihao@gmail.com>
To: u-boot@lists.denx.de
Cc: antonio.borneo@foss.st.com, mk7.kang@samsung.com,
gregkh@linuxfoundation.org, semen.protsenko@linaro.org,
mikhail.kshevetskiy@iopsys.eu, bb@ti.com,
justin.swartz@risingedge.co.za, lukasz.czechowski@thaumatec.com,
robh@kernel.org, tharvey@gateworks.com,
clement.legoffic@foss.st.com, marek.vasut@mailbox.org,
dinesh.maniyam@altera.com, patrice.chotard@foss.st.com,
festevam@gmail.com, jerome.forissier@linaro.org,
quentin.schulz@cherry.de, andrew.goodbody@linaro.org,
sumit.garg@kernel.org, ag.dev.uboot@gmail.com,
rfried.dev@gmail.com, joe.hershberger@ni.com,
jh80.chung@samsung.com, peng.fan@nxp.com, seanga2@gmail.com,
lukma@denx.de, kever.yang@rock-chips.com,
philipp.tomsich@vrull.eu, sjg@chromium.org, trini@konsulko.com,
WeiHao Li <cn.liweihao@gmail.com>,
muratdemirtas <muratdemirtaseu@outlook.com>,
WeiHao Li <ieiao@outlook.com>
Subject: [PATCH 07/10] video: rockchip: vop add bridge support
Date: Thu, 7 Aug 2025 15:44:15 +0800 [thread overview]
Message-ID: <20250807074419.336752-8-cn.liweihao@gmail.com> (raw)
In-Reply-To: <20250807074419.336752-1-cn.liweihao@gmail.com>
Signed-off-by: muratdemirtas <muratdemirtaseu@outlook.com>
Signed-off-by: WeiHao Li <ieiao@outlook.com>
---
drivers/video/rockchip/rk_vop.c | 92 +++++++++++++++++++++++++--------
1 file changed, 71 insertions(+), 21 deletions(-)
diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index 17dfe62c9d..71786da77e 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -14,6 +14,8 @@
#include <reset.h>
#include <syscon.h>
#include <video.h>
+#include <video_bridge.h>
+#include <panel.h>
#include <asm/global_data.h>
#include <asm/gpio.h>
#include <asm/io.h>
@@ -257,6 +259,8 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
ofnode remote;
const char *compat;
struct reset_ctl dclk_rst;
+ struct udevice *bridge;
+ struct udevice *panel;
debug("%s(%s, 0x%lx, %s)\n", __func__,
dev_read_name(dev), fbbase, ofnode_get_name(ep_node));
@@ -298,6 +302,10 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
return -EINVAL;
}
+ uclass_find_device_by_ofnode(UCLASS_VIDEO_BRIDGE, remote, &bridge);
+ if (bridge)
+ break;
+
uclass_find_device_by_ofnode(UCLASS_DISPLAY, remote, &disp);
if (disp)
break;
@@ -326,27 +334,60 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
}
debug("vop_id=%d\n", vop_id);
- disp_uc_plat = dev_get_uclass_plat(disp);
- debug("Found device '%s', disp_uc_priv=%p\n", disp->name, disp_uc_plat);
- if (display_in_use(disp)) {
- debug(" - device in use\n");
- return -EBUSY;
- }
+ if (bridge) {
+ /* video bridge detected, probe it */
+ ret = device_probe(bridge);
+ if (ret) {
+ debug("%s: device '%s' bridge won't probe (ret=%d)\n",
+ __func__, dev->name, ret);
+ return ret;
+ }
- disp_uc_plat->source_id = remote_vop_id;
- disp_uc_plat->src_dev = dev;
+ /* Attach the DSI controller and the display to the bridge. */
+ ret = video_bridge_attach(bridge);
+ if (ret) {
+ debug("Failed to attach video bridge: %d\n", ret);
+ return ret;
+ }
- ret = device_probe(disp);
- if (ret) {
- debug("%s: device '%s' display won't probe (ret=%d)\n",
- __func__, dev->name, ret);
- return ret;
- }
+ /*
+ * Get the panel device
+ * TODO: Maybe fetch it from the bridge private data.
+ */
+ ret = uclass_first_device_err(UCLASS_PANEL, &panel);
+ if (ret) {
+ debug("Panel device error: %d\n", ret);
+ return ret;
+ }
- ret = display_read_timing(disp, &timing);
- if (ret) {
- debug("%s: Failed to read timings\n", __func__);
- return ret;
+ ret = panel_get_display_timing(panel, &timing);
+ if (ret) {
+ debug("%s: Failed to read timings\n", __func__);
+ return ret;
+ }
+ } else {
+ disp_uc_plat = dev_get_uclass_plat(disp);
+ debug("Found device '%s', disp_uc_priv=%p\n", disp->name, disp_uc_plat);
+ if (display_in_use(disp)) {
+ debug(" - device in use\n");
+ return -EBUSY;
+ }
+
+ disp_uc_plat->source_id = remote_vop_id;
+ disp_uc_plat->src_dev = dev;
+
+ ret = device_probe(disp);
+ if (ret) {
+ debug("%s: device '%s' display won't probe (ret=%d)\n",
+ __func__, dev->name, ret);
+ return ret;
+ }
+
+ ret = display_read_timing(disp, &timing);
+ if (ret) {
+ debug("%s: Failed to read timings\n", __func__);
+ return ret;
+ }
}
ret = clk_get_by_index(dev, 1, &clk);
@@ -383,9 +424,18 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
rkvop_enable(dev, fbbase, 1 << l2bpp, &timing, &dclk_rst);
- ret = display_enable(disp, 1 << l2bpp, &timing);
- if (ret)
- return ret;
+ if (bridge) {
+ /* Attach the DSI controller and the display to the bridge. */
+ ret = video_bridge_set_backlight(bridge, 80);
+ if (ret) {
+ printf("Failed to start the video bridge: %d\n", ret);
+ return ret;
+ }
+ } else {
+ ret = display_enable(disp, 1 << l2bpp, &timing);
+ if (ret)
+ return ret;
+ }
uc_priv->xsize = timing.hactive.typ;
uc_priv->ysize = timing.vactive.typ;
--
2.39.5
next prev parent reply other threads:[~2025-08-07 8:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 7:44 [PATCH 00/10] Add RK3368 YMD8_MB board support WeiHao Li
2025-08-07 7:44 ` [PATCH 01/10] clk: rockchip: rk3368: fix gmac clock error WeiHao Li
2025-08-07 7:44 ` [PATCH 02/10] mmc: rockchip: fix clock get wrong index WeiHao Li
2025-08-12 17:49 ` Jonas Karlman
2025-08-13 0:24 ` 李维豪
2025-08-07 7:44 ` [PATCH 03/10] net: rockchip: rk3368: add set_to_rmii WeiHao Li
2025-08-07 7:44 ` [PATCH 04/10] clk: rockchip: rk3368: Add bus clk get/set WeiHao Li
2025-08-07 7:44 ` [PATCH 05/10] clk: rockchip: rk3368: Adjust pll clk get WeiHao Li
2025-08-07 7:44 ` [PATCH 06/10] clk: rockchip: rk3368: Add vop clk get/set WeiHao Li
2025-08-07 7:44 ` WeiHao Li [this message]
2025-08-07 7:44 ` [PATCH 08/10] video: rockchip: add rk3368 vop support WeiHao Li
2025-08-07 7:44 ` [PATCH 09/10] video: panel: add rm72014 panel support WeiHao Li
2025-08-07 7:44 ` [PATCH 10/10] board: rockchip: add rk3368 ymd8_mb support WeiHao Li
2025-08-11 15:01 ` Quentin Schulz
2025-08-12 1:25 ` 李维豪
2025-08-12 8:11 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807074419.336752-8-cn.liweihao@gmail.com \
--to=cn.liweihao@gmail.com \
--cc=ag.dev.uboot@gmail.com \
--cc=andrew.goodbody@linaro.org \
--cc=antonio.borneo@foss.st.com \
--cc=bb@ti.com \
--cc=clement.legoffic@foss.st.com \
--cc=dinesh.maniyam@altera.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ieiao@outlook.com \
--cc=jerome.forissier@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=joe.hershberger@ni.com \
--cc=justin.swartz@risingedge.co.za \
--cc=kever.yang@rock-chips.com \
--cc=lukasz.czechowski@thaumatec.com \
--cc=lukma@denx.de \
--cc=marek.vasut@mailbox.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=mk7.kang@samsung.com \
--cc=muratdemirtaseu@outlook.com \
--cc=patrice.chotard@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=rfried.dev@gmail.com \
--cc=robh@kernel.org \
--cc=seanga2@gmail.com \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox