U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: WeiHao Li <cn.liweihao@gmail.com>
To: u-boot@lists.denx.de
Cc: antonio.borneo@foss.st.com, mk7.kang@samsung.com,
	gregkh@linuxfoundation.org, semen.protsenko@linaro.org,
	mikhail.kshevetskiy@iopsys.eu, bb@ti.com,
	justin.swartz@risingedge.co.za, lukasz.czechowski@thaumatec.com,
	robh@kernel.org, tharvey@gateworks.com,
	clement.legoffic@foss.st.com, marek.vasut@mailbox.org,
	dinesh.maniyam@altera.com, patrice.chotard@foss.st.com,
	festevam@gmail.com, jerome.forissier@linaro.org,
	quentin.schulz@cherry.de, andrew.goodbody@linaro.org,
	sumit.garg@kernel.org, ag.dev.uboot@gmail.com,
	rfried.dev@gmail.com, joe.hershberger@ni.com,
	jh80.chung@samsung.com, peng.fan@nxp.com, seanga2@gmail.com,
	lukma@denx.de, kever.yang@rock-chips.com,
	philipp.tomsich@vrull.eu, sjg@chromium.org, trini@konsulko.com,
	WeiHao Li <cn.liweihao@gmail.com>, WeiHao Li <ieiao@outlook.com>
Subject: [PATCH 08/10] video: rockchip: add rk3368 vop support
Date: Thu,  7 Aug 2025 15:44:16 +0800	[thread overview]
Message-ID: <20250807074419.336752-9-cn.liweihao@gmail.com> (raw)
In-Reply-To: <20250807074419.336752-1-cn.liweihao@gmail.com>

Signed-off-by: WeiHao Li <ieiao@outlook.com>
---
 drivers/video/rockchip/Makefile               |  1 +
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 20 +++++
 drivers/video/rockchip/rk3368_vop.c           | 81 +++++++++++++++++++
 3 files changed, 102 insertions(+)
 create mode 100644 drivers/video/rockchip/rk3368_vop.c

diff --git a/drivers/video/rockchip/Makefile b/drivers/video/rockchip/Makefile
index f55beceebf..83c0b7aef9 100644
--- a/drivers/video/rockchip/Makefile
+++ b/drivers/video/rockchip/Makefile
@@ -7,6 +7,7 @@ ifdef CONFIG_VIDEO_ROCKCHIP
 obj-y += rk_vop.o
 obj-$(CONFIG_ROCKCHIP_RK3288) += rk3288_vop.o
 obj-$(CONFIG_ROCKCHIP_RK3328) += rk3328_vop.o
+obj-$(CONFIG_ROCKCHIP_RK3368) += rk3368_vop.o
 obj-$(CONFIG_ROCKCHIP_RK3399) += rk3399_vop.o
 obj-$(CONFIG_DISPLAY_ROCKCHIP_EDP) += rk_edp.o
 obj-$(CONFIG_DISPLAY_ROCKCHIP_LVDS) += rk_lvds.o
diff --git a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c b/drivers/video/rockchip/dw_mipi_dsi_rockchip.c
index fa51217351..122974d601 100644
--- a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c
+++ b/drivers/video/rockchip/dw_mipi_dsi_rockchip.c
@@ -134,6 +134,11 @@
 #define DW_MIPI_NEEDS_PHY_CFG_CLK	BIT(0)
 #define DW_MIPI_NEEDS_GRF_CLK		BIT(1)
 
+#define RK3368_GRF_SOC_CON7		0x41c
+#define RK3368_DSI_FORCETXSTOPMODE	(0xf << 7)
+#define RK3368_DSI_FORCERXMODE		(0x1 << 6)
+#define RK3368_DSI_TURNDISABLE		(0x1 << 5)
+
 #define RK3399_GRF_SOC_CON20		0x6250
 #define RK3399_DSI0_LCDC_SEL		BIT(0)
 #define RK3399_DSI1_LCDC_SEL		BIT(4)
@@ -911,6 +916,18 @@ struct video_bridge_ops dw_mipi_dsi_rockchip_ops = {
 	.set_backlight = dw_mipi_dsi_rockchip_set_bl,
 };
 
+static const struct rockchip_dw_dsi_chip_data rk3368_chip_data[] = {
+	{
+		.reg = 0xff960000,
+		.lanecfg1_grf_reg = RK3368_GRF_SOC_CON7,
+		.lanecfg1 = HIWORD_UPDATE(0, RK3368_DSI_TURNDISABLE |
+					     RK3368_DSI_FORCETXSTOPMODE |
+					     RK3368_DSI_FORCERXMODE),
+		.max_data_lanes = 4,
+	},
+	{ /* sentinel */ }
+};
+
 static const struct rockchip_dw_dsi_chip_data rk3399_chip_data[] = {
 	{
 		.reg = 0xff960000,
@@ -980,6 +997,9 @@ static const struct rockchip_dw_dsi_chip_data rk3568_chip_data[] = {
 };
 
 static const struct udevice_id dw_mipi_dsi_rockchip_dt_ids[] = {
+	{ .compatible = "rockchip,rk3368-mipi-dsi",
+	  .data = (long)&rk3368_chip_data,
+	},
 	{ .compatible = "rockchip,rk3399-mipi-dsi",
 	  .data = (long)&rk3399_chip_data,
 	},
diff --git a/drivers/video/rockchip/rk3368_vop.c b/drivers/video/rockchip/rk3368_vop.c
new file mode 100644
index 0000000000..46c719c75c
--- /dev/null
+++ b/drivers/video/rockchip/rk3368_vop.c
@@ -0,0 +1,81 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH
+ * Copyright (c) 2015 Google, Inc
+ * Copyright 2014 Rockchip Inc.
+ */
+
+#include <display.h>
+#include <dm.h>
+#include <regmap.h>
+#include <syscon.h>
+#include <video.h>
+#include <asm/global_data.h>
+#include <asm/arch-rockchip/clock.h>
+#include <asm/arch-rockchip/hardware.h>
+#include <linux/delay.h>
+#include "rk_vop.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static void rk3368_set_pin_polarity(struct udevice *dev,
+				    enum vop_modes mode, u32 polarity)
+{
+	struct rk_vop_priv *priv = dev_get_priv(dev);
+	struct rk3288_vop *regs = priv->regs;
+
+	/* The RK3368 VOP (v3.2) has its polarity configuration in ctrl0 */
+	clrsetbits_le32(&regs->dsp_ctrl0,
+			M_DSP_DCLK_POL | M_DSP_DEN_POL |
+			M_DSP_VSYNC_POL | M_DSP_HSYNC_POL,
+			V_DSP_PIN_POL(polarity));
+}
+
+/*
+ * Try some common regulators. We should really get these from the
+ * device tree somehow.
+ */
+static const char * const rk3368_regulator_names[] = {
+	"vcc18_lcd",
+	"VCC18_LCD",
+	"vdd10_lcd_pwren_h",
+	"vdd10_lcd",
+	"VDD10_LCD",
+	"vcc33_lcd"
+};
+
+static int rk3368_vop_probe(struct udevice *dev)
+{
+	/* Before relocation we don't need to do anything */
+	if (!(gd->flags & GD_FLG_RELOC))
+		return 0;
+
+	/* Probe regulators required for the RK3368 VOP */
+	rk_vop_probe_regulators(dev, rk3368_regulator_names,
+				ARRAY_SIZE(rk3368_regulator_names));
+
+	return rk_vop_probe(dev);
+}
+
+struct rkvop_driverdata rk3368_driverdata = {
+	.set_pin_polarity = rk3368_set_pin_polarity,
+};
+
+static const struct udevice_id rk3368_vop_ids[] = {
+	{ .compatible = "rockchip,rk3368-vop",
+	  .data = (ulong)&rk3368_driverdata },
+	{ }
+};
+
+static const struct video_ops rk3368_vop_ops = {
+};
+
+U_BOOT_DRIVER(rockchip_rk3368_vop) = {
+	.name		= "rockchip_rk3368_vop",
+	.id		= UCLASS_VIDEO,
+	.of_match 	= rk3368_vop_ids,
+	.ops		= &rk3368_vop_ops,
+	.bind		= rk_vop_bind,
+	.probe		= rk3368_vop_probe,
+	.priv_auto	= sizeof(struct rk_vop_priv),
+};
-- 
2.39.5


  parent reply	other threads:[~2025-08-07  8:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07  7:44 [PATCH 00/10] Add RK3368 YMD8_MB board support WeiHao Li
2025-08-07  7:44 ` [PATCH 01/10] clk: rockchip: rk3368: fix gmac clock error WeiHao Li
2025-08-07  7:44 ` [PATCH 02/10] mmc: rockchip: fix clock get wrong index WeiHao Li
2025-08-12 17:49   ` Jonas Karlman
2025-08-13  0:24     ` 李维豪
2025-08-07  7:44 ` [PATCH 03/10] net: rockchip: rk3368: add set_to_rmii WeiHao Li
2025-08-07  7:44 ` [PATCH 04/10] clk: rockchip: rk3368: Add bus clk get/set WeiHao Li
2025-08-07  7:44 ` [PATCH 05/10] clk: rockchip: rk3368: Adjust pll clk get WeiHao Li
2025-08-07  7:44 ` [PATCH 06/10] clk: rockchip: rk3368: Add vop clk get/set WeiHao Li
2025-08-07  7:44 ` [PATCH 07/10] video: rockchip: vop add bridge support WeiHao Li
2025-08-07  7:44 ` WeiHao Li [this message]
2025-08-07  7:44 ` [PATCH 09/10] video: panel: add rm72014 panel support WeiHao Li
2025-08-07  7:44 ` [PATCH 10/10] board: rockchip: add rk3368 ymd8_mb support WeiHao Li
2025-08-11 15:01   ` Quentin Schulz
2025-08-12  1:25     ` 李维豪
2025-08-12  8:11       ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250807074419.336752-9-cn.liweihao@gmail.com \
    --to=cn.liweihao@gmail.com \
    --cc=ag.dev.uboot@gmail.com \
    --cc=andrew.goodbody@linaro.org \
    --cc=antonio.borneo@foss.st.com \
    --cc=bb@ti.com \
    --cc=clement.legoffic@foss.st.com \
    --cc=dinesh.maniyam@altera.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ieiao@outlook.com \
    --cc=jerome.forissier@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=joe.hershberger@ni.com \
    --cc=justin.swartz@risingedge.co.za \
    --cc=kever.yang@rock-chips.com \
    --cc=lukasz.czechowski@thaumatec.com \
    --cc=lukma@denx.de \
    --cc=marek.vasut@mailbox.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=mk7.kang@samsung.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=quentin.schulz@cherry.de \
    --cc=rfried.dev@gmail.com \
    --cc=robh@kernel.org \
    --cc=seanga2@gmail.com \
    --cc=semen.protsenko@linaro.org \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@kernel.org \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox