Re: [PATCH 1/2] distro_bootcmd: Add support for customizable find_distro_rootpart

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2212 bytes --]

On Mon, Nov 03, 2025 at 05:16:30PM +0100, Kory Maincent wrote:
> On Mon, 3 Nov 2025 11:52:25 +0100
> Kory Maincent <kory.maincent@bootlin.com> wrote:
> 
> > On Sun, 2 Nov 2025 20:54:02 +0100
> > Simon Glass <sjg@chromium.org> wrote:
> > 
> > > Hi Kory,
> > > 
> > > On Fri, 31 Oct 2025 at 17:36, Kory Maincent (TI.com) <  
> > > kory.maincent@bootlin.com> wrote:
> > > >
> > > > Commit d0ba0ca45a49 ("distro_bootcmd: Set distro_bootpart_uuid for block
> > > > devices") added support for the distro_boot_part_uuid environment variable
> > > > to allow using PARTUUID in the kernel command line.
> > > >
> > > > However, the way it was written only supports the case where the boot    
> > > files  
> > > > and the rootfs are located in the same partition. There are many cases
> > > > where the boot partition and rootfs partition are separate.
> > > >
> > > > Add a customizable find_distro_rootpart command to allow each board to
> > > > define its own logic for locating the rootfs partition. This provides
> > > > flexibility for boards with custom partition layouts while maintaining
> > > > backward compatibility for the default case where boot and rootfs share
> > > > the same partition.
> > > >
> > > > Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
> > > > ---
> > > >  doc/develop/distro.rst          | 11 +++++++++++
> > > >  include/config_distro_bootcmd.h | 10 +++++++---
> > > >  2 files changed, 18 insertions(+), 3 deletions(-)
> > > >    
> > > 
> > > How about moving to standard boot and look at this there?  
> > 
> > Ok, I will take a look at it.
> 
> There is a custom nand boot target [1], and I have not any am335x board with
> nand memory to test it. I am afraid to break it during the update to bootstd.
> Not sure we can accept that. What do you think?
> 
> [1]https://elixir.bootlin.com/u-boot/v2025.10/source/include/configs/am335x_evm.h#L27

I think we can risk it. I'd even be OK with not migrating that portion
and letting anyone still using those platforms, with NAND only, to just
use a custom boot command instead as I have strong doubts there's anyone
doing anything other than that currently.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]