public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"Bajjuri, Praneeth" <praneeth@ti.com>,
	Marek Vasut <marex@denx.de>
Subject: Re: [PATCH 1/2] distro_bootcmd: Add support for customizable find_distro_rootpart
Date: Fri, 7 Nov 2025 09:51:54 -0600	[thread overview]
Message-ID: <20251107155154.GD6688@bill-the-cat> (raw)
In-Reply-To: <20251107100517.6c79a976@kmaincent-XPS-13-7390>

[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]

On Fri, Nov 07, 2025 at 10:05:17AM +0100, Kory Maincent wrote:
> On Thu, 6 Nov 2025 12:23:29 -0600
> Tom Rini <trini@konsulko.com> wrote:
> 
> > On Thu, Nov 06, 2025 at 07:00:01PM +0100, Kory Maincent wrote:
> > > On Tue, 4 Nov 2025 10:38:16 -0600
> > > Tom Rini <trini@konsulko.com> wrote:
> > > 
> > > Other question: Is it possible to not add the environment to SPL image using
> > > the new text environment format. I have tried to update am335_evm board to
> > > it but I got a SPL too big error.
> > > I have tried to add "#if !defined(XPL_BUILD)" but it is not working.
> > > It seems the same generated environment file is used for all images.
> > > I still haven't found were it is included in the build of the SPL image.   
> > 
> > It shouldn't change the environment size, but also environment is likely
> > being pulled in to SPL for network boot support which does require
> > environment. What do you mean by "same generated environment file is
> > used for all images" ? And are you building in separate object
> > directories for a given board or is it not being re-generated on config
> > changes? Or did I misunderstand? Thanks.
> 
> Sorry if I was not clear.
> For the am335x_evm most of the environment is only in the main u-boot image
> (i.e. not an xPL image).
> https://elixir.bootlin.com/u-boot/v2025.10/source/include/configs/am335x_evm.h#L78
> 
> I would like to do the same but with the new text environment format. Is it
> possible? Something like: board/ti/am335x/am335x.env for main image
> and board/ti/am335x/spl_am335x.env for SPL image.
> If that is not the case could you point me where the change need to
> happen to help me on that. I didn't find yet where the text environment is
> pulled into the images.

Ah. It sounds like we need to add missing logic to generate the text
environment in each phase rather than once and use it in all phases?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2025-11-07 15:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 16:36 [PATCH 0/2] Add support for customizable find_distro_rootpart Kory Maincent (TI.com)
2025-10-31 16:36 ` [PATCH 1/2] distro_bootcmd: " Kory Maincent (TI.com)
2025-11-02 19:54   ` Simon Glass
2025-11-03 10:52     ` Kory Maincent
2025-11-03 16:16       ` Kory Maincent
2025-11-03 16:19         ` Tom Rini
2025-11-04  9:29           ` Kory Maincent
2025-11-04 16:38             ` Tom Rini
2025-11-06 18:00               ` Kory Maincent
2025-11-06 18:23                 ` Tom Rini
2025-11-07  9:05                   ` Kory Maincent
2025-11-07  9:58                     ` Simon Glass
2025-11-07 15:51                     ` Tom Rini [this message]
2025-11-11 12:38                       ` Simon Glass
2025-10-31 16:36 ` [PATCH 2/2] include: configs: am335x_evm: Replace findduid with find_distro_rootpart Kory Maincent (TI.com)
2025-10-31 17:47 ` [PATCH 0/2] Add support for customizable find_distro_rootpart Tom Rini
2025-10-31 18:11   ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251107155154.GD6688@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=kory.maincent@bootlin.com \
    --cc=marex@denx.de \
    --cc=praneeth@ti.com \
    --cc=sjg@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox