u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] Dockerfile: Include python3-tk for FATtools
Date: Thu, 13 Nov 2025 16:08:28 -0600	[thread overview]
Message-ID: <20251113220828.GS6688@bill-the-cat> (raw)
In-Reply-To: <eddacbad-b443-4597-ac18-fd9265b9ef2d@mailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Thu, Nov 13, 2025 at 10:37:17PM +0100, Marek Vasut wrote:
> On 11/13/25 9:57 PM, Tom Rini wrote:
> > In some cases our tests for exFAT don't run because we fail to be able
> > to create the underlying image. This is in turn because while creation
> > of the image succeeds, it seems that some way of how we invoke FATtools
> > wants to import tkinter, that fails and so the test stops there. Having
> > tkinter available (and then presumably a fallback to non-GUI because
> > it's not available) leads to the tests running as expected.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Cc: Marek Vasut <marek.vasut@mailbox.org>
> > ---
> >   tools/docker/Dockerfile | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> > index d2384219c06a..f62513b86b2c 100644
> > --- a/tools/docker/Dockerfile
> > +++ b/tools/docker/Dockerfile
> > @@ -127,6 +127,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
> >   	python3-pyelftools \
> >   	python3-sphinx \
> >   	python3-tomli \
> > +	python3-tk \
> Keep the list sorted please.

Ah whoops, k does come before o.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2025-11-13 22:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 20:57 [PATCH] Dockerfile: Include python3-tk for FATtools Tom Rini
2025-11-13 21:37 ` Marek Vasut
2025-11-13 22:08   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251113220828.GS6688@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=marek.vasut@mailbox.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).