[PATCH] Dockerfile: Include python3-tk for FATtools

[PATCH] Dockerfile: Include python3-tk for FATtools

[Tom Rini]

In some cases our tests for exFAT don't run because we fail to be able
to create the underlying image. This is in turn because while creation
of the image succeeds, it seems that some way of how we invoke FATtools
wants to import tkinter, that fails and so the test stops there. Having
tkinter available (and then presumably a fallback to non-GUI because
it's not available) leads to the tests running as expected.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Marek Vasut <marek.vasut@mailbox.org>
---
 tools/docker/Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index d2384219c06a..f62513b86b2c 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -127,6 +127,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
 	python3-pyelftools \
 	python3-sphinx \
 	python3-tomli \
+	python3-tk \
 	python3-venv \
 	rpm2cpio \
 	sbsigntool \
-- 
2.43.0

Re: [PATCH] Dockerfile: Include python3-tk for FATtools

[Marek Vasut]

On 11/13/25 9:57 PM, Tom Rini wrote:
> In some cases our tests for exFAT don't run because we fail to be able
> to create the underlying image. This is in turn because while creation
> of the image succeeds, it seems that some way of how we invoke FATtools
> wants to import tkinter, that fails and so the test stops there. Having
> tkinter available (and then presumably a fallback to non-GUI because
> it's not available) leads to the tests running as expected.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Marek Vasut <marek.vasut@mailbox.org>
> ---
>   tools/docker/Dockerfile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index d2384219c06a..f62513b86b2c 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -127,6 +127,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
>   	python3-pyelftools \
>   	python3-sphinx \
>   	python3-tomli \
> +	python3-tk \
Keep the list sorted please.

Re: [PATCH] Dockerfile: Include python3-tk for FATtools

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Thu, Nov 13, 2025 at 10:37:17PM +0100, Marek Vasut wrote:
> On 11/13/25 9:57 PM, Tom Rini wrote:
> > In some cases our tests for exFAT don't run because we fail to be able
> > to create the underlying image. This is in turn because while creation
> > of the image succeeds, it seems that some way of how we invoke FATtools
> > wants to import tkinter, that fails and so the test stops there. Having
> > tkinter available (and then presumably a fallback to non-GUI because
> > it's not available) leads to the tests running as expected.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Cc: Marek Vasut <marek.vasut@mailbox.org>
> > ---
> >   tools/docker/Dockerfile | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> > index d2384219c06a..f62513b86b2c 100644
> > --- a/tools/docker/Dockerfile
> > +++ b/tools/docker/Dockerfile
> > @@ -127,6 +127,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
> >   	python3-pyelftools \
> >   	python3-sphinx \
> >   	python3-tomli \
> > +	python3-tk \
> Keep the list sorted please.

Ah whoops, k does come before o.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]