U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mccmon6: Stop disabling device tree relocation
@ 2025-11-18 18:04 Tom Rini
  2025-11-19  9:41 ` Łukasz Majewski
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2025-11-18 18:04 UTC (permalink / raw)
  To: u-boot; +Cc: Lukasz Majewski

Remove setting of fdt_high to ~0, which disables device tree relocation,
from the default environment. Doing so prevents U-Boot from correcting
problems such as having an unaligned device tree and leads to various
failure modes in the OS.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
If there is some window of memory that must be used for where the device
tree is relocated to, bootm_low + bootm_size (or often just bootm_size)
or bootm_mapsize are the correct way do this. Please see
doc/usage/environment.rst for more details.

Cc: Lukasz Majewski <lukma@nabladev.com>

---
 include/configs/mccmon6.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/mccmon6.h b/include/configs/mccmon6.h
index b64bf93bcb74..9f401718bfb4 100644
--- a/include/configs/mccmon6.h
+++ b/include/configs/mccmon6.h
@@ -35,7 +35,6 @@
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200 quiet\0" \
-	"fdt_high=0xffffffff\0" \
 	"initrd_high=0xffffffff\0" \
 	"boot_os=yes\0" \
 	"kernelsize=0x300000\0" \
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mccmon6: Stop disabling device tree relocation
  2025-11-18 18:04 [PATCH] mccmon6: Stop disabling device tree relocation Tom Rini
@ 2025-11-19  9:41 ` Łukasz Majewski
  0 siblings, 0 replies; 2+ messages in thread
From: Łukasz Majewski @ 2025-11-19  9:41 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot

On Tue, 18 Nov 2025 12:04:04 -0600
Tom Rini <trini@konsulko.com> wrote:

> Remove setting of fdt_high to ~0, which disables device tree
> relocation, from the default environment. Doing so prevents U-Boot
> from correcting problems such as having an unaligned device tree and
> leads to various failure modes in the OS.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> If there is some window of memory that must be used for where the
> device tree is relocated to, bootm_low + bootm_size (or often just
> bootm_size) or bootm_mapsize are the correct way do this. Please see
> doc/usage/environment.rst for more details.
> 
> Cc: Lukasz Majewski <lukma@nabladev.com>
> 
> ---
>  include/configs/mccmon6.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/mccmon6.h b/include/configs/mccmon6.h
> index b64bf93bcb74..9f401718bfb4 100644
> --- a/include/configs/mccmon6.h
> +++ b/include/configs/mccmon6.h
> @@ -35,7 +35,6 @@
>  
>  #define CFG_EXTRA_ENV_SETTINGS \
>  	"console=ttymxc0,115200 quiet\0" \
> -	"fdt_high=0xffffffff\0" \
>  	"initrd_high=0xffffffff\0" \
>  	"boot_os=yes\0" \
>  	"kernelsize=0x300000\0" \

Reviewed-by: Łukasz Majewski <lukma@nabladev.com>

-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-19  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 18:04 [PATCH] mccmon6: Stop disabling device tree relocation Tom Rini
2025-11-19  9:41 ` Łukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox