U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] configs: toradex-smarc-imx95: set spl_stack
@ 2025-11-26 13:41 max.oss.09
  2025-11-26 14:03 ` Francesco Dolcini
  2025-11-27 18:41 ` Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: max.oss.09 @ 2025-11-26 13:41 UTC (permalink / raw)
  To: u-boot
  Cc: Max Krummenacher, Alice Guo, Emanuele Ghidoli, Ernest Van Hoecke,
	Francesco Dolcini, João Paulo Gonçalves, Marek Vasut,
	Peng Fan, Tom Rini, Ye Li

From: Max Krummenacher <max.krummenacher@toradex.com>

The SPL_STACK config option now depends on having SPL_HAVE_INIT_STACK
defined. This made savedefconfig dropping SPL_STACK when sending the
initial configuration.
Note that SPL/U-Boot are able to boot linux from mass storage with
SPL_STACK not set but other use cases might run out of stack or
overlap with other RAM use.

Compare with:
commit d6a53f523afe ("spl: Add an SPL_HAVE_INIT_STACK option")
commit 25fefa05d732 ("configs: Resync with savedefconfig")

Fixes: ff0540fcfe49 ("board: toradex: add Toradex SMARC iMX95")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---

 configs/toradex-smarc-imx95_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/toradex-smarc-imx95_defconfig b/configs/toradex-smarc-imx95_defconfig
index c5cea6e4e5f5..5ab420ae519e 100644
--- a/configs/toradex-smarc-imx95_defconfig
+++ b/configs/toradex-smarc-imx95_defconfig
@@ -17,6 +17,7 @@ CONFIG_SYS_MONITOR_LEN=524288
 CONFIG_SPL_MMC=y
 CONFIG_SPL_SERIAL=y
 CONFIG_SPL_DRIVERS_MISC=y
+CONFIG_SPL_STACK=0x204d6000
 CONFIG_SPL_TEXT_BASE=0x20480000
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x204d6000
@@ -49,6 +50,7 @@ CONFIG_SPL_BOARD_INIT=y
 CONFIG_SPL_LOAD_IMX_CONTAINER=y
 CONFIG_IMX_CONTAINER_CFG="arch/arm/mach-imx/imx9/scmi/container.cfg"
 # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
+CONFIG_SPL_HAVE_INIT_STACK=y
 CONFIG_SPL_SYS_MALLOC=y
 CONFIG_SPL_HAS_CUSTOM_MALLOC_START=y
 CONFIG_SPL_CUSTOM_SYS_MALLOC_ADDR=0x93200000
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: toradex-smarc-imx95: set spl_stack
  2025-11-26 13:41 [PATCH] configs: toradex-smarc-imx95: set spl_stack max.oss.09
@ 2025-11-26 14:03 ` Francesco Dolcini
  2025-11-27 17:25   ` Fabio Estevam
  2025-11-27 18:41 ` Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Francesco Dolcini @ 2025-11-26 14:03 UTC (permalink / raw)
  To: max.oss.09
  Cc: u-boot, Max Krummenacher, Alice Guo, Emanuele Ghidoli,
	Ernest Van Hoecke, Francesco Dolcini,
	João Paulo Gonçalves, Marek Vasut, Peng Fan, Tom Rini,
	Ye Li

On Wed, Nov 26, 2025 at 02:41:04PM +0100, max.oss.09@gmail.com wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> The SPL_STACK config option now depends on having SPL_HAVE_INIT_STACK
> defined. This made savedefconfig dropping SPL_STACK when sending the
> initial configuration.
> Note that SPL/U-Boot are able to boot linux from mass storage with
> SPL_STACK not set but other use cases might run out of stack or
> overlap with other RAM use.
> 
> Compare with:
> commit d6a53f523afe ("spl: Add an SPL_HAVE_INIT_STACK option")
> commit 25fefa05d732 ("configs: Resync with savedefconfig")
> 
> Fixes: ff0540fcfe49 ("board: toradex: add Toradex SMARC iMX95")
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: toradex-smarc-imx95: set spl_stack
  2025-11-26 14:03 ` Francesco Dolcini
@ 2025-11-27 17:25   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-11-27 17:25 UTC (permalink / raw)
  To: Francesco Dolcini, Tom Rini
  Cc: max.oss.09, u-boot, Max Krummenacher, Alice Guo, Emanuele Ghidoli,
	Ernest Van Hoecke, Francesco Dolcini,
	João Paulo Gonçalves, Marek Vasut, Peng Fan, Ye Li

Hi Tom,

On Wed, Nov 26, 2025 at 11:03 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> On Wed, Nov 26, 2025 at 02:41:04PM +0100, max.oss.09@gmail.com wrote:
> > From: Max Krummenacher <max.krummenacher@toradex.com>
> >
> > The SPL_STACK config option now depends on having SPL_HAVE_INIT_STACK
> > defined. This made savedefconfig dropping SPL_STACK when sending the
> > initial configuration.
> > Note that SPL/U-Boot are able to boot linux from mass storage with
> > SPL_STACK not set but other use cases might run out of stack or
> > overlap with other RAM use.
> >
> > Compare with:
> > commit d6a53f523afe ("spl: Add an SPL_HAVE_INIT_STACK option")
> > commit 25fefa05d732 ("configs: Resync with savedefconfig")
> >
> > Fixes: ff0540fcfe49 ("board: toradex: add Toradex SMARC iMX95")
> > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Feel free to pick up this one directly to master.

Currently, I don't have any outstanding patches for master in my queue.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: toradex-smarc-imx95: set spl_stack
  2025-11-26 13:41 [PATCH] configs: toradex-smarc-imx95: set spl_stack max.oss.09
  2025-11-26 14:03 ` Francesco Dolcini
@ 2025-11-27 18:41 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2025-11-27 18:41 UTC (permalink / raw)
  To: u-boot, max.oss.09
  Cc: Max Krummenacher, Alice Guo, Emanuele Ghidoli, Ernest Van Hoecke,
	Francesco Dolcini, João Paulo Gonçalves, Marek Vasut,
	Peng Fan, Ye Li

On Wed, 26 Nov 2025 14:41:04 +0100, max.oss.09@gmail.com wrote:

> The SPL_STACK config option now depends on having SPL_HAVE_INIT_STACK
> defined. This made savedefconfig dropping SPL_STACK when sending the
> initial configuration.
> Note that SPL/U-Boot are able to boot linux from mass storage with
> SPL_STACK not set but other use cases might run out of stack or
> overlap with other RAM use.
> 
> [...]

Applied to u-boot/master, thanks!

[1/1] configs: toradex-smarc-imx95: set spl_stack
      commit: 610a3eb27ea1e68363fffcb3f14b7fc097ef08b6
-- 
Tom



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-27 18:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 13:41 [PATCH] configs: toradex-smarc-imx95: set spl_stack max.oss.09
2025-11-26 14:03 ` Francesco Dolcini
2025-11-27 17:25   ` Fabio Estevam
2025-11-27 18:41 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox