U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Malysa <malysagreg@gmail.com>
To: u-boot@lists.denx.de
Cc: Greg Malysa <malysagreg@gmail.com>,
	Arturs Artamonovs <arturs.artamonovs@analog.com>,
	Ian Roberts <ian.roberts@timesys.com>,
	Joe Hershberger <joe.hershberger@ni.com>,
	Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
	Tom Rini <trini@konsulko.com>,
	Utsav Agarwal <utsav.agarwal@analog.com>,
	Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
	adsp-linux@analog.com
Subject: [PATCH] board: adi: Fix missing semicolon in nfsroot
Date: Wed, 26 Nov 2025 14:50:31 -0500	[thread overview]
Message-ID: <20251126195047.866-1-malysagreg@gmail.com> (raw)

The nfsroot constructed as part of the default Analog Devices boot
strategy is missing a semicolon between the server ip and the root path
itself. This adds the missing semicolon.

Signed-off-by: Greg Malysa <malysagreg@gmail.com>

---

 include/env/adi/adi_boot.env | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
index d56b14f5172..7f0dfe15ff9 100644
--- a/include/env/adi/adi_boot.env
+++ b/include/env/adi/adi_boot.env
@@ -41,7 +41,7 @@ addip=setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmas
 /* Boot modes are selectable and should be defined in the board env before including */
 #if defined(USE_NFS)
 // rootpath is set by CONFIG_ROOTPATH
-nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}${rootpath},tcp,nfsvers=3 ${adi_bootargs}
+nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${rootpath},tcp,nfsvers=3 ${adi_bootargs}
 nfsboot=run init_ethernet;
 	tftp ${loadaddr} ${tftp_dir_prefix}${imagefile};
 	run nfsargs;
-- 
2.49.1

base-commit: caa740df9cae5ddc74b18b88a4fea43e27b2fdf6
branch: uboot-master

             reply	other threads:[~2025-11-26 19:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 19:50 Greg Malysa [this message]
2025-11-27 16:55 ` [PATCH] board: adi: Fix missing semicolon in nfsroot Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126195047.866-1-malysagreg@gmail.com \
    --to=malysagreg@gmail.com \
    --cc=adsp-linux@analog.com \
    --cc=arturs.artamonovs@analog.com \
    --cc=ian.roberts@timesys.com \
    --cc=joe.hershberger@ni.com \
    --cc=nathan.morrison@timesys.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=utsav.agarwal@analog.com \
    --cc=vasileios.bimpikas@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox