* [PATCH] board: adi: Fix missing semicolon in nfsroot
@ 2025-11-26 19:50 Greg Malysa
2025-11-27 16:55 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Greg Malysa @ 2025-11-26 19:50 UTC (permalink / raw)
To: u-boot
Cc: Greg Malysa, Arturs Artamonovs, Ian Roberts, Joe Hershberger,
Nathan Barrett-Morrison, Tom Rini, Utsav Agarwal,
Vasileios Bimpikas, adsp-linux
The nfsroot constructed as part of the default Analog Devices boot
strategy is missing a semicolon between the server ip and the root path
itself. This adds the missing semicolon.
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
---
include/env/adi/adi_boot.env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
index d56b14f5172..7f0dfe15ff9 100644
--- a/include/env/adi/adi_boot.env
+++ b/include/env/adi/adi_boot.env
@@ -41,7 +41,7 @@ addip=setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmas
/* Boot modes are selectable and should be defined in the board env before including */
#if defined(USE_NFS)
// rootpath is set by CONFIG_ROOTPATH
-nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}${rootpath},tcp,nfsvers=3 ${adi_bootargs}
+nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${rootpath},tcp,nfsvers=3 ${adi_bootargs}
nfsboot=run init_ethernet;
tftp ${loadaddr} ${tftp_dir_prefix}${imagefile};
run nfsargs;
--
2.49.1
base-commit: caa740df9cae5ddc74b18b88a4fea43e27b2fdf6
branch: uboot-master
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] board: adi: Fix missing semicolon in nfsroot
2025-11-26 19:50 [PATCH] board: adi: Fix missing semicolon in nfsroot Greg Malysa
@ 2025-11-27 16:55 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2025-11-27 16:55 UTC (permalink / raw)
To: u-boot, Greg Malysa
Cc: Arturs Artamonovs, Ian Roberts, Joe Hershberger,
Nathan Barrett-Morrison, Utsav Agarwal, Vasileios Bimpikas,
adsp-linux
On Wed, 26 Nov 2025 14:50:31 -0500, Greg Malysa wrote:
> The nfsroot constructed as part of the default Analog Devices boot
> strategy is missing a semicolon between the server ip and the root path
> itself. This adds the missing semicolon.
>
>
Applied to u-boot/master, thanks!
[1/1] board: adi: Fix missing semicolon in nfsroot
commit: 70ab39e2305f6ab9b7b1752e26b0e4293129009b
--
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-27 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 19:50 [PATCH] board: adi: Fix missing semicolon in nfsroot Greg Malysa
2025-11-27 16:55 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox