* [PATCH 1/1] video: correct label for cyclic video_idle
@ 2025-12-31 15:37 Heinrich Schuchardt
2025-12-31 16:08 ` Tom Rini
2025-12-31 19:30 ` Simon Glass
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2025-12-31 15:37 UTC (permalink / raw)
To: Anatolij Gustschin
Cc: Simon Glass, Alexander Graf, Alper Nebi Yasak, Andre Przywara,
u-boot, Heinrich Schuchardt
When the cyclic function video_idle() takes too long a message like the
following is displaced:
cyclic function video_init took too long: 87707us vs 5000us max
The text "video_init" is misleading. Replace it by "video_idle".
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
drivers/video/video-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index 53641fc28b6..228d6bacc58 100644
--- a/drivers/video/video-uclass.c
+++ b/drivers/video/video-uclass.c
@@ -734,7 +734,7 @@ static int video_post_probe(struct udevice *dev)
uint ms = CONFIG_IF_ENABLED_INT(CYCLIC, VIDEO_SYNC_CYCLIC_MS);
cyclic_register(&uc_priv->cyc, video_idle, ms * 1000,
- "video_init");
+ "video_idle");
uc_priv->cyc_active = true;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] video: correct label for cyclic video_idle
2025-12-31 15:37 [PATCH 1/1] video: correct label for cyclic video_idle Heinrich Schuchardt
@ 2025-12-31 16:08 ` Tom Rini
2025-12-31 19:30 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2025-12-31 16:08 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Anatolij Gustschin, Simon Glass, Alexander Graf, Alper Nebi Yasak,
Andre Przywara, u-boot
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
On Wed, Dec 31, 2025 at 04:37:19PM +0100, Heinrich Schuchardt wrote:
> When the cyclic function video_idle() takes too long a message like the
> following is displaced:
>
> cyclic function video_init took too long: 87707us vs 5000us max
>
> The text "video_init" is misleading. Replace it by "video_idle".
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] video: correct label for cyclic video_idle
2025-12-31 15:37 [PATCH 1/1] video: correct label for cyclic video_idle Heinrich Schuchardt
2025-12-31 16:08 ` Tom Rini
@ 2025-12-31 19:30 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2025-12-31 19:30 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Anatolij Gustschin, Alexander Graf, Alper Nebi Yasak,
Andre Przywara, u-boot
On Wed, 31 Dec 2025 at 08:37, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> When the cyclic function video_idle() takes too long a message like the
> following is displaced:
>
> cyclic function video_init took too long: 87707us vs 5000us max
>
> The text "video_init" is misleading. Replace it by "video_idle".
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> drivers/video/video-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <simon.glass@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-31 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-31 15:37 [PATCH 1/1] video: correct label for cyclic video_idle Heinrich Schuchardt
2025-12-31 16:08 ` Tom Rini
2025-12-31 19:30 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox