* [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
@ 2026-01-20 4:34 Anshul Dalal
2026-01-20 14:54 ` Tom Rini
2026-01-28 14:02 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Anshul Dalal @ 2026-01-20 4:34 UTC (permalink / raw)
To: u-boot
Cc: Tom Rini, Andrew Davis, Judith Mendez, Udit Kumar,
Hrushikesh Salunke, Neha Malcom Francis, Vignesh R,
Christoph Niedermaier, Anshul Dalal
Since the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
with an extra Kconfig"), SPL_USE_TINY_PRINTF_POINTER_SUPPORT has been
made mandatory in order to use %p which would earlier have defaulted to
a 'long' print.
Without this config symbol, k3_sysfw_dfu_download fails to set the
correct value for the DFU string with:
sprintf(dfu_str, "sysfw.itb ram 0x%p 0x%x", addr,
CONFIG_K3_SYSFW_IMAGE_SIZE_MAX);
The value we get "sysfw.itb ram 0x? 0x41c29d40" causes a boot failure.
Therefore this patch sets SPL_USE_TINY_PRINTF_POINTER_SUPPORT for all K3
devices since the size impact is less than 100 bytes.
Signed-off-by: Anshul Dalal <anshuld@ti.com>
---
Changes in v4:
- Enable pointer support for only DFU configs on ARMv7 cores
- Link to v3: https://lore.kernel.org/r/20251204-am65_dfu_fix-v3-1-de18ed3f346d@ti.com
Changes in v3:
- Handle setting the config in Kconfig instead of the defconfig
- Link to v2: https://lore.kernel.org/r/20251105-am65_dfu_fix-v2-1-ccada89d966d@ti.com
Changes in v2:
- Remove unrelated changes
- Link to v1: https://lore.kernel.org/r/20251105-am65_dfu_fix-v1-1-acc29111dccf@ti.com
---
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0485fe78e10..2df28d71d75 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -836,6 +836,7 @@ config ARCH_K3
select DMA_ADDR_T_64BIT
select LTO
select SPL_LOAD_FIT if SPL
+ select SPL_USE_TINY_PRINTF_POINTER_SUPPORT if SPL_USE_TINY_PRINTF && DFU && CPU_V7R
imply TI_SECURE_DEVICE
imply DM_RNG if ARM64
imply TEE if ARM64
---
base-commit: cde150b5e15f291618c120e047fd85393123c091
change-id: 20251105-am65_dfu_fix-1144eec06b19
Best regards,
--
Anshul Dalal <anshuld@ti.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
2026-01-20 4:34 [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3 Anshul Dalal
@ 2026-01-20 14:54 ` Tom Rini
2026-01-28 14:02 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2026-01-20 14:54 UTC (permalink / raw)
To: Anshul Dalal
Cc: u-boot, Andrew Davis, Judith Mendez, Udit Kumar,
Hrushikesh Salunke, Neha Malcom Francis, Vignesh R,
Christoph Niedermaier
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Tue, Jan 20, 2026 at 10:04:28AM +0530, Anshul Dalal wrote:
> Since the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
> with an extra Kconfig"), SPL_USE_TINY_PRINTF_POINTER_SUPPORT has been
> made mandatory in order to use %p which would earlier have defaulted to
> a 'long' print.
>
> Without this config symbol, k3_sysfw_dfu_download fails to set the
> correct value for the DFU string with:
>
> sprintf(dfu_str, "sysfw.itb ram 0x%p 0x%x", addr,
> CONFIG_K3_SYSFW_IMAGE_SIZE_MAX);
>
> The value we get "sysfw.itb ram 0x? 0x41c29d40" causes a boot failure.
>
> Therefore this patch sets SPL_USE_TINY_PRINTF_POINTER_SUPPORT for all K3
> devices since the size impact is less than 100 bytes.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
2026-01-20 4:34 [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3 Anshul Dalal
2026-01-20 14:54 ` Tom Rini
@ 2026-01-28 14:02 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2026-01-28 14:02 UTC (permalink / raw)
To: u-boot, Anshul Dalal
Cc: Andrew Davis, Judith Mendez, Udit Kumar, Hrushikesh Salunke,
Neha Malcom Francis, Vignesh R, Christoph Niedermaier
On Tue, 20 Jan 2026 10:04:28 +0530, Anshul Dalal wrote:
> Since the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
> with an extra Kconfig"), SPL_USE_TINY_PRINTF_POINTER_SUPPORT has been
> made mandatory in order to use %p which would earlier have defaulted to
> a 'long' print.
>
> Without this config symbol, k3_sysfw_dfu_download fails to set the
> correct value for the DFU string with:
>
> [...]
Applied to u-boot/master, thanks!
[1/1] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
commit: cfce859b16ffc43c6eb0afb6c49c95e1ec25f5f1
--
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20 4:34 [PATCH master v4] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3 Anshul Dalal
2026-01-20 14:54 ` Tom Rini
2026-01-28 14:02 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox