Re: [PATCH v3 1/6] clk: mediatek: mt8189: add some VLP clocks

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Mon, Mar 23, 2026 at 02:23:58PM -0600, Tom Rini wrote:
> On Mon, Mar 23, 2026 at 03:16:52PM -0500, David Lechner wrote:
> 
> > Add some VLP clocks needed by the PMIC on MT8189 and similar SoCs.
> > 
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> >  drivers/clk/mediatek/clk-mt8189.c | 289 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 289 insertions(+)
> 
> I'm working on a series now to fix this globally, and it's not a
> MediaTek only problem, but:
> 
> > @@ -1733,6 +2012,16 @@ U_BOOT_DRIVER(mtk_clk_topckgen) = {
> >  	.flags = DM_FLAG_PRE_RELOC,
> >  };
> >  
> > +U_BOOT_DRIVER(mtk_clk_vlpckgen) = {
> 
> This is a bad name to use. I bet in other parts of the series you re-use
> it. These names need to be unique within a binary, and while today they
> will be I bet (since all the other examples are fine), someday we'd like
> to be able to compile test (and so static analyize) more code, and it
> will clash and fail to link. A better one would be
> "mt8189_clk_vlpckgen".

Ugh, and I just hit the build problem where I see these re-used names
are important. So, thinking about things harder now.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]