* [PATCH] misc: Add RZG2L OTP support
@ 2026-04-14 9:14 Mathieu Othacehe
2026-04-14 14:53 ` Tom Rini
2026-04-14 22:18 ` Marek Vasut
0 siblings, 2 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2026-04-14 9:14 UTC (permalink / raw)
To: Tom Rini, Marek Vasut, Paul Barker, Nobuhiro Iwamatsu
Cc: Mathieu Othacehe, u-boot
Add OTP support through the fuse command. Fusing is directly performed by
U-Boot, which means that the trusted-firmware must allow the non-secure
world to perform fusing operations.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
drivers/misc/Kconfig | 7 ++
drivers/misc/Makefile | 1 +
drivers/misc/rzg2l_otp.c | 222 +++++++++++++++++++++++++++++++++++++++
3 files changed, 230 insertions(+)
create mode 100644 drivers/misc/rzg2l_otp.c
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index ea785793d18..16cb800a393 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -132,6 +132,13 @@ config SPL_ROCKCHIP_IODOMAIN
for the IO-domain setting of the SoC to match the voltage supplied
by the regulators.
+config RZG2L_OTP
+ bool "Renesas RZ/G2L OTP support"
+ depends on MISC
+ help
+ Enable support for the OTP controller on
+ Renesas RZ/G2L SoCs.
+
config SIFIVE_OTP
bool "SiFive eMemory OTP driver"
depends on MISC
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index e2170212e5a..64b2701b672 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -69,6 +69,7 @@ obj-$(CONFIG_QCOM_GENI) += qcom_geni.o
obj-$(CONFIG_$(PHASE_)ROCKCHIP_EFUSE) += rockchip-efuse.o
obj-$(CONFIG_$(PHASE_)ROCKCHIP_OTP) += rockchip-otp.o
obj-$(CONFIG_$(PHASE_)ROCKCHIP_IODOMAIN) += rockchip-io-domain.o
+obj-$(CONFIG_RZG2L_OTP) += rzg2l_otp.o
obj-$(CONFIG_SANDBOX) += syscon_sandbox.o misc_sandbox.o
obj-$(CONFIG_SIFIVE_OTP) += sifive-otp.o
obj-$(CONFIG_SMSC_LPC47M) += smsc_lpc47m.o
diff --git a/drivers/misc/rzg2l_otp.c b/drivers/misc/rzg2l_otp.c
new file mode 100644
index 00000000000..3aa3880e679
--- /dev/null
+++ b/drivers/misc/rzg2l_otp.c
@@ -0,0 +1,222 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2026 Mathieu Othacehe <m.othacehe@gmail.com>
+ */
+#include <fuse.h>
+#include <asm/io.h>
+#include <linux/delay.h>
+
+/*
+ * XXX: To enable direct fusing through U-Boot, the trusted-firmware must
+ * allow the non-secure world to perform fusing operations. This is controlled
+ * by the SYS_SLVACCCTL7 register.
+ */
+#define RZG2L_OTP_BASE 0x11860000
+#define RZG2L_SYSC_BASE 0x11020000
+
+#define RZ_SYS_BASE_DEVID (RZG2L_SYSC_BASE + 0x0A04)
+#define RZ_OTP_BASE_DEVID (RZG2L_OTP_BASE + 0x1178)
+#define RZ_OTP_BASE_CHIPID (RZG2L_OTP_BASE + 0x1140)
+
+#define RZ_OTP_PWR (RZG2L_OTP_BASE + 0x0000)
+#define RZ_OTP_STR (RZG2L_OTP_BASE + 0x0004)
+#define RZ_OTP_STAWR (RZG2L_OTP_BASE + 0x0008)
+#define RZ_OTP_ADRWR (RZG2L_OTP_BASE + 0x000c)
+#define RZ_OTP_DATAWR (RZG2L_OTP_BASE + 0x0010)
+
+#define RZ_OTP_ADRRD (RZG2L_OTP_BASE + 0x0014)
+#define RZ_OTP_DATARD (RZG2L_OTP_BASE + 0x0018)
+
+#define RZ_OTP_FLAG (RZG2L_OTP_BASE + 0x001c)
+
+#define OTP_PWR BIT(0)
+#define ERR_WR_1 BIT(1)
+#define ERR_WR_2 BIT(2)
+#define ERR_WP BIT(3)
+#define OTP_ACCL BIT(4)
+#define ERR_RDY_WR BIT(8)
+#define OTP_DUMMY_READ (0x400 >> 2)
+
+static int rzg2l_otp_open(void)
+{
+ int i = 0;
+
+ if (readl(RZ_OTP_PWR) & 1) {
+ debug("OTP already powered up\n");
+ return 0;
+ }
+
+ while ((readl(RZ_OTP_STR) & 1) ||
+ ((readl(RZ_OTP_FLAG) & 1) == 0)) {
+ if (i++ > 1000) {
+ printf("OTP power-up timeout\n");
+ return -ETIMEDOUT;
+ }
+
+ mdelay(1);
+ }
+
+ writel(readl(RZ_OTP_PWR) | OTP_PWR | OTP_ACCL, RZ_OTP_PWR);
+
+ return 0;
+}
+
+static int rzg2l_otp_dummy_read(void)
+{
+ int i = 0;
+
+ while ((readl(RZ_OTP_STR) & 1) == 0) {
+ if (i++ > 1000) {
+ printf("Timeout polling ready for OTP read\n");
+ return -ETIMEDOUT;
+ }
+ mdelay(1);
+ }
+
+ writel(RZG2L_OTP_BASE + OTP_DUMMY_READ, RZ_OTP_ADRRD);
+ readl(RZ_OTP_DATARD);
+
+ return 0;
+}
+
+static int rzg2l_otp_close(void)
+{
+ int i = 0;
+ u32 val;
+
+ rzg2l_otp_dummy_read();
+
+ val = readl(RZ_OTP_PWR);
+ val = val & OTP_PWR & OTP_ACCL;
+ writel(val, RZ_OTP_PWR);
+
+ while (readl(RZ_OTP_STR) & 1) {
+ if (i++ > 1000) {
+ printf("Timeout leaving OTP ready state\n");
+ return -ETIMEDOUT;
+ }
+ mdelay(1);
+ }
+
+ return 0;
+}
+
+static int rzg2l_otp_read_word(u32 addr, u32 *val)
+{
+ int i = 0;
+ int ret;
+
+ ret = rzg2l_otp_open();
+ if (ret < 0)
+ return ret;
+
+ while ((readl(RZ_OTP_STR) & 1) == 0) {
+ if (i++ > 1000) {
+ printf("Timeout polling ready for OTP read\n");
+ rzg2l_otp_close();
+ return -ETIMEDOUT;
+ }
+ mdelay(1);
+ }
+
+ writel(addr, RZ_OTP_ADRRD);
+ *val = readl(RZ_OTP_DATARD);
+
+ ret = rzg2l_otp_close();
+
+ return ret;
+}
+
+static int rzg2l_otp_program_word(u32 addr, u32 val)
+{
+ int i = 0;
+ int ret;
+ u32 otpval;
+
+ ret = rzg2l_otp_open();
+ if (ret < 0)
+ return ret;
+
+ while ((readl(RZ_OTP_STR) & 1) == 0) {
+ if (i++ > 1000) {
+ printf("Timeout polling ready for OTP write\n");
+ goto close;
+ }
+ mdelay(1);
+ }
+
+ writel(addr, RZ_OTP_ADRWR);
+ writel(val, RZ_OTP_DATAWR);
+
+ writel(1, RZ_OTP_STAWR);
+
+ if (readl(RZ_OTP_STR) & ERR_RDY_WR) {
+ printf("OTP not ready for write\n");
+ writel(readl(RZ_OTP_STR) & ERR_RDY_WR, RZ_OTP_STR);
+ goto close;
+ }
+
+ i = 0;
+ while ((readl(RZ_OTP_STR) & 1) == 0 ||
+ (readl(RZ_OTP_STAWR) & 1)) {
+ if (i++ > 1000) {
+ printf("Timeout polling OTP write finished\n");
+ goto close;
+ }
+
+ mdelay(1);
+ }
+
+ if ((readl(RZ_OTP_STR) & ERR_WP) ||
+ (readl(RZ_OTP_STR) & ERR_WR_1) ||
+ (readl(RZ_OTP_STR) & ERR_WR_2)) {
+ printf("OTP write error (protected or invalid)\n");
+ goto close;
+ }
+
+ writel(addr, RZ_OTP_ADRRD);
+ otpval = readl(RZ_OTP_DATARD);
+
+ if (otpval != val) {
+ printf("OTP verify failed: wrote 0x%08x read 0x%08x\n",
+ val, otpval);
+ goto close;
+ }
+
+close:
+ ret = rzg2l_otp_close();
+ return ret;
+}
+
+/* ---------------------------------------------------------------- */
+/* U-Boot fuse API */
+
+int fuse_read(u32 bank, u32 word, u32 *val)
+{
+ u32 addr;
+
+ addr = RZG2L_OTP_BASE + (word >> 2);
+
+ return rzg2l_otp_read_word(addr, val);
+}
+
+int fuse_prog(u32 bank, u32 word, u32 val)
+{
+ u32 addr;
+
+ addr = RZG2L_OTP_BASE + (word >> 2);
+
+ return rzg2l_otp_program_word(addr, val);
+}
+
+int fuse_sense(u32 bank, u32 word, u32 *val)
+{
+ /* not supported */
+ return -ENOSYS;
+}
+
+int fuse_override(u32 bank, u32 word, u32 val)
+{
+ /* not supported */
+ return -ENOSYS;
+}
--
2.52.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Add RZG2L OTP support
2026-04-14 9:14 [PATCH] misc: Add RZG2L OTP support Mathieu Othacehe
@ 2026-04-14 14:53 ` Tom Rini
2026-04-14 22:18 ` Marek Vasut
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2026-04-14 14:53 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: Marek Vasut, Paul Barker, Nobuhiro Iwamatsu, u-boot
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
On Tue, Apr 14, 2026 at 11:14:21AM +0200, Mathieu Othacehe wrote:
> Add OTP support through the fuse command. Fusing is directly performed by
> U-Boot, which means that the trusted-firmware must allow the non-secure
> world to perform fusing operations.
>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> ---
> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/rzg2l_otp.c | 222 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 230 insertions(+)
> create mode 100644 drivers/misc/rzg2l_otp.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index ea785793d18..16cb800a393 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -132,6 +132,13 @@ config SPL_ROCKCHIP_IODOMAIN
> for the IO-domain setting of the SoC to match the voltage supplied
> by the regulators.
>
> +config RZG2L_OTP
> + bool "Renesas RZ/G2L OTP support"
> + depends on MISC
> + help
> + Enable support for the OTP controller on
> + Renesas RZ/G2L SoCs.
> +
If there's other feedback, this should have some dependency on CMD_FUSE
as well (since that's what makes use of the functionality) but indeed
it's very inconsistent currently, and the area in general could use some
modernization.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Add RZG2L OTP support
2026-04-14 9:14 [PATCH] misc: Add RZG2L OTP support Mathieu Othacehe
2026-04-14 14:53 ` Tom Rini
@ 2026-04-14 22:18 ` Marek Vasut
2026-04-17 8:00 ` Mathieu Othacehe
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2026-04-14 22:18 UTC (permalink / raw)
To: Mathieu Othacehe, Tom Rini, Paul Barker, Nobuhiro Iwamatsu; +Cc: u-boot
On 4/14/26 11:14 AM, Mathieu Othacehe wrote:
[...]
> +/*
> + * XXX: To enable direct fusing through U-Boot, the trusted-firmware must
> + * allow the non-secure world to perform fusing operations. This is controlled
> + * by the SYS_SLVACCCTL7 register.
Is there some SMC call to perform the fusing via TFA ?
> + */
> +#define RZG2L_OTP_BASE 0x11860000
> +#define RZG2L_SYSC_BASE 0x11020000
Can this be parsed out of DT ?
> +#define RZ_SYS_BASE_DEVID (RZG2L_SYSC_BASE + 0x0A04)
> +#define RZ_OTP_BASE_DEVID (RZG2L_OTP_BASE + 0x1178)
> +#define RZ_OTP_BASE_CHIPID (RZG2L_OTP_BASE + 0x1140)
> +
> +#define RZ_OTP_PWR (RZG2L_OTP_BASE + 0x0000)
> +#define RZ_OTP_STR (RZG2L_OTP_BASE + 0x0004)
> +#define RZ_OTP_STAWR (RZG2L_OTP_BASE + 0x0008)
> +#define RZ_OTP_ADRWR (RZG2L_OTP_BASE + 0x000c)
> +#define RZ_OTP_DATAWR (RZG2L_OTP_BASE + 0x0010)
> +
> +#define RZ_OTP_ADRRD (RZG2L_OTP_BASE + 0x0014)
> +#define RZ_OTP_DATARD (RZG2L_OTP_BASE + 0x0018)
> +
> +#define RZ_OTP_FLAG (RZG2L_OTP_BASE + 0x001c)
> +
> +#define OTP_PWR BIT(0)
> +#define ERR_WR_1 BIT(1)
> +#define ERR_WR_2 BIT(2)
> +#define ERR_WP BIT(3)
> +#define OTP_ACCL BIT(4)
> +#define ERR_RDY_WR BIT(8)
> +#define OTP_DUMMY_READ (0x400 >> 2)
What does 0x400 >> 2 mean ?
> +static int rzg2l_otp_open(void)
> +{
> + int i = 0;
> +
> + if (readl(RZ_OTP_PWR) & 1) {
What does this magic value 1 mean ? Please add macro for it.
> + debug("OTP already powered up\n");
> + return 0;
> + }
> +
> + while ((readl(RZ_OTP_STR) & 1) ||
> + ((readl(RZ_OTP_FLAG) & 1) == 0)) {
read_poll_*() .
> + if (i++ > 1000) {
> + printf("OTP power-up timeout\n");
> + return -ETIMEDOUT;
> + }
> +
> + mdelay(1);
> + }
> +
> + writel(readl(RZ_OTP_PWR) | OTP_PWR | OTP_ACCL, RZ_OTP_PWR);
> +
> + return 0;
> +}
> +
> +static int rzg2l_otp_dummy_read(void)
> +{
> + int i = 0;
> +
> + while ((readl(RZ_OTP_STR) & 1) == 0) {
readl_poll_*()
> + if (i++ > 1000) {
> + printf("Timeout polling ready for OTP read\n");
> + return -ETIMEDOUT;
> + }
> + mdelay(1);
> + }
> +
> + writel(RZG2L_OTP_BASE + OTP_DUMMY_READ, RZ_OTP_ADRRD);
> + readl(RZ_OTP_DATARD);
> +
> + return 0;
> +}
> +
> +static int rzg2l_otp_close(void)
> +{
> + int i = 0;
> + u32 val;
> +
> + rzg2l_otp_dummy_read();
> +
> + val = readl(RZ_OTP_PWR);
> + val = val & OTP_PWR & OTP_ACCL;
> + writel(val, RZ_OTP_PWR);
clrsetbits_le32()
> + while (readl(RZ_OTP_STR) & 1) {
readl_poll ...
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Add RZG2L OTP support
2026-04-14 22:18 ` Marek Vasut
@ 2026-04-17 8:00 ` Mathieu Othacehe
2026-04-17 13:59 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Othacehe @ 2026-04-17 8:00 UTC (permalink / raw)
To: Marek Vasut; +Cc: Tom Rini, Paul Barker, Nobuhiro Iwamatsu, u-boot
Hello Marek,
>> + * XXX: To enable direct fusing through U-Boot, the trusted-firmware must
>> + * allow the non-secure world to perform fusing operations. This is controlled
>> + * by the SYS_SLVACCCTL7 register.
>
> Is there some SMC call to perform the fusing via TFA ?
No, there is a fusing driver in Renesas OP-TEE fork[1] but that's it.
>> + */
>> +#define RZG2L_OTP_BASE 0x11860000
>> +#define RZG2L_SYSC_BASE 0x11020000
>
> Can this be parsed out of DT ?
There is no entry for the OTP_BASE in the device-tree. There is one for
the SYSC_BASE though.
I took the rest of your comments into account and sent a v2.
Thanks,
Mathieu
[1]: https://github.com/renesas-rz/rzg_optee-os
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Add RZG2L OTP support
2026-04-17 8:00 ` Mathieu Othacehe
@ 2026-04-17 13:59 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2026-04-17 13:59 UTC (permalink / raw)
To: Mathieu Othacehe, Geert Uytterhoeven
Cc: Tom Rini, Paul Barker, Nobuhiro Iwamatsu, u-boot
On 4/17/26 10:00 AM, Mathieu Othacehe wrote:
Hello Mathieu,
>>> + * XXX: To enable direct fusing through U-Boot, the trusted-firmware must
>>> + * allow the non-secure world to perform fusing operations. This is controlled
>>> + * by the SYS_SLVACCCTL7 register.
>>
>> Is there some SMC call to perform the fusing via TFA ?
>
> No, there is a fusing driver in Renesas OP-TEE fork[1] but that's it.
>
>>> + */
>>> +#define RZG2L_OTP_BASE 0x11860000
>>> +#define RZG2L_SYSC_BASE 0x11020000
>>
>> Can this be parsed out of DT ?
>
> There is no entry for the OTP_BASE in the device-tree. There is one for
> the SYSC_BASE though.
How about adding a new node into the DT which represents the fuse
controller ?
> I took the rest of your comments into account and sent a v2.
Thank you
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-17 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-14 9:14 [PATCH] misc: Add RZG2L OTP support Mathieu Othacehe
2026-04-14 14:53 ` Tom Rini
2026-04-14 22:18 ` Marek Vasut
2026-04-17 8:00 ` Mathieu Othacehe
2026-04-17 13:59 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox