From: Alexey Charkov <alchark@flipper.net>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
"Kory Maincent (TI.com)" <kory.maincent@bootlin.com>,
Simon Glass <sjg@chromium.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Andrew Goodbody <andrew.goodbody@linaro.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Anshul Dalal <anshuld@ti.com>, Peng Fan <peng.fan@nxp.com>,
Martin Schwan <m.schwan@phytec.de>,
Daniel Golle <daniel@makrotopia.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Alexey Charkov <alchark@flipper.net>
Subject: [PATCH 1/7] pxe_utils: fix W=1 kernel-doc warnings
Date: Thu, 04 Jun 2026 19:31:06 +0400 [thread overview]
Message-ID: <20260604-bls-v1-1-4ce6d1ee4711@flipper.net> (raw)
In-Reply-To: <20260604-bls-v1-0-4ce6d1ee4711@flipper.net>
Add the missing parameter and enum value descriptions reported by
scripts/kernel-doc when building with W=1:
- get_relfile(): document @type
- get_pxelinux_path(): document @pxefile_addr_r
- enum lex_state: document L_NORMAL, L_KEYWORD, L_SLITERAL
- get_token(): document @t and @state
No functional change.
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
boot/pxe_utils.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index 419ab1f1b0ef..774d5f43c036 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -95,6 +95,7 @@ int format_mac_pxe(char *outbuf, size_t outbuf_len)
* @ctx: PXE context
* @file_path: File path to read (relative to the PXE file)
* @file_addr: Address to load file to
+ * @type: Image type used to record the loaded file in the bootflow
* @filesizep: If not NULL, returns the file size in bytes
* Returns 1 for success, or < 0 on error
*/
@@ -162,6 +163,7 @@ int get_pxe_file(struct pxe_context *ctx, const char *file_path,
*
* @ctx: PXE context
* @file: Filename to process (relative to pxelinux.cfg/)
+ * @pxefile_addr_r: Address to load the file to
* Returns 1 for success, -ENAMETOOLONG if the resulting path is too long.
* or other value < 0 on other error
*/
@@ -914,6 +916,13 @@ static const struct token keywords[] = {
* Since pxe(linux) files don't have a token to identify the start of a
* literal, we have to keep track of when we're in a state where a literal is
* expected vs when we're in a state a keyword is expected.
+ *
+ * @L_NORMAL: Outside any specific lexical context; whitespace is skipped
+ * and the next non-blank token determines what is read
+ * @L_KEYWORD: A keyword is expected; the next word is matched against the
+ * keyword table and tagged with the matching token type
+ * @L_SLITERAL: A string literal is expected; characters are read up to the
+ * end of the line
*/
enum lex_state {
L_NORMAL = 0,
@@ -1018,6 +1027,9 @@ static void get_keyword(struct token *t)
*
* @p: Points to a pointer to the current position in the input being processed.
* Updated to point at the first character after the current token
+ * @t: Token to populate with the type and value of what was read
+ * @state: Current lexer state, controlling whether a keyword or a string
+ * literal is expected next
*/
static void get_token(char **p, struct token *t, enum lex_state state)
{
--
2.53.0
next prev parent reply other threads:[~2026-06-04 15:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 15:31 [PATCH 0/7] pxe_utils: small fixups, implement BLS type 1 boot on top of them Alexey Charkov
2026-06-04 15:31 ` Alexey Charkov [this message]
2026-06-04 16:05 ` [PATCH 1/7] pxe_utils: fix W=1 kernel-doc warnings Tom Rini
2026-06-25 15:25 ` Simon Glass
2026-06-25 15:28 ` Simon Glass
2026-06-04 15:31 ` [PATCH 2/7] pxe_utils: accept "options" as synonym for "append" Alexey Charkov
2026-06-04 16:06 ` Tom Rini
2026-06-04 15:31 ` [PATCH 3/7] pxe_utils: extract per-entry key parsing into parse_label_keys() Alexey Charkov
2026-06-04 16:06 ` Tom Rini
2026-06-18 15:12 ` Simon Glass
2026-06-25 15:28 ` Simon Glass
2026-06-25 15:55 ` Alexey Charkov
2026-06-04 15:31 ` [PATCH 4/7] pxe_utils: export per-entry label helpers Alexey Charkov
2026-06-04 15:31 ` [PATCH 5/7] pxe_utils: optionally ignore unknown keys in parse_label_keys() Alexey Charkov
2026-06-04 15:31 ` [PATCH 6/7] pxe_utils: accept "title" inside a label as a synonym for "menu label" Alexey Charkov
2026-06-04 15:31 ` [PATCH 7/7] boot: add a minimal bootmeth for the Boot Loader Specification Alexey Charkov
2026-06-12 18:24 ` Simon Glass
2026-06-25 15:28 ` Simon Glass
2026-06-25 15:51 ` Alexey Charkov
2026-06-25 16:24 ` Simon Glass
2026-06-25 16:57 ` Alexey Charkov
2026-06-25 17:24 ` Tom Rini
2026-06-25 17:29 ` Simon Glass
2026-06-25 17:32 ` Tom Rini
2026-06-26 10:45 ` Simon Glass
2026-06-26 13:47 ` Tom Rini
2026-06-29 5:45 ` Simon Glass
2026-06-29 14:24 ` Tom Rini
2026-06-25 17:25 ` Simon Glass
2026-06-04 16:05 ` [PATCH 0/7] pxe_utils: small fixups, implement BLS type 1 boot on top of them Tom Rini
2026-06-04 17:16 ` Alexey Charkov
2026-06-04 17:21 ` Tom Rini
2026-06-04 17:35 ` Alexey Charkov
2026-06-12 18:23 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604-bls-v1-1-4ce6d1ee4711@flipper.net \
--to=alchark@flipper.net \
--cc=andrew.goodbody@linaro.org \
--cc=anshuld@ti.com \
--cc=daniel@makrotopia.org \
--cc=hvilleneuve@dimonoff.com \
--cc=kory.maincent@bootlin.com \
--cc=m.schwan@phytec.de \
--cc=mkorpershoek@kernel.org \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox