Re: [PATCH] test: cmd: part: fix integer handling in setup_gpt_partitions()

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

On Sat, Jun 27, 2026 at 07:24:24PM +0200, Dario Binacchi wrote:
> On Fri, Jun 26, 2026 at 11:58 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Jun 26, 2026 at 08:40:36PM +0200, Quentin Schulz wrote:
> > > Hi Dario,
> > >
> > > On 6/26/26 8:33 PM, Dario Binacchi wrote:
> > > > Coverity reports an INTEGER_OVERFLOW issue because ut_asserteq() compares
> > > > an unsigned int (mmc_dev_num) with ret, which can hold a negative error
> > > > code.
> > > >
> > >
> > > The trick here is that ut_asserteq() takes two arguments and casts both as
> > > unsigned int, hence why it complains.
> > >
> > > If Coverity is happy, I'm happy :)
> > >
> > > This looks fine to me, so:
> > >
> > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> >
> > Yes, were you able to push this through coverity on your own?
> 
> No, I haven't.
> 
> I couldn't find any documentation on how Coverity is run for U-Boot.
> Is there a recommended way to verify Coverity fixes?

There isn't, because AFAICT there's no way to do "test" builds to see if
a change corrects the problem. And I don't have this running via CI
because due to our codebase size, I think we'd be limited to 2 runs per
day, at most.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]