U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] test: cmd: part: fix integer handling in setup_gpt_partitions()
Date: Fri, 26 Jun 2026 20:40:36 +0200	[thread overview]
Message-ID: <3dfd02eb-fcc1-49d1-aea2-6bd20f052692@cherry.de> (raw)
In-Reply-To: <20260626183353.1666667-1-dario.binacchi@amarulasolutions.com>

Hi Dario,

On 6/26/26 8:33 PM, Dario Binacchi wrote:
> Coverity reports an INTEGER_OVERFLOW issue because ut_asserteq() compares
> an unsigned int (mmc_dev_num) with ret, which can hold a negative error
> code.
> 

The trick here is that ut_asserteq() takes two arguments and casts both 
as unsigned int, hence why it complains.

If Coverity is happy, I'm happy :)

This looks fine to me, so:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

  reply	other threads:[~2026-06-26 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 18:33 [PATCH] test: cmd: part: fix integer handling in setup_gpt_partitions() Dario Binacchi
2026-06-26 18:40 ` Quentin Schulz [this message]
2026-06-26 21:58   ` Tom Rini
2026-06-27 17:24     ` Dario Binacchi
2026-06-27 17:31       ` Tom Rini
2026-07-01 11:57         ` Simon Glass
2026-07-01 14:20           ` Tom Rini
2026-07-01 12:52     ` Quentin Schulz
2026-07-14 17:56 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dfd02eb-fcc1-49d1-aea2-6bd20f052692@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox