From: Tom Rini <trini@konsulko.com>
To: Takahiro.Kuwano@infineon.com
Cc: ssunkkan@gmail.com, vigneshr@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support
Date: Fri, 3 Jul 2026 08:11:40 -0600 [thread overview]
Message-ID: <20260703141140.GI749385@bill-the-cat> (raw)
In-Reply-To: <5787d9d649b34f74b66a56a067da9760@infineon.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Fri, Jul 03, 2026 at 08:11:48AM +0000, Takahiro.Kuwano@infineon.com wrote:
> Hi,
>
> > Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.
> >
> > Datasheet:
> > https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view
>
> Do you have a link to vendor's site? If you have, use Link: tag just above
> your Signed-off-by: tag. If not, please write this after the '---' separator.
> I don't think it's good to add a link to share drive in commit description.
Yes, this is not a good idea, we need a link to the vendor, somewhere.
> > Signed-off-by: Ssunk <ssunkkan@gmail.com>
>
> Could you sign with full name?
Just like the linux kernel, we don't have a "full name" policy anymore,
so this part is fine.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-03 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 13:44 [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support Ssunk
2026-07-03 8:11 ` Takahiro.Kuwano
2026-07-03 14:11 ` Tom Rini [this message]
2026-07-06 1:51 ` Takahiro.Kuwano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703141140.GI749385@bill-the-cat \
--to=trini@konsulko.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=ssunkkan@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox