[PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

[PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

[Ssunk]

Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.

Datasheet:
https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

Signed-off-by: Ssunk <ssunkkan@gmail.com>
---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index c0fa98424aa..b370e782627 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+	{ INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
+		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	/* EON -- en25xxx */
-- 
2.43.0

RE: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

[Takahiro.Kuwano]

Hi,

> Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.
> 
> Datasheet:
> https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

Do you have a link to vendor's site? If you have, use Link: tag just above
your Signed-off-by: tag. If not, please write this after the '---' separator.
I don't think it's good to add a link to share drive in commit description.

> 
> Signed-off-by: Ssunk <ssunkkan@gmail.com>

Could you sign with full name?

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index c0fa98424aa..b370e782627 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
>                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>         { INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
>                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> +       { INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
> +                   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_EON            /* EON */
>         /* EON -- en25xxx */
> --
> 2.43.0

Thanks,
Takahiro

Re: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Fri, Jul 03, 2026 at 08:11:48AM +0000, Takahiro.Kuwano@infineon.com wrote:
> Hi,
> 
> > Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.
> > 
> > Datasheet:
> > https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view
> 
> Do you have a link to vendor's site? If you have, use Link: tag just above
> your Signed-off-by: tag. If not, please write this after the '---' separator.
> I don't think it's good to add a link to share drive in commit description.

Yes, this is not a good idea, we need a link to the vendor, somewhere.

> > Signed-off-by: Ssunk <ssunkkan@gmail.com>
> 
> Could you sign with full name?

Just like the linux kernel, we don't have a "full name" policy anymore,
so this part is fine.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

RE: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

[Takahiro.Kuwano]

> -----Original Message-----
> From: Tom Rini <trini@konsulko.com>
> Sent: Friday, July 3, 2026 11:12 PM
> To: Kuwano Takahiro (ATV MS MPL PAE - MS) <Takahiro.Kuwano@infineon.com>
> Cc: ssunkkan@gmail.com; vigneshr@ti.com; u-boot@lists.denx.de
> Subject: Re: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support
> 
> On Fri, Jul 03, 2026 at 08:11:48AM +0000, Takahiro.Kuwano@infineon.com wrote:
> > Hi,
> >
> > > Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.
> > >
> > > Datasheet:
> > > https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view
> >
> > Do you have a link to vendor's site? If you have, use Link: tag just above
> > your Signed-off-by: tag. If not, please write this after the '---' separator.
> > I don't think it's good to add a link to share drive in commit description.
> 
> Yes, this is not a good idea, we need a link to the vendor, somewhere.
> 
> > > Signed-off-by: Ssunk <ssunkkan@gmail.com>
> >
> > Could you sign with full name?
> 
> Just like the linux kernel, we don't have a "full name" policy anymore,
> so this part is fine.

Well noted with thanks.

Takahiro