[PATCH v1] env: Fix compile error for envtools

[PATCH v1] env: Fix compile error for envtools

[Jacky Cao]

Following error happens when build envtools for mx6qsabrelite.

$ make tools envtools
  UPD     include/generated/timestamp_autogenerated.h
  HOSTCC  tools/printinitialenv
  GENENV  u-boot-initial-env
  COPY    tools/version.h
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from ./arch/arm/include/asm/mach-imx/regs-lcdif.h:16,
                 from ./arch/arm/include/asm/arch/imx-regs.h:371,
                 from include/configs/mx6_common.h:21,
                 from include/configs/nitrogen6x.h:13,
                 from include/config.h:3,
                 from include/env.h:12,
                 from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
./arch/arm/include/asm/mach-imx/regs-common.h:51:9: error: unknown type name 'uint8_t'
   51 |         __mxs_reg_8(reg)
      |         ^~~~~~~~~~~

uint8_t type is defined in linux/types.h header file.
The config.h includes regs-common.h that uses uint8_t type,
to fix this, include config.h after linux/types.h in env.h file.

Fixes: 9f1807e57cbb ("env: add env_set_runtime() helper")

Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
---
 include/env.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/env.h b/include/env.h
index 9b872fb26eb..dcd017fa5e6 100644
--- a/include/env.h
+++ b/include/env.h
@@ -9,10 +9,10 @@
 #ifndef __ENV_H
 #define __ENV_H
 
-#include <config.h>
 #include <compiler.h>
 #include <stdbool.h>
 #include <linux/types.h>
+#include <config.h>
 
 struct environment_s;
 
-- 
2.34.1

RE: [PATCH v1] env: Fix compile error for envtools

[Peng Fan (OSS)]

> Subject: [PATCH v1] env: Fix compile error for envtools
> 
> Following error happens when build envtools for mx6qsabrelite.
> 
> $ make tools envtools
>   UPD     include/generated/timestamp_autogenerated.h
>   HOSTCC  tools/printinitialenv
>   GENENV  u-boot-initial-env
>   COPY    tools/version.h
>   HOSTCC  tools/env/crc32.o
>   HOSTCC  tools/env/ctype.o
>   HOSTCC  tools/env/env_attr.o
>   HOSTCC  tools/env/env_flags.o
> In file included from ./arch/arm/include/asm/mach-imx/regs-lcdif.h:16,
>                  from ./arch/arm/include/asm/arch/imx-regs.h:371,
>                  from include/configs/mx6_common.h:21,
>                  from include/configs/nitrogen6x.h:13,
>                  from include/config.h:3,
>                  from include/env.h:12,
>                  from tools/env/../../env/flags.c:7,
>                  from tools/env/env_flags.c:1:
> ./arch/arm/include/asm/mach-imx/regs-common.h:51:9: error:
> unknown type name 'uint8_t'

"#include <linux/types.h>" was already in
arch/arm/include/asm/mach-imx/regs-common.h

Are u using an old tree?

Regards
Peng.

>    51 |         __mxs_reg_8(reg)
>       |         ^~~~~~~~~~~
> 
> uint8_t type is defined in linux/types.h header file.
> The config.h includes regs-common.h that uses uint8_t type, to fix this,
> include config.h after linux/types.h in env.h file.
> 
> Fixes: 9f1807e57cbb ("env: add env_set_runtime() helper")
> 
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> ---
>  include/env.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/env.h b/include/env.h index
> 9b872fb26eb..dcd017fa5e6 100644
> --- a/include/env.h
> +++ b/include/env.h
> @@ -9,10 +9,10 @@
>  #ifndef __ENV_H
>  #define __ENV_H
> 
> -#include <config.h>
>  #include <compiler.h>
>  #include <stdbool.h>
>  #include <linux/types.h>
> +#include <config.h>
> 
>  struct environment_s;
> 
> --
> 2.34.1

RE: [PATCH v1] env: Fix compile error for envtools

[Jacky.Cao]

>> Following error happens when build envtools for mx6qsabrelite.
>> 
>> $ make tools envtools
>>   UPD     include/generated/timestamp_autogenerated.h
>>   HOSTCC  tools/printinitialenv
>>   GENENV  u-boot-initial-env
>>   COPY    tools/version.h
>>   HOSTCC  tools/env/crc32.o
>>   HOSTCC  tools/env/ctype.o
>>   HOSTCC  tools/env/env_attr.o
>>   HOSTCC  tools/env/env_flags.o
>> In file included from ./arch/arm/include/asm/mach-imx/regs-lcdif.h:16,
>>                  from ./arch/arm/include/asm/arch/imx-regs.h:371,
>>                  from include/configs/mx6_common.h:21,
>>                  from include/configs/nitrogen6x.h:13,
>>                  from include/config.h:3,
>>                  from include/env.h:12,
>>                  from tools/env/../../env/flags.c:7,
>>                  from tools/env/env_flags.c:1:
>> ./arch/arm/include/asm/mach-imx/regs-common.h:51:9: error:
>> unknown type name 'uint8_t'
>
>"#include <linux/types.h>" was already in
>arch/arm/include/asm/mach-imx/regs-common.h
>
>Are u using an old tree?

I use master branch of OSS u-boot repo and meet the issue with
below commands:

make mx6qsabrelite_defconfig
make -j8
make tools envtools

Re: [PATCH v1] env: Fix compile error for envtools

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

On Tue, Jul 14, 2026 at 01:35:42AM +0000, Jacky.Cao@sony.com wrote:
> >> Following error happens when build envtools for mx6qsabrelite.
> >> 
> >> $ make tools envtools
> >>   UPD     include/generated/timestamp_autogenerated.h
> >>   HOSTCC  tools/printinitialenv
> >>   GENENV  u-boot-initial-env
> >>   COPY    tools/version.h
> >>   HOSTCC  tools/env/crc32.o
> >>   HOSTCC  tools/env/ctype.o
> >>   HOSTCC  tools/env/env_attr.o
> >>   HOSTCC  tools/env/env_flags.o
> >> In file included from ./arch/arm/include/asm/mach-imx/regs-lcdif.h:16,
> >>                  from ./arch/arm/include/asm/arch/imx-regs.h:371,
> >>                  from include/configs/mx6_common.h:21,
> >>                  from include/configs/nitrogen6x.h:13,
> >>                  from include/config.h:3,
> >>                  from include/env.h:12,
> >>                  from tools/env/../../env/flags.c:7,
> >>                  from tools/env/env_flags.c:1:
> >> ./arch/arm/include/asm/mach-imx/regs-common.h:51:9: error:
> >> unknown type name 'uint8_t'
> >
> >"#include <linux/types.h>" was already in
> >arch/arm/include/asm/mach-imx/regs-common.h
> >
> >Are u using an old tree?
> 
> I use master branch of OSS u-boot repo and meet the issue with
> below commands:
> 
> make mx6qsabrelite_defconfig
> make -j8
> make tools envtools

What host distribution are you building on? And, <config.h> *must* come
first in the include list, for it to function correctly.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

RE: [PATCH v1] env: Fix compile error for envtools

[Jacky.Cao]

> > I use master branch of OSS u-boot repo and meet the issue with below
> > commands:
> >
> > make mx6qsabrelite_defconfig
> > make -j8
> > make tools envtools
> 
> What host distribution are you building on? And, <config.h> *must* come first
> in the include list, for it to function correctly.

Host OS is Ubuntu 22.04.3 LTS.
Toolchain is Arm GNU Toolchain 11.3.Rel1(arm-none-linux-gnueabihf-).
Also tried Ubuntu 24.04.4 LTS and Arm GNU Toolchain 15.3.Rel1,
the issue still happens.

Re: [PATCH v1] env: Fix compile error for envtools

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Tue, Jul 14, 2026 at 03:04:42AM +0000, Jacky.Cao@sony.com wrote:
> > > I use master branch of OSS u-boot repo and meet the issue with below
> > > commands:
> > >
> > > make mx6qsabrelite_defconfig
> > > make -j8
> > > make tools envtools
> > 
> > What host distribution are you building on? And, <config.h> *must* come first
> > in the include list, for it to function correctly.
> 
> Host OS is Ubuntu 22.04.3 LTS.
> Toolchain is Arm GNU Toolchain 11.3.Rel1(arm-none-linux-gnueabihf-).
> Also tried Ubuntu 24.04.4 LTS and Arm GNU Toolchain 15.3.Rel1,
> the issue still happens.

So, are you on an ARM host too? You aren't specifying where you are /
aren't using the ARM toolchain in the above. Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

RE: [PATCH v1] env: Fix compile error for envtools

[Jacky.Cao]

>> Host OS is Ubuntu 22.04.3 LTS.
>> Toolchain is Arm GNU Toolchain 11.3.Rel1(arm-none-linux-gnueabihf-).
>> Also tried Ubuntu 24.04.4 LTS and Arm GNU Toolchain 15.3.Rel1, the 
>> issue still happens.
>
>So, are you on an ARM host too? You aren't specifying where you are / aren't using the ARM toolchain in the above. Thanks.

Sorry for not explaining it clearly.
Host machine is x86_64 Ubuntu 22.04.3 LTS.
Using arm-none-linux-gnueabihf-gcc 11.3.Rel1 as a cross compiler to build u-boot and envtools for imx6 target.
I also tested on x86_64 Ubuntu 24.04.4 LTS with Arm GNU Toolchain 15.3.Rel1, and the issue still occurs.