From: Tom Rini <trini@konsulko.com>
To: Casey Connolly <casey.connolly@linaro.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Michal Simek <michal.simek@amd.com>,
Raymond Mao <raymondmaoca@gmail.com>,
Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] CI: install python-cryptography for world build
Date: Mon, 20 Jul 2026 08:31:56 -0600 [thread overview]
Message-ID: <20260720143156.GZ749385@bill-the-cat> (raw)
In-Reply-To: <20260720131325.37436-1-casey.connolly@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]
On Mon, Jul 20, 2026 at 02:13:22PM +0100, Casey Connolly wrote:
> The mkmbn Python tool used for some Qualcomm platforms needs the
> cryptography module, make sure it's installed so the world build can
> succeed.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> ---
> .azure-pipelines.yml | 2 +-
> .gitlab-ci.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index 4417ef4e5a50..562c5747c9d3 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -733,9 +733,9 @@ stages:
> python3 -m venv /tmp/venv
> . /tmp/venv/bin/activate
> pip install -r tools/binman/requirements.txt \
> -r tools/buildman/requirements.txt \
> - setuptools
> + setuptools cryptography
> if [[ "${BUILDMAN}" != "" ]]; then
> ret=0;
> tools/buildman/buildman -o /tmp -PEWM ${BUILDMAN} ${OVERRIDE} || ret=$?;
> if [[ $ret -ne 0 ]]; then
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 245e422d72fa..eb13fde82b86 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -153,9 +153,9 @@ build all platforms in a single job:
> - python3 -m venv /tmp/venv;
> . /tmp/venv/bin/activate;
> pip install -r tools/binman/requirements.txt
> -r tools/buildman/requirements.txt
> - setuptools
> + setuptools cryptography
> - ret=0;
> git config --global --add safe.directory "${CI_PROJECT_DIR}";
> ./tools/buildman/buildman -o /tmp -PEWM -x xtensa || ret=$?;
> if [[ $ret -ne 0 ]]; then
Ugh. This shows (a) the CI pipelines had another place that should have
been installing scripts/dtc/pylibfdt/requirements.txt and (b) I don't
know if we should make either boards/qualcomm/requirements.txt or try
again with a top-level requirements.txt file. I believe before Heinrich
disliked that I was including other requirements.txt files in it. I
thought I had said something in reply, but it was a while ago.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-20 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:13 [PATCH] CI: install python-cryptography for world build Casey Connolly
2026-07-20 14:31 ` Tom Rini [this message]
2026-08-06 13:17 ` Casey Connolly
2026-07-20 14:56 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720143156.GZ749385@bill-the-cat \
--to=trini@konsulko.com \
--cc=casey.connolly@linaro.org \
--cc=michal.simek@amd.com \
--cc=raymondmaoca@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox