[PATCH] CI: install python-cryptography for world build

[PATCH] CI: install python-cryptography for world build

[Casey Connolly]

The mkmbn Python tool used for some Qualcomm platforms needs the
cryptography module, make sure it's installed so the world build can
succeed.

Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
---
 .azure-pipelines.yml | 2 +-
 .gitlab-ci.yml       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index 4417ef4e5a50..562c5747c9d3 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -733,9 +733,9 @@ stages:
           python3 -m venv /tmp/venv
           . /tmp/venv/bin/activate
           pip install -r tools/binman/requirements.txt \
             -r tools/buildman/requirements.txt \
-            setuptools
+            setuptools cryptography
           if [[ "${BUILDMAN}" != "" ]]; then
               ret=0;
               tools/buildman/buildman -o /tmp -PEWM ${BUILDMAN} ${OVERRIDE} || ret=$?;
               if [[ $ret -ne 0 ]]; then
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 245e422d72fa..eb13fde82b86 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -153,9 +153,9 @@ build all platforms in a single job:
     - python3 -m venv /tmp/venv;
       . /tmp/venv/bin/activate;
       pip install -r tools/binman/requirements.txt
         -r tools/buildman/requirements.txt
-        setuptools
+        setuptools cryptography
     - ret=0;
       git config --global --add safe.directory "${CI_PROJECT_DIR}";
       ./tools/buildman/buildman -o /tmp -PEWM -x xtensa || ret=$?;
       if [[ $ret -ne 0 ]]; then
-- 
2.55.0

Re: [PATCH] CI: install python-cryptography for world build

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

On Mon, Jul 20, 2026 at 02:13:22PM +0100, Casey Connolly wrote:

> The mkmbn Python tool used for some Qualcomm platforms needs the
> cryptography module, make sure it's installed so the world build can
> succeed.
> 
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> ---
>  .azure-pipelines.yml | 2 +-
>  .gitlab-ci.yml       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index 4417ef4e5a50..562c5747c9d3 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -733,9 +733,9 @@ stages:
>            python3 -m venv /tmp/venv
>            . /tmp/venv/bin/activate
>            pip install -r tools/binman/requirements.txt \
>              -r tools/buildman/requirements.txt \
> -            setuptools
> +            setuptools cryptography
>            if [[ "${BUILDMAN}" != "" ]]; then
>                ret=0;
>                tools/buildman/buildman -o /tmp -PEWM ${BUILDMAN} ${OVERRIDE} || ret=$?;
>                if [[ $ret -ne 0 ]]; then
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 245e422d72fa..eb13fde82b86 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -153,9 +153,9 @@ build all platforms in a single job:
>      - python3 -m venv /tmp/venv;
>        . /tmp/venv/bin/activate;
>        pip install -r tools/binman/requirements.txt
>          -r tools/buildman/requirements.txt
> -        setuptools
> +        setuptools cryptography
>      - ret=0;
>        git config --global --add safe.directory "${CI_PROJECT_DIR}";
>        ./tools/buildman/buildman -o /tmp -PEWM -x xtensa || ret=$?;
>        if [[ $ret -ne 0 ]]; then

Ugh. This shows (a) the CI pipelines had another place that should have
been installing scripts/dtc/pylibfdt/requirements.txt and (b) I don't
know if we should make either boards/qualcomm/requirements.txt or try
again with a top-level requirements.txt file. I believe before Heinrich
disliked that I was including other requirements.txt files in it. I
thought I had said something in reply, but it was a while ago.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] CI: install python-cryptography for world build

[Casey Connolly]

On 20/07/2026 16:31, Tom Rini wrote:
> On Mon, Jul 20, 2026 at 02:13:22PM +0100, Casey Connolly wrote:
> 
>> The mkmbn Python tool used for some Qualcomm platforms needs the
>> cryptography module, make sure it's installed so the world build can
>> succeed.
>>
>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> ---
>>  .azure-pipelines.yml | 2 +-
>>  .gitlab-ci.yml       | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
>> index 4417ef4e5a50..562c5747c9d3 100644
>> --- a/.azure-pipelines.yml
>> +++ b/.azure-pipelines.yml
>> @@ -733,9 +733,9 @@ stages:
>>            python3 -m venv /tmp/venv
>>            . /tmp/venv/bin/activate
>>            pip install -r tools/binman/requirements.txt \
>>              -r tools/buildman/requirements.txt \
>> -            setuptools
>> +            setuptools cryptography
>>            if [[ "${BUILDMAN}" != "" ]]; then
>>                ret=0;
>>                tools/buildman/buildman -o /tmp -PEWM ${BUILDMAN} ${OVERRIDE} || ret=$?;
>>                if [[ $ret -ne 0 ]]; then
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 245e422d72fa..eb13fde82b86 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -153,9 +153,9 @@ build all platforms in a single job:
>>      - python3 -m venv /tmp/venv;
>>        . /tmp/venv/bin/activate;
>>        pip install -r tools/binman/requirements.txt
>>          -r tools/buildman/requirements.txt
>> -        setuptools
>> +        setuptools cryptography
>>      - ret=0;
>>        git config --global --add safe.directory "${CI_PROJECT_DIR}";
>>        ./tools/buildman/buildman -o /tmp -PEWM -x xtensa || ret=$?;
>>        if [[ $ret -ne 0 ]]; then
> 
> Ugh. This shows (a) the CI pipelines had another place that should have
> been installing scripts/dtc/pylibfdt/requirements.txt and (b) I don't
> know if we should make either boards/qualcomm/requirements.txt or try
> again with a top-level requirements.txt file. I believe before Heinrich
> disliked that I was including other requirements.txt files in it. I
> thought I had said something in reply, but it was a while ago.

I guess I'll add a qcom requirements.txt for now so we can get this
merged, we can also change things around later.
> 

-- 
// Casey (she/her)

Re: [PATCH] CI: install python-cryptography for world build

[Quentin Schulz]

Hi Casey,

On 7/20/26 3:13 PM, Casey Connolly wrote:
> The mkmbn Python tool used for some Qualcomm platforms needs the
> cryptography module, make sure it's installed so the world build can
> succeed.
> 

I would suggest to have a requirements.txt somewhere in 
tools/qcom/mkmbn/ (or the parent) that reflects all external 
dependencies of mkmbn. This will make it easier for integrators to know 
which dependencies are required for building which part(s) of U-Boot.

Then we can add it to the list of requirements.txt we install in the CI.

Cheers,
Quentin