Re: [PATCH v3 2/4] riscv: dts: spacemit: k3: add binman node

[Yixun Lan <dlan@kernel.org>]

Hi E Shattow,

Thanks for the suggestion

On 00:49 Sat 03 Oct     , E Shattow wrote:
> On 10/2/26 17:34, Yixun Lan wrote:
> > SpacemiT K3 follow the standard riscv binman layout, which has opensbi
> > and U-Boot proper, so include the common binman dtsi file.
> > 
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  arch/riscv/dts/spacemit-k3-u-boot.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/riscv/dts/spacemit-k3-u-boot.dtsi b/arch/riscv/dts/spacemit-k3-u-boot.dtsi
> > new file mode 100644
> > index 00000000000..f1c1c3ee6fd
> > --- /dev/null
> > +++ b/arch/riscv/dts/spacemit-k3-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> > +/*
> > + * Copyright (C) 2026 Yixun Lan <dlan@kernel.org>
> > + */
> > +
> > +#include "binman.dtsi"
> > 
> 
> Looks good to me. I suggest to introduce spacemit-k3-binman.dtsi now or
> later, may as well do it now?
> 
Yes, I thought about this as we introduced new SpacemiT image format..
I have no objection to do it now in this series

> See for example of how this looks in files
> starfive-visionfive2-binman.dtsi and starfive-visionfive2-u-boot.dtsi,
> it would be as follows:
> 
> arch/riscv/dts/spacemit-k3-binman.dtsi:
> ...copyright comment...
> +#include "binman.dtsi"
> +
> +
> 
> arch/riscv/dts/spacemit-k3-u-boot.dtsi:
> ...copyright comment...
> -#include "binman.dtsi"
> +
> +
> +#include "spacemit-k3-binman.dtsi"
> 
> With that,
> 
> Reviewed-by: E Shattow <e@freeshell.de>

-- 
Yixun Lan (dlan)