[PATCH 2/6] usb: musb-new: sc5xx: Free the controller if the host probe fails

[Yuho Choi <oss.patchbox@gmail.com>]

In host mode, musb_usb_probe() allocates the struct musb with
musb_init_controller() and returns the error when musb_lowlevel_init()
fails, for example when no device is connected. The struct musb is not
freed on this path, and the driver core then frees the private data that
holds the only pointer to it. Each 'usb reset', or 'usb start' after
'usb stop', probes the controller again and leaks another one.

Free the struct musb when musb_lowlevel_init() fails.

Fixes: 2f6a86a61256 ("usb: musb-new: Add support for Analog Devices SC5xx SoCs")
Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
---
Build-tested only, with sc584-ezkit_defconfig.

musb_usb_remove() does not free the struct musb either; that is not
changed here.

 drivers/usb/musb-new/sc5xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb-new/sc5xx.c b/drivers/usb/musb-new/sc5xx.c
index b1765abe827..c14ba821a2e 100644
--- a/drivers/usb/musb-new/sc5xx.c
+++ b/drivers/usb/musb-new/sc5xx.c
@@ -165,6 +165,8 @@ static int musb_usb_probe(struct udevice *dev)
 			return -EIO;
 
 		ret = musb_lowlevel_init(mdata);
+		if (ret)
+			free(mdata->host);
 	} else {
 		sc5xx_musb_plat.mode = MUSB_PERIPHERAL;
 		mdata->host = musb_register(&sc5xx_musb_plat, &pdata->dev, mregs);
-- 
2.43.0