[PATCH 3/6] usb: musb-new: pic32: Free the controller if the host probe fails

[Yuho Choi <oss.patchbox@gmail.com>]

In host mode, musb_usb_probe() allocates the struct musb with
musb_init_controller() and returns the error when musb_lowlevel_init()
fails, for example when no device is connected. The struct musb is not
freed on this path, and the driver core then frees the private data that
holds the only pointer to it. Each 'usb reset', or 'usb start' after
'usb stop', probes the controller again and leaks another one.

Free the struct musb when musb_lowlevel_init() fails.

Fixes: 03b8e04632ca ("drivers: musb-new: Add USB DRC driver for Microchip PIC32 OTG controller.")
Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
---
Not build-tested: I have no MIPS toolchain.

musb_usb_remove() does not free the struct musb either; that is not
changed here.

 drivers/usb/musb-new/pic32.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb-new/pic32.c b/drivers/usb/musb-new/pic32.c
index b878e979d93..2623e6e526a 100644
--- a/drivers/usb/musb-new/pic32.c
+++ b/drivers/usb/musb-new/pic32.c
@@ -253,6 +253,8 @@ static int musb_usb_probe(struct udevice *dev)
 		return -EIO;
 
 	ret = musb_lowlevel_init(mdata);
+	if (ret)
+		free(mdata->host);
 #else
 	pic32_musb_plat.mode = MUSB_PERIPHERAL;
 	mdata->host = musb_register(&pic32_musb_plat, &pdata->dev, mregs);
-- 
2.43.0