[U-Boot] [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[U-Boot] [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[Ajay Bhargav]

----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: Wednesday, August 10, 2011 2:47 PM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ajay Bhargav
> > Subject: [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC
> Armada100
> > 
> > This patch adds support for generic GPIO driver framework for
> Marvell
> > SoC Armada100.
> > 
> > v4 - updated gpio.h file, removed modification in Armada100.h
> 
> You are not following standard patch submission practice as indicated
> here
> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
> 
> You need to document entire change history for each patch to be
> submitted below ---, this is important
> 
Sorry for mistake..
Do i need to add history in each patch or first patch of a series patch?
I mean if I am submitting 2 patches in series I define history in patch 1/2.
Am I right?

Thanks & Regards,
Ajay Bhargav

[U-Boot] [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Wednesday, August 10, 2011 3:49 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de
> Subject: Re: [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC
> Armada100
> 
> 
> ----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:
> 
> > > -----Original Message-----
> > > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > > Sent: Wednesday, August 10, 2011 2:47 PM
> > > To: Prafulla Wadaskar
> > > Cc: u-boot at lists.denx.de; Ajay Bhargav
> > > Subject: [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC
> > Armada100
> > >
> > > This patch adds support for generic GPIO driver framework for
> > Marvell
> > > SoC Armada100.
> > >
> > > v4 - updated gpio.h file, removed modification in Armada100.h
> >
> > You are not following standard patch submission practice as indicated
> > here
> > http://www.denx.de/wiki/view/U-
> Boot/Patches#Sending_updated_patch_versions
> >
> > You need to document entire change history for each patch to be
> > submitted below ---, this is important
> >
> Sorry for mistake..
> Do i need to add history in each patch or first patch of a series patch?
> I mean if I am submitting 2 patches in series I define history in patch
> 1/2.
> Am I right?

You should add relevant history for each patch, if in your patch series one patch is being changed, change log for that particular path is must for other patches you may say, "Not changed in this version"

You may refer some other patches submitted/accepted on the list.

Regards..
Prafulla . .

[U-Boot] [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[Ajay Bhargav]

This patch adds support for generic GPIO driver framework for Marvell
SoC Armada100.

v4 - updated gpio.h file, removed modification in Armada100.h

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
---
 arch/arm/include/asm/arch-armada100/gpio.h |   47 ++++++++++++++++++++++++++++
 1 files changed, 47 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-armada100/gpio.h

diff --git a/arch/arm/include/asm/arch-armada100/gpio.h b/arch/arm/include/asm/arch-armada100/gpio.h
new file mode 100644
index 0000000..dd47832
--- /dev/null
+++ b/arch/arm/include/asm/arch-armada100/gpio.h
@@ -0,0 +1,47 @@
+/*
+ * (C) Copyright 2011
+ * eInfochips Ltd. <www.einfochips.com>
+ * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
+ *
+ * (C) Copyright 2010
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _ASM_ARCH_GPIO_H
+#define _ASM_ARCH_GPIO_H
+
+#include <asm/types.h>
+#include <asm/arch/armada100.h>
+#include <mvgpio.h>
+
+#define GPIO_TO_REG(gp)		(gp >> 5)
+#define GPIO_TO_BIT(gp)		(1 << (gp & 0x1F))
+#define GPIO_VAL(gp, val)	((val >> (gp & 0x1F)) & 0x01)
+
+static inline void *get_gpio_base(int bank)
+{
+	const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register bank
+							    offset - refer
+							    Appendix A.36 */
+	return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
+}
+
+#endif /* _ASM_ARCH_GPIO_H */
-- 
1.7.0.4

[U-Boot] [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Wednesday, August 10, 2011 2:47 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ajay Bhargav
> Subject: [PATCH v4 2/2] gpio: Add GPIO driver for Marvell SoC Armada100
> 
> This patch adds support for generic GPIO driver framework for Marvell
> SoC Armada100.
> 
> v4 - updated gpio.h file, removed modification in Armada100.h

You are not following standard patch submission practice as indicated here http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

You need to document entire change history for each patch to be submitted below ---, this is important

> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/gpio.h |   47
> ++++++++++++++++++++++++++++
>  1 files changed, 47 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-armada100/gpio.h
> 
> diff --git a/arch/arm/include/asm/arch-armada100/gpio.h
> b/arch/arm/include/asm/arch-armada100/gpio.h
> new file mode 100644
> index 0000000..dd47832
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-armada100/gpio.h
> @@ -0,0 +1,47 @@
> +/*
> + * (C) Copyright 2011
> + * eInfochips Ltd. <www.einfochips.com>
> + * Written-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> + *
> + * (C) Copyright 2010
> + * Marvell Semiconductor <www.marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef _ASM_ARCH_GPIO_H
> +#define _ASM_ARCH_GPIO_H
> +
> +#include <asm/types.h>
> +#include <asm/arch/armada100.h>
> +#include <mvgpio.h>
> +
> +#define GPIO_TO_REG(gp)		(gp >> 5)
> +#define GPIO_TO_BIT(gp)		(1 << (gp & 0x1F))
> +#define GPIO_VAL(gp, val)	((val >> (gp & 0x1F)) & 0x01)
> +
> +static inline void *get_gpio_base(int bank)
> +{
> +	const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register
> bank
> +							    offset - refer
> +							    Appendix A.36 */

Wrong style for multiline comments, pls refer chapter-8 @
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/CodingStyle

Regards..
Prafulla . .