public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [PATCH 4/4] net: dsa: remove master santiy check
Date: Wed, 24 Feb 2021 20:03:03 +0100	[thread overview]
Message-ID: <26fc1808d00f3533e46f56dbed5d5c2a@walle.cc> (raw)
In-Reply-To: <20210224181938.lvzs3tbi3bxtva7d@skbuf>

Am 2021-02-24 19:19, schrieb Vladimir Oltean:
> On Wed, Feb 24, 2021 at 07:08:51PM +0100, Michael Walle wrote:
>> Am 2021-02-24 18:45, schrieb Vladimir Oltean:
>> > On Wed, Feb 24, 2021 at 06:29:39PM +0100, Michael Walle wrote:
>> > > What is the reason to remove that device in the first place? Like is
>> > > this really a valid scenario? I really don't know when a device is
>> > > removed and if its remove, will it still be there or is it rather
>> > > a hot-plug type and rebinding it won't work anyways.
>> >
>> > Did you get this to crash under any circumstance other than using the
>> > 'unbind' command?
>> 
>> Nope, thus I was curious about that comment in dsa_port_stop(). 
>> Someone
>> (Alex, Claudiu maybe?) must have something in mind when writing about 
>> it.
>> But I couldn't figure out in which case a device is removed.
> 
> I'm pretty sure that the checks that are in place now were once written
> so that the sandbox tests would pass. If they still do, we should be
> fine.

Ah.

> You can run the sandbox tests using:

Just if one is trying to follow this thread: you'll also need to
have the following series applied:
   https://patchwork.ozlabs.org/project/uboot/list/?series=229778

> make sandbox_defconfig NO_SDL=1
> make -j 8 NO_SDL=1
> ./u-boot -d ./arch/sandbox/dts/test.dtb

btw theres a shortcut for this "u-boot -T"

> setenv ethact swp0

"setenv ethact lan0" I guess

> ping 1.2.3.5
> ut dm dsa_probe
> ut dm dsa
> ut dm
> ut dm net_retry

Not more failures than without my patch.

-michael

  reply	other threads:[~2021-02-24 19:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 16:40 [PATCH 0/4] net: dsa: various fixes Michael Walle
2021-02-24 16:40 ` [PATCH 1/4] net: dsa: return early if there is no master Michael Walle
2021-02-25 19:12   ` Ramon Fried
2021-02-24 16:40 ` [PATCH 2/4] net: dsa: probe master device Michael Walle
2021-02-25 19:13   ` Ramon Fried
2021-02-24 16:40 ` [PATCH 3/4] net: dsa: remove NULL check for priv and platform data Michael Walle
2021-02-24 22:23   ` Vladimir Oltean
2021-02-25 19:14     ` Ramon Fried
2021-02-24 16:40 ` [PATCH 4/4] net: dsa: remove master santiy check Michael Walle
2021-02-24 17:11   ` Vladimir Oltean
2021-02-24 17:29     ` Michael Walle
2021-02-24 17:45       ` Vladimir Oltean
2021-02-24 18:08         ` Michael Walle
2021-02-24 18:19           ` Vladimir Oltean
2021-02-24 19:03             ` Michael Walle [this message]
2021-02-24 21:40               ` Vladimir Oltean
2021-02-24 22:25   ` Vladimir Oltean
2021-02-24 22:52   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26fc1808d00f3533e46f56dbed5d5c2a@walle.cc \
    --to=michael@walle.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox