From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [PATCH 4/4] net: dsa: remove master santiy check
Date: Wed, 24 Feb 2021 23:52:35 +0100 [thread overview]
Message-ID: <49f242512f3c8bf741ac5fc2526ed70e@walle.cc> (raw)
In-Reply-To: <20210224164042.21747-5-michael@walle.cc>
Am 2021-02-24 17:40, schrieb Michael Walle:
> Because we probe the master ourselves (and fail if there is no master),
> it is not possible that we don't have a master device.
>
> There is one catch though: device removal. We don't support that. It
> wasn't supported neither before this patch. Because the master device
> was only set in .pre_probe(), if a device was removed master_dev was a
> dangling pointer and transmitting a frame cause a panic. I don't see a
> good solution without having some sort of notify machanism when a
> udevice is removed.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
FWIW
Tested-by: Michael Walle <michael@walle.cc> [DSA unit tests]
prev parent reply other threads:[~2021-02-24 22:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:40 [PATCH 0/4] net: dsa: various fixes Michael Walle
2021-02-24 16:40 ` [PATCH 1/4] net: dsa: return early if there is no master Michael Walle
2021-02-25 19:12 ` Ramon Fried
2021-02-24 16:40 ` [PATCH 2/4] net: dsa: probe master device Michael Walle
2021-02-25 19:13 ` Ramon Fried
2021-02-24 16:40 ` [PATCH 3/4] net: dsa: remove NULL check for priv and platform data Michael Walle
2021-02-24 22:23 ` Vladimir Oltean
2021-02-25 19:14 ` Ramon Fried
2021-02-24 16:40 ` [PATCH 4/4] net: dsa: remove master santiy check Michael Walle
2021-02-24 17:11 ` Vladimir Oltean
2021-02-24 17:29 ` Michael Walle
2021-02-24 17:45 ` Vladimir Oltean
2021-02-24 18:08 ` Michael Walle
2021-02-24 18:19 ` Vladimir Oltean
2021-02-24 19:03 ` Michael Walle
2021-02-24 21:40 ` Vladimir Oltean
2021-02-24 22:25 ` Vladimir Oltean
2021-02-24 22:52 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f242512f3c8bf741ac5fc2526ed70e@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox