Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices

[Heiko Stuebner <heiko@sntech.de>]

Hi Kever,

Am Montag, 28. Oktober 2024, 09:39:27 CET schrieb Kever Yang:
> On 2024/10/26 10:39, Kever Yang wrote:
> > Hi Heiko,
> >
> >     I got a ci error for this patch:
> >
> > https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929839
> >
> > +Image 'simple-bin-spi' is missing external blobs and is 
> > non-functional: rockchip-tpl
> > +/binman/simple-bin-spi/mkimage/rockchip-tpl (rockchip-tpl):
> > +drivers/net/rtl8169.c:320:2: error: #warning cache-line size is 
> > larger than descriptor size [-Werror=cpp]
> > +  320 | #warning cache-line size is larger than descriptor size
> > +      |  ^~~~~~~
> > +cc1: all warnings being treated as errors
> 
> The other boards are using below Kconfig to fix this warning, which is 
> suggest by the driver:
> 
> CONFIG_SYS_HAS_NONCACHED_MEMORY=y
> 
>   307  * Warn if the cache-line size is larger than the descriptor size. 
> In such
>   308  * cases the driver will likely fail because the CPU needs to 
> flush the cache
>   309  * when requeuing RX buffers, therefore descriptors written by the 
> hardware
>   310  * may be discarded.
>   311 *
>   312  * This can be fixed by defining CONFIG_SYS_NONCACHED_MEMORY which 
> will cause
>   313  * the driver to allocate descriptors from a pool of non-cached 
> memory.
>   314 *
>   315  * Hardware maintain D-cache coherency in RISC-V architecture.

thanks so much for this pointer, I started looking into the issue
today, but your pointer made everything so much easier.

Thanks a lot
Heiko