[PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS

U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS
@ 2024-10-13 19:24 Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
                   ` (17 more replies)
  0 siblings, 18 replies; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Currently QNAP builds a series of RK3568- (and RK3588-) based NAS systems.
This series provides support for the 4-bay variant called TS433.

The whole series of devices is pretty similar so adding support for the
other variants will be pretty easy, once device-specific devicetrees land.

The cherry-picked dts patches landed in the 6.12-rc1 merge window in
the Linux kernel.

This currently goes on top of today's u-boot master.


Heiko Stuebner (17):
  arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433
  arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433
  arm64: dts: rockchip: enable uart0 on Qnap-TS433
  arm64: dts: rockchip: enable usb ports on Qnap-TS433
  arm64: dts: rockchip: add stdout path on Qnap-TS433
  arm64: dts: rockchip: enable sata1+2 on Qnap-TS433
  arm64: dts: rockchip: add board-aliases for Qnap-TS433
  arm64: dts: rockchip: add hdd leds to Qnap-TS433
  arm64: dts: rockchip: enable the tsadc on the Qnap-TS433
  arm64: dts: rockchip: add gpio-keys to Qnap-TS433
  arm64: dts: rockchip: define cpu-supply on the Qnap-TS433
  arm64: dts: rockchip: add missing pmic information on Qnap-TS433
  arm64: dts: rockchip: enable gpu on Qnap-TS433
  arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433
  arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433
  arm64: dts: rockchip: add product-data eeproms to QNAP TS433
  board: rockchip: add support for Qnap TS433 devices

Uwe Kleine-König (1):
  arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433

 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi    |   6 +
 arch/arm/mach-rockchip/rk3568/Kconfig         |  14 +
 board/qnap/ts433/Kconfig                      |  12 +
 board/qnap/ts433/MAINTAINERS                  |   8 +
 configs/qnap-ts433-rk3568_defconfig           |  86 +++
 doc/board/qnap/index.rst                      |   9 +
 doc/board/qnap/ts433.rst                      |  91 +++
 doc/board/rockchip/rockchip.rst               |   1 +
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 571 +++++++++++++++++-
 include/configs/qnap_ts433.h                  |  10 +
 10 files changed, 802 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
 create mode 100644 board/qnap/ts433/Kconfig
 create mode 100644 board/qnap/ts433/MAINTAINERS
 create mode 100644 configs/qnap-ts433-rk3568_defconfig
 create mode 100644 doc/board/qnap/index.rst
 create mode 100644 doc/board/qnap/ts433.rst
 create mode 100644 include/configs/qnap_ts433.h

-- 
2.45.2


^ permalink raw reply	[flat|nested] 41+ messages in thread

* [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-21  1:32   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433 Heiko Stuebner
                   ` (16 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Add the vcc3v3-supply regulator and its link to the pcie controllers.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-2-heiko@sntech.de

[ upstream commit: e0ec6d48226fb3d4df18895b56f0b7a94c0fe474 ]

(cherry picked from commit 59939b4343db08fa08098238160007e6ded72be9)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 6a998166003..07b4f095d76 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -12,6 +12,25 @@
 / {
 	model = "Qnap TS-433-4G NAS System 4-Bay";
 	compatible = "qnap,ts433", "rockchip,rk3568";
+
+	dc_12v: regulator-dc-12v {
+		compatible = "regulator-fixed";
+		regulator-name = "dc_12v";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+	};
+
+	vcc3v3_pcie: regulator-vcc3v3-pcie {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_pcie";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		enable-active-high;
+		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
+		vin-supply = <&dc_12v>;
+	};
 };
 
 &gmac0 {
@@ -62,9 +81,11 @@
 	status = "okay";
 };
 
+/* Connected to a JMicron AHCI SATA controller */
 &pcie3x1 {
 	/* The downstream dts has: rockchip,bifurcation, XXX: find out what this is about */
 	reset-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+	vpcie3v3-supply = <&vcc3v3_pcie>;
 	status = "okay";
 };
 
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The TS433 uses both pcie controllers for sata and the 2nd network
interface. Set the needed data-lanes in the pcie3 phy and enable
the second pcie controller, as well as remove the bifurcation comment.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-3-heiko@sntech.de

[ upstream commit: 0f5f87a1d602a33028522784eb005647fa1b5c11 ]

(cherry picked from commit 7d8f260e65cc84076ec9456954de0f136948a2c8)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 07b4f095d76..9bf9c3b65ca 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -78,17 +78,25 @@
 };
 
 &pcie30phy {
+	data-lanes = <1 2>;
 	status = "okay";
 };
 
 /* Connected to a JMicron AHCI SATA controller */
 &pcie3x1 {
-	/* The downstream dts has: rockchip,bifurcation, XXX: find out what this is about */
 	reset-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
 	vpcie3v3-supply = <&vcc3v3_pcie>;
 	status = "okay";
 };
 
+/* Connected to the 2.5G NIC for the upper network jack */
+&pcie3x2 {
+	num-lanes = <1>;
+	reset-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
+	vpcie3v3-supply = <&vcc3v3_pcie>;
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	max-frequency = <200000000>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:58   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
                   ` (14 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Uart0 is connected to an MCU on the board that handles system control
like the fan-speed. So far no driver for it is available though.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-4-heiko@sntech.de

[ upstream commit: 07ef8be476bebd77cba3ca4804be03cc0dba414f ]

(cherry picked from commit aaa5b1c4bd8f0e4327078d513f0eef05cb829bcf)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 9bf9c3b65ca..bc26f2e98c1 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -104,6 +104,14 @@
 	status = "okay";
 };
 
+/*
+ * Connected to an MCU, that provides access to more LEDs,
+ * buzzer, fan control and more.
+ */
+&uart0 {
+	status = "okay";
+};
+
 /*
  * Pins available on CN3 connector at TTL voltage level (3V3).
  * ,_  _.
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (2 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:58   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
                   ` (13 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Enable usb controllers and phys and add regulator infrastructure for the
usb ports on the TS433.

Of course there are no schematics available for the device, so the
regulator information comes from the vendor-devicetree with unknown
accuracy.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-5-heiko@sntech.de

[ upstream commit: d992203f57c5caad0dbd4a9c669d79b315873c81 ]

(cherry picked from commit bb745ef13efb9f6589f9eda8f66664bf263a13f3)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 105 ++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index bc26f2e98c1..da735c4764f 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -31,6 +31,49 @@
 		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
 		vin-supply = <&dc_12v>;
 	};
+
+	vcc5v0_host: regulator-vcc5v0-host {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vcc5v0_host_en>;
+		gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
+		regulator-name = "vcc5v0_host";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc5v0_usb>;
+	};
+
+	vcc5v0_otg: regulator-vcc5v0-otg {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vcc5v0_otg_en>;
+		regulator-name = "vcc5v0_otg";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc5v0_usb>;
+	};
+
+	vcc5v0_usb: regulator-vcc5v0-usb {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_usb";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&dc_12v>;
+	};
+};
+
+/* connected to usb_host0_xhci */
+&combphy0 {
+	status = "okay";
 };
 
 &gmac0 {
@@ -97,6 +140,18 @@
 	status = "okay";
 };
 
+&pinctrl {
+	usb {
+		vcc5v0_host_en: vcc5v0-host-en {
+			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+
+		vcc5v0_otg_en: vcc5v0-otg-en {
+			rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
 &sdhci {
 	bus-width = <8>;
 	max-frequency = <200000000>;
@@ -121,3 +176,53 @@
 &uart2 {
 	status = "okay";
 };
+
+&usb2phy0 {
+	status = "okay";
+};
+
+/* connected to usb_host0_xhci */
+&usb2phy0_otg {
+	phy-supply = <&vcc5v0_otg>;
+	status = "okay";
+};
+
+&usb2phy1 {
+	status = "okay";
+};
+
+/* connected to usb_host1_ehci/ohci */
+&usb2phy1_host {
+	phy-supply = <&vcc5v0_host>;
+	status = "okay";
+};
+
+/* connected to usb_host0_ehci/ohci */
+&usb2phy1_otg {
+	phy-supply = <&vcc5v0_host>;
+	status = "okay";
+};
+
+/* right port backside */
+&usb_host0_ehci {
+	status = "okay";
+};
+
+&usb_host0_ohci {
+	status = "okay";
+};
+
+/* front port */
+&usb_host0_xhci {
+	dr_mode = "host";
+	status = "okay";
+};
+
+/* left port backside */
+&usb_host1_ehci {
+	status = "okay";
+};
+
+&usb_host1_ohci {
+	status = "okay";
+};
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 05/18] arm64: dts: rockchip: add stdout path on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (3 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:58   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
                   ` (12 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

As most Rockchip boards do, the TS433 also uses uart2 for its serial
output. Set the correct chosen entry for it.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-6-heiko@sntech.de

[ upstream commit: e1cb5d8a92e41171bf4d5ddc459bd96372500901 ]

(cherry picked from commit 1e1af2af2192490a3d174624ac1bb976aa6afffa)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index da735c4764f..be1c2286c2d 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -13,6 +13,10 @@
 	model = "Qnap TS-433-4G NAS System 4-Bay";
 	compatible = "qnap,ts433", "rockchip,rk3568";
 
+	chosen {
+		stdout-path = "serial2:115200n8";
+	};
+
 	dc_12v: regulator-dc-12v {
 		compatible = "regulator-fixed";
 		regulator-name = "dc_12v";
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (4 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:58   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
                   ` (11 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The TS433 has 4 bays. The last two are accessed via a pci-connected
sata controller, while the first two are accessed via the rk3568's
sata controllers. Enable these two now.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-7-heiko@sntech.de

[ upstream commit: 673c1353b3d476b9c5df6b84a777ed171e5594f5 ]

(cherry picked from commit dfa45bbda057851d0c2167b4c311c0301637cc19)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index be1c2286c2d..40af4dd0e41 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -80,6 +80,16 @@
 	status = "okay";
 };
 
+/* connected to sata1 */
+&combphy1 {
+	status = "okay";
+};
+
+/* connected to sata2 */
+&combphy2 {
+	status = "okay";
+};
+
 &gmac0 {
 	assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
 	assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>;
@@ -156,6 +166,14 @@
 	};
 };
 
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	max-frequency = <200000000>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (5 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:58   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
                   ` (10 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Add the aliases for the internal network interface as well as the emmc
on the board and make sure the dedicated RTC is always the first one.

The TS433 actually has two rtc devices. One coming from the rk809 pmic
without added functionality and also a dedicated RTC from Mycrocrystal
that is battery backed to keep the time.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-8-heiko@sntech.de

[ upstream commit: dadd4256e12360d3ff1f6481b2e4697f9d890caf ]

(cherry picked from commit cb53815764403f7f17967a32eec2aeb6625b396f)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 40af4dd0e41..8be36250aa1 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -13,6 +13,12 @@
 	model = "Qnap TS-433-4G NAS System 4-Bay";
 	compatible = "qnap,ts433", "rockchip,rk3568";
 
+	aliases {
+		ethernet0 = &gmac0;
+		mmc0 = &sdhci;
+		rtc0 = &rtc_rv8263;
+	};
+
 	chosen {
 		stdout-path = "serial2:115200n8";
 	};
@@ -120,7 +126,7 @@
 &i2c1 {
 	status = "okay";
 
-	rtc@51 {
+	rtc_rv8263: rtc@51 {
 		compatible = "microcrystal,rv8263";
 		reg = <0x51>;
 		wakeup-source;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (6 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
                   ` (9 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Add the 4 gpio-controlled LEDs to the Qnap-TS433.

They are meant for individual disk activitivy, but I haven't found a
way for how to connect them to their individual sata slot yet.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-9-heiko@sntech.de

[ upstream commit: ea91aabf18bcad6f5eceae6848ea6570ea61f126 ]

(cherry picked from commit 5a11b1bb40ac7b39e04077c045c3e3409fa352e2)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 8be36250aa1..abeb00add42 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/gpio/gpio.h>
 #include "rk3568.dtsi"
 
@@ -23,6 +24,46 @@
 		stdout-path = "serial2:115200n8";
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led-0 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_DISK;
+			gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "disk-activity";
+			pinctrl-names = "default";
+			pinctrl-0 = <&hdd1_led_pin>;
+		};
+
+		led-1 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_DISK;
+			gpios = <&gpio1 RK_PD6 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "disk-activity";
+			pinctrl-names = "default";
+			pinctrl-0 = <&hdd2_led_pin>;
+		};
+
+		led-2 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_DISK;
+			gpios = <&gpio1 RK_PD7 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "disk-activity";
+			pinctrl-names = "default";
+			pinctrl-0 = <&hdd3_led_pin>;
+		};
+
+		led-3 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_DISK;
+			gpios = <&gpio2 RK_PA0 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "disk-activity";
+			pinctrl-names = "default";
+			pinctrl-0 = <&hdd4_led_pin>;
+		};
+	};
+
 	dc_12v: regulator-dc-12v {
 		compatible = "regulator-fixed";
 		regulator-name = "dc_12v";
@@ -161,6 +202,24 @@
 };
 
 &pinctrl {
+	leds {
+		hdd1_led_pin: hdd1-led-pin {
+			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		hdd2_led_pin: hdd2-led-pin {
+			rockchip,pins = <1 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		hdd3_led_pin: hdd3-led-pin {
+			rockchip,pins = <1 RK_PD7 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		hdd4_led_pin: hdd4_led-pin {
+			rockchip,pins = <2 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	usb {
 		vcc5v0_host_en: vcc5v0-host-en {
 			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (7 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
                   ` (8 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Enable the tsadc node to allow for temperature measurements of the soc.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-10-heiko@sntech.de

[ upstream commit: 2dfdddd9d20306fd0d04b88fcbbf36d76fb67f11 ]

(cherry picked from commit d33949501abd1145ea572b605844f0ef4247478d)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index abeb00add42..34fc31ea9a3 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -246,6 +246,12 @@
 	status = "okay";
 };
 
+&tsadc {
+	rockchip,hw-tshut-mode = <1>;
+	rockchip,hw-tshut-polarity = <0>;
+	status = "okay";
+};
+
 /*
  * Connected to an MCU, that provides access to more LEDs,
  * buzzer, fan control and more.
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (8 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
                   ` (7 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The TS433 has 3 buttons, power and copy in the front as well as a reset
pinhole button on the back. The power-button is connected to the embedded
controller while the other two buttons are just gpio connected.

Add the gpio-keys definition for the two buttons we can handle right now.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-11-heiko@sntech.de

[ upstream commit: 9b682d31b24f1f70b5b4d0618095d46e0722b9d8 ]

(cherry picked from commit f0b858c751382ee9faf18f9b19b0817c6b50ac1c)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 34fc31ea9a3..9f964b6f411 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/leds/common.h>
 #include <dt-bindings/gpio/gpio.h>
 #include "rk3568.dtsi"
@@ -24,6 +25,24 @@
 		stdout-path = "serial2:115200n8";
 	};
 
+	keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&copy_button_pin>, <&reset_button_pin>;
+		pinctrl-names = "default";
+
+		key-copy {
+			label = "copy";
+			gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_COPY>;
+		};
+
+		key-reset {
+			label = "reset";
+			gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_RESTART>;
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -202,6 +221,16 @@
 };
 
 &pinctrl {
+	keys {
+		copy_button_pin: copy-button-pin {
+			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		reset_button_pin: reset-button-pin {
+			rockchip,pins = <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	leds {
 		hdd1_led_pin: hdd1-led-pin {
 			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (9 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
                   ` (6 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The TS433 seems to use a silergy,syr827 regulator for the cpu supply.
At least that is the compatible used in the vendor devicetree, though
it could very well also be another fan53555 clone.

Define the needed regulator node and hook up the cpu-supply to the
cpu cores.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-12-heiko@sntech.de

[ upstream commit: 99b36ba910d896bddbb9a190ca686c6d9cd0325f ]

(cherry picked from commit 2f0afd1a3cbf6f3192dc7a5c496affab718671b3)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 9f964b6f411..4bccefc0537 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -130,6 +130,16 @@
 		vin-supply = <&vcc5v0_usb>;
 	};
 
+	vcc5v0_sys: regulator-vcc5v0-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&dc_12v>;
+	};
+
 	vcc5v0_usb: regulator-vcc5v0-usb {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc5v0_usb";
@@ -156,6 +166,22 @@
 	status = "okay";
 };
 
+&cpu0 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu1 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu2 {
+	cpu-supply = <&vdd_cpu>;
+};
+
+&cpu3 {
+	cpu-supply = <&vdd_cpu>;
+};
+
 &gmac0 {
 	assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
 	assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>;
@@ -175,12 +201,27 @@
 };
 
 &i2c0 {
+	status = "okay";
+
 	pmic@20 {
 		compatible = "rockchip,rk809";
 		reg = <0x20>;
 		interrupt-parent = <&gpio0>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 	};
+
+	vdd_cpu: regulator@40 {
+		compatible = "silergy,syr827";
+		reg = <0x40>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_cpu";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <712500>;
+		regulator-max-microvolt = <1390000>;
+		regulator-ramp-delay = <2300>;
+		vin-supply = <&vcc5v0_sys>;
+	};
 };
 
 &i2c1 {
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (10 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
                   ` (5 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Fill in the missing pieces for RK809 pmic used on the TS433.

The regulator setup comes from the vendor-devicetree, so without proper
schematics its accuracy is somewhat unclear, but it looks really similar
to all the other rk3568 boards, so follows the reference design it seems.

The one caveat is related to vcc3v3_sd. This regulator needs to stay on.
When turned off because of no users, access to both PCIe controllers
will stall. Maybe this rail does supply the 100MHz refclk generation
or so.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-13-heiko@sntech.de

[ upstream commit: ee078c7daa98353496410b715a5acbb41d7d3a90 ]

(cherry picked from commit 48951cb085998a5c8e3650351a794b136dac648f)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 227 +++++++++++++++++-
 1 file changed, 226 insertions(+), 1 deletion(-)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 4bccefc0537..b807da6e850 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -102,6 +102,16 @@
 		vin-supply = <&dc_12v>;
 	};
 
+	vcc3v3_sys: regulator-vcc3v3-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&dc_12v>;
+	};
+
 	vcc5v0_host: regulator-vcc5v0-host {
 		compatible = "regulator-fixed";
 		enable-active-high;
@@ -207,7 +217,216 @@
 		compatible = "rockchip,rk809";
 		reg = <0x20>;
 		interrupt-parent = <&gpio0>;
-		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
+		#clock-cells = <1>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_int_l>;
+		system-power-controller;
+		vcc1-supply = <&vcc3v3_sys>;
+		vcc2-supply = <&vcc3v3_sys>;
+		vcc3-supply = <&vcc3v3_sys>;
+		vcc4-supply = <&vcc3v3_sys>;
+		vcc5-supply = <&vcc3v3_sys>;
+		vcc6-supply = <&vcc3v3_sys>;
+		vcc7-supply = <&vcc3v3_sys>;
+		vcc8-supply = <&vcc3v3_sys>;
+		vcc9-supply = <&vcc3v3_sys>;
+		wakeup-source;
+
+		regulators {
+			vdd_logic: DCDC_REG1 {
+				regulator-name = "vdd_logic";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-ramp-delay = <6001>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdd_gpu: DCDC_REG2 {
+				regulator-name = "vdd_gpu";
+				regulator-always-on;
+				regulator-initial-mode = <0x2>;
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-ramp-delay = <6001>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_ddr: DCDC_REG3 {
+				regulator-name = "vcc_ddr";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+
+			vdd_npu: DCDC_REG4 {
+				regulator-name = "vdd_npu";
+				regulator-initial-mode = <0x2>;
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-ramp-delay = <6001>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_1v8: DCDC_REG5 {
+				regulator-name = "vcc_1v8";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdda0v9_image: LDO_REG1 {
+				regulator-name = "vdda0v9_image";
+				regulator-always-on;
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <900000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdda_0v9: LDO_REG2 {
+				regulator-name = "vdda_0v9";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <900000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdda0v9_pmu: LDO_REG3 {
+				regulator-name = "vdda0v9_pmu";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <900000>;
+
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <900000>;
+				};
+			};
+
+			vccio_acodec: LDO_REG4 {
+				regulator-name = "vccio_acodec";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vccio_sd: LDO_REG5 {
+				regulator-name = "vccio_sd";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc3v3_pmu: LDO_REG6 {
+				regulator-name = "vcc3v3_pmu";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <3300000>;
+				};
+			};
+
+			vcca_1v8: LDO_REG7 {
+				regulator-name = "vcca_1v8";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcca1v8_pmu: LDO_REG8 {
+				regulator-name = "vcca1v8_pmu";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcca1v8_image: LDO_REG9 {
+				regulator-name = "vcca1v8_image";
+				regulator-always-on;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_3v3: SWITCH_REG1 {
+				regulator-name = "vcc_3v3";
+				regulator-always-on;
+				regulator-boot-on;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc3v3_sd: SWITCH_REG2 {
+				regulator-name = "vcc3v3_sd";
+				/*
+				 * turning this off, breaks access to both
+				 * PCIe controllers, refclk generator perhaps
+				 */
+				regulator-always-on;
+				regulator-boot-on;
+
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+		};
 	};
 
 	vdd_cpu: regulator@40 {
@@ -290,6 +509,12 @@
 		};
 	};
 
+	pmic {
+		pmic_int_l: pmic-int-l {
+			rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	usb {
 		vcc5v0_host_en: vcc5v0-host-en {
 			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 13/18] arm64: dts: rockchip: enable gpu on Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (11 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 11:59   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
                   ` (4 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The TS433 doesn't provide display output, but the gpu nevertheless can be
used for compute tasks for example.

So there is no reason not to enable it.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-14-heiko@sntech.de

[ upstream commit: 9130eb62586f4cef0557d0378fb7e78d7397ab2d ]

(cherry picked from commit e324a9e8ea083ebdca207b5ca2ed86d2b5f862a0)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index b807da6e850..9a0cb69c3cf 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -210,6 +210,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &i2c0 {
 	status = "okay";
 
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (12 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 12:00   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433 Heiko Stuebner
                   ` (3 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Add the two supplies for the pmu-io-domains that are defined in the
vendor devicetree for the TS433.

Tested-by: Uwe Kleine-König <ukleinek@debian.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240723195538.1133436-15-heiko@sntech.de

[ upstream commit: 64b7f16fb3947e5d08d9e9b860ce966250e45d52 ]

(cherry picked from commit 9b4d4c02b5762196063ab03c5439f96cbbaf2485)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 9a0cb69c3cf..6c4269b3d95 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -531,6 +531,11 @@
 	};
 };
 
+&pmu_io_domains {
+	vccio4-supply = <&vcc_1v8>;
+	vccio6-supply = <&vcc_1v8>;
+};
+
 &sata1 {
 	status = "okay";
 };
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (13 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 12:00   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains " Heiko Stuebner
                   ` (2 subsequent siblings)
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek, Andrew Lunn

From: Uwe Kleine-König <ukleinek@debian.org>

While it requires to have the right phy driver loaded (i.e. motorcomm)
to make the phy asserting the right delays, this is generally the
preferred way to define the MAC <-> PHY connection.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240304084612.711678-2-ukleinek@debian.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

[ upstream commit: e8d45544f806f3b55c30345de84262cbb9504902 ]

(cherry picked from commit e0bbe061fd537bd7b113c53eb046bbcbf0e6597d)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 6c4269b3d95..20e4fa6c185 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -198,15 +198,13 @@
 	assigned-clock-rates = <0>, <125000000>;
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
 		     &gmac0_rx_bus2
 		     &gmac0_rgmii_clk
 		     &gmac0_rgmii_bus>;
-	rx_delay = <0x2f>;
-	tx_delay = <0x3c>;
 	status = "okay";
 };
 
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (14 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 12:00   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
  2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

Contrary to the vendor-kernel the pmu-io-domains are not enabled by
default. This resulted in the value not being set according to the
regulator, which in turn made the gmac0 interface that is connected
to the vccio4 supply inoperable.

Fixes: 64b7f16fb394 ("arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240805162052.3345768-1-heiko@sntech.de

[ upstream commit: 40cc4257169712f0ae3835820a4c5afbdd1a16ff ]

(cherry picked from commit f509fcb1fb82117e551b489592ac5714a6c5cd8d)
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 20e4fa6c185..90d8d526629 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -532,6 +532,7 @@
 &pmu_io_domains {
 	vccio4-supply = <&vcc_1v8>;
 	vccio6-supply = <&vcc_1v8>;
+	status = "okay";
 };
 
 &sata1 {
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (15 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains " Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 12:00   ` Kever Yang
  2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
  17 siblings, 1 reply; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The device contains two i2c-connected eeproms holding some product-
specific values. One sitting on the mainboard and one on the statically
connected backplane.

While the eeprom chips themself have a size of 512 byte, the eeprom data
only uses 256 byte each, probably to stay compatible with other models.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240810211438.286441-3-heiko@sntech.de

[ upstream commit: da6f4130234448122fe3e66c8116f7d9eea8a5c7 ]

(cherry picked from commit 0b3109708caf5002ba188ae28eae9ce46b2c39b4)
---
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 90d8d526629..e601d9271ba 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -454,6 +454,26 @@
 		reg = <0x51>;
 		wakeup-source;
 	};
+
+	/* eeprom for vital-product-data on the mainboard */
+	eeprom@54 {
+		compatible = "giantec,gt24c04a", "atmel,24c04";
+		reg = <0x54>;
+		label = "VPD_MB";
+		num-addresses = <2>;
+		pagesize = <16>;
+		read-only;
+	};
+
+	/* eeprom for vital-product-data on the backplane */
+	eeprom@56 {
+		compatible = "giantec,gt24c04a", "atmel,24c04";
+		reg = <0x56>;
+		label = "VPD_BP";
+		num-addresses = <2>;
+		pagesize = <16>;
+		read-only;
+	};
 };
 
 &mdio0 {
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
                   ` (16 preceding siblings ...)
  2024-10-13 19:24 ` [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
@ 2024-10-13 19:24 ` Heiko Stuebner
  2024-10-25 12:01   ` Kever Yang
                     ` (2 more replies)
  17 siblings, 3 replies; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-13 19:24 UTC (permalink / raw)
  To: u-boot, kever.yang, philipp.tomsich, sjg; +Cc: heiko, ukleinek

The Qnap TS433 is a 4-bay NAS based around the RK3568.

Two SATA bays are connected to the RK3568's own SATA controllers while
the other two are connected to a JMicron SATA controller living on the
PCIe bus.

It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
 arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
 board/qnap/ts433/Kconfig                   | 12 +++
 board/qnap/ts433/MAINTAINERS               |  8 ++
 configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
 doc/board/qnap/index.rst                   |  9 +++
 doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++
 doc/board/rockchip/rockchip.rst            |  1 +
 include/configs/qnap_ts433.h               | 10 +++
 9 files changed, 237 insertions(+)
 create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
 create mode 100644 board/qnap/ts433/Kconfig
 create mode 100644 board/qnap/ts433/MAINTAINERS
 create mode 100644 configs/qnap-ts433-rk3568_defconfig
 create mode 100644 doc/board/qnap/index.rst
 create mode 100644 doc/board/qnap/ts433.rst
 create mode 100644 include/configs/qnap_ts433.h

diff --git a/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
new file mode 100644
index 00000000000..19acbceb468
--- /dev/null
+++ b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2024 Heiko Stuebner <heiko@sntech.de>
+ */
+
+#include "rk356x-u-boot.dtsi"
diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig b/arch/arm/mach-rockchip/rk3568/Kconfig
index 899cf909fbb..2a0fd40874e 100644
--- a/arch/arm/mach-rockchip/rk3568/Kconfig
+++ b/arch/arm/mach-rockchip/rk3568/Kconfig
@@ -27,6 +27,19 @@ config TARGET_POWKIDDY_X55_RK3566
 	help
 	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
 
+config TARGET_QNAP_TS433_RK3568
+	bool "QNAP-TS433"
+	help
+	  Qnap TS433 4-bay NAS with a RK3568 SoC.
+
+	  It provides the following featureset:
+	   * 4GB LPDDR4
+	   * 4GB eMMC
+	   * 2 SATA ports connected to two RK3568's SATA controllers
+	   * 2 SATA ports connected to a JMicron JMB58x AHCI SATA controller
+	   * 1 1G network controller
+	   * 1 2.5G Realtek RTL8125 network controller
+
 config TARGET_QUARTZ64_RK3566
 	bool "Pine64 Quartz64"
 	help
@@ -64,6 +77,7 @@ source "board/anbernic/rgxx3_rk3566/Kconfig"
 source "board/hardkernel/odroid_m1/Kconfig"
 source "board/pine64/quartz64_rk3566/Kconfig"
 source "board/powkiddy/x55/Kconfig"
+source "board/qnap/ts433/Kconfig"
 source "board/radxa/zero3-rk3566/Kconfig"
 source "board/xunlong/orangepi-3b-rk3566/Kconfig"
 
diff --git a/board/qnap/ts433/Kconfig b/board/qnap/ts433/Kconfig
new file mode 100644
index 00000000000..b00e1f9f2ef
--- /dev/null
+++ b/board/qnap/ts433/Kconfig
@@ -0,0 +1,12 @@
+if TARGET_QNAP_TS433_RK3568
+
+config SYS_BOARD
+	default "qnap_ts433"
+
+config SYS_VENDOR
+	default "qnap"
+
+config SYS_CONFIG_NAME
+	default "qnap_ts433"
+
+endif
diff --git a/board/qnap/ts433/MAINTAINERS b/board/qnap/ts433/MAINTAINERS
new file mode 100644
index 00000000000..c2b31ad9794
--- /dev/null
+++ b/board/qnap/ts433/MAINTAINERS
@@ -0,0 +1,8 @@
+QNAP-TS433
+M:	Heiko Stuebner <heiko@sntech.de>
+S:	Maintained
+F:	board/qnap/ts433/
+F:	doc/board/qnap/
+F:	include/configs/qnap_ts433.h
+F:	configs/qnap-ts433-rk3568_defconfig
+F:	arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
diff --git a/configs/qnap-ts433-rk3568_defconfig b/configs/qnap-ts433-rk3568_defconfig
new file mode 100644
index 00000000000..cbe4622e468
--- /dev/null
+++ b/configs/qnap-ts433-rk3568_defconfig
@@ -0,0 +1,86 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_COUNTER_FREQUENCY=24000000
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-qnap-ts433"
+CONFIG_ROCKCHIP_RK3568=y
+CONFIG_SPL_SERIAL=y
+CONFIG_TARGET_QNAP_TS433_RK3568=y
+CONFIG_DEBUG_UART_BASE=0xFE660000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_SYS_LOAD_ADDR=0xc00800
+CONFIG_PCI=y
+CONFIG_DEBUG_UART=y
+CONFIG_AHCI=y
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_SPL_FIT_SIGNATURE=y
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_LEGACY_IMAGE_FORMAT=y
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-qnap-ts433.dtb"
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_MAX_SIZE=0x40000
+CONFIG_SPL_PAD_TO=0x7f8000
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+CONFIG_SPL_ATF=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_ROCKUSB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y
+CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_SPL_DM_SEQ_ALIAS=y
+CONFIG_SPL_REGMAP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_AHCI_PCI=y
+CONFIG_DWC_AHCI=y
+CONFIG_SPL_CLK=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_LED=y
+CONFIG_LED_GPIO=y
+CONFIG_MISC=y
+CONFIG_SUPPORT_EMMC_RPMB=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_DWC_ETH_QOS=y
+CONFIG_DWC_ETH_QOS_ROCKCHIP=y
+CONFIG_RTL8169=y
+CONFIG_PCIE_DW_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
+CONFIG_SPL_PINCTRL=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_FAN53555=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_SPL_RAM=y
+CONFIG_SCSI=y
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550_MEM32=y
+CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y
+CONFIG_ERRNO_STR=y
diff --git a/doc/board/qnap/index.rst b/doc/board/qnap/index.rst
new file mode 100644
index 00000000000..652ea11a056
--- /dev/null
+++ b/doc/board/qnap/index.rst
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Qnap
+====
+
+.. toctree::
+   :maxdepth: 2
+
+   ts433.rst
diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
new file mode 100644
index 00000000000..5c7fd314b7a
--- /dev/null
+++ b/doc/board/qnap/ts433.rst
@@ -0,0 +1,91 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+U-Boot for Qnap TS433 Devices
+=================================
+
+This allows U-Boot to boot the Qnap TS433 NAS
+
+Preparing the serial
+--------------------
+
+Qnap devices run their serial console with a 115200 baudrate. As the
+binary DDR-init and maskrom-downloader expect a 1500000 rate, it is
+necessary to adapt the binaries if their output is needed.
+
+This can be done with a binary provided in the rkbin repository.
+First the ddrbin_param.txt in the rkbin repo needs to be modified:
+
+.. code-block:: bash
+
+    diff --git a/tools/ddrbin_param.txt b/tools/ddrbin_param.txt
+    index 0dfdd318..82ade7e7 100644
+    --- a/tools/ddrbin_param.txt
+    +++ b/tools/ddrbin_param.txt
+    @@ -11,7 +11,7 @@ lp5_freq=
+
+     uart id=
+     uart iomux=
+    -uart baudrate=
+    +uart baudrate=115200
+
+     sr_idle=
+     pd_idle=
+
+And after that the ddrbin_tool binary can be used to modify apply this
+modification and also a new maskrom downloader can be build:
+
+.. code-block:: bash
+
+    $ tools/ddrbin_tool rk3568 tools/ddrbin_param.txt bin/rk35/rk3568_ddr_1560MHz_v1.21.bin
+    $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
+
+Building U-Boot
+---------------
+
+.. code-block:: bash
+
+    $ export CROSS_COMPILE=aarch64-linux-gnu-
+    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
+    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin
+    $ make qnap-ts433-rk3568_defconfig
+    $ make
+
+This will build ``u-boot-rockchip.bin`` which can be written to the
+on-board eMMC.
+
+Image installation
+------------------
+
+The Qnap thankfully provides an easily accessible serial header as well as
+a very user-friendly jumper-header to bring the device into maskrom mode.
+
+To access both, the drive trays need to be removed. Looking at the board,
+through the upper cutout of the metal frame the white 4-port serial-header
+can be seen next to a barcode sticker. It's pinout is as follows:
+
+.. code-block:: bash
+
+   ,_  _.
+   |1234|  1=TX 2=VCC
+   `----'  3=RX 4=GND
+
+
+Directly below it, the mentioned 2-pin jumper header can be seen.
+
+To write your u-boot to the device, it needs to be powered off first. Then
+a jumper or suitable cable needs to be used to connect the two pins of the
+maskrom header. Turning on the device now will start it in maskrom mode.
+
+It is important that the jumper gets removed after that stop and before
+actually trying to write to the emmc.
+
+The front usb-port needs to be connected to the host with an USB-A-to-A
+cable to allow flashing.
+
+The flashing itself is done via rkdeveloptool, which can be found for
+example as package of that name in Debian-based distributions:
+
+.. code-block:: bash
+
+    $ rkdeveloptool db rk356x_spl_loader_v1.21.113.bin
+    $ rkdeveloptool wl 64 u-boot-rockchip.bin
diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
index 86d83befb5b..a0349d3ad56 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -118,6 +118,7 @@ List of mainline supported Rockchip boards:
      - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
      - Generic RK3566/RK3568 (generic-rk3568)
      - Hardkernel ODROID-M1 (odroid-m1-rk3568)
+     - QNAP TS-433 (qnap-ts433-rk3568)
      - Radxa E25 Carrier Board (radxa-e25-rk3568)
      - Radxa ROCK 3A (rock-3a-rk3568)
      - Radxa ROCK 3B (rock-3b-rk3568)
diff --git a/include/configs/qnap_ts433.h b/include/configs/qnap_ts433.h
new file mode 100644
index 00000000000..aee4546bf07
--- /dev/null
+++ b/include/configs/qnap_ts433.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __QNAP_TS433_H
+#define __QNAP_TS433_H
+
+#define ROCKCHIP_DEVICE_SETTINGS
+
+#include <configs/rk3568_common.h>
+
+#endif
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
@ 2024-10-21  1:32   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-21  1:32 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Add the vcc3v3-supply regulator and its link to the pcie controllers.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-2-heiko@sntech.de
>
> [ upstream commit: e0ec6d48226fb3d4df18895b56f0b7a94c0fe474 ]
>
> (cherry picked from commit 59939b4343db08fa08098238160007e6ded72be9)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 21 +++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 6a998166003..07b4f095d76 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -12,6 +12,25 @@
>   / {
>   	model = "Qnap TS-433-4G NAS System 4-Bay";
>   	compatible = "qnap,ts433", "rockchip,rk3568";
> +
> +	dc_12v: regulator-dc-12v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "dc_12v";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
> +	};
> +
> +	vcc3v3_pcie: regulator-vcc3v3-pcie {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3_pcie";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		enable-active-high;
> +		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&dc_12v>;
> +	};
>   };
>   
>   &gmac0 {
> @@ -62,9 +81,11 @@
>   	status = "okay";
>   };
>   
> +/* Connected to a JMicron AHCI SATA controller */
>   &pcie3x1 {
>   	/* The downstream dts has: rockchip,bifurcation, XXX: find out what this is about */
>   	reset-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
> +	vpcie3v3-supply = <&vcc3v3_pcie>;
>   	status = "okay";
>   };
>   

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:58   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:58 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Uart0 is connected to an MCU on the board that handles system control
> like the fan-speed. So far no driver for it is available though.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-4-heiko@sntech.de
>
> [ upstream commit: 07ef8be476bebd77cba3ca4804be03cc0dba414f ]
>
> (cherry picked from commit aaa5b1c4bd8f0e4327078d513f0eef05cb829bcf)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 9bf9c3b65ca..bc26f2e98c1 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -104,6 +104,14 @@
>   	status = "okay";
>   };
>   
> +/*
> + * Connected to an MCU, that provides access to more LEDs,
> + * buzzer, fan control and more.
> + */
> +&uart0 {
> +	status = "okay";
> +};
> +
>   /*
>    * Pins available on CN3 connector at TTL voltage level (3V3).
>    * ,_  _.

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
@ 2024-10-25 11:58   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:58 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Enable usb controllers and phys and add regulator infrastructure for the
> usb ports on the TS433.
>
> Of course there are no schematics available for the device, so the
> regulator information comes from the vendor-devicetree with unknown
> accuracy.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-5-heiko@sntech.de
>
> [ upstream commit: d992203f57c5caad0dbd4a9c669d79b315873c81 ]
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
>
> (cherry picked from commit bb745ef13efb9f6589f9eda8f66664bf263a13f3)
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 105 ++++++++++++++++++
>   1 file changed, 105 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index bc26f2e98c1..da735c4764f 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -31,6 +31,49 @@
>   		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
>   		vin-supply = <&dc_12v>;
>   	};
> +
> +	vcc5v0_host: regulator-vcc5v0-host {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc5v0_host_en>;
> +		gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
> +		regulator-name = "vcc5v0_host";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&vcc5v0_usb>;
> +	};
> +
> +	vcc5v0_otg: regulator-vcc5v0-otg {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc5v0_otg_en>;
> +		regulator-name = "vcc5v0_otg";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&vcc5v0_usb>;
> +	};
> +
> +	vcc5v0_usb: regulator-vcc5v0-usb {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_usb";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&dc_12v>;
> +	};
> +};
> +
> +/* connected to usb_host0_xhci */
> +&combphy0 {
> +	status = "okay";
>   };
>   
>   &gmac0 {
> @@ -97,6 +140,18 @@
>   	status = "okay";
>   };
>   
> +&pinctrl {
> +	usb {
> +		vcc5v0_host_en: vcc5v0-host-en {
> +			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		vcc5v0_otg_en: vcc5v0-otg-en {
> +			rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
>   &sdhci {
>   	bus-width = <8>;
>   	max-frequency = <200000000>;
> @@ -121,3 +176,53 @@
>   &uart2 {
>   	status = "okay";
>   };
> +
> +&usb2phy0 {
> +	status = "okay";
> +};
> +
> +/* connected to usb_host0_xhci */
> +&usb2phy0_otg {
> +	phy-supply = <&vcc5v0_otg>;
> +	status = "okay";
> +};
> +
> +&usb2phy1 {
> +	status = "okay";
> +};
> +
> +/* connected to usb_host1_ehci/ohci */
> +&usb2phy1_host {
> +	phy-supply = <&vcc5v0_host>;
> +	status = "okay";
> +};
> +
> +/* connected to usb_host0_ehci/ohci */
> +&usb2phy1_otg {
> +	phy-supply = <&vcc5v0_host>;
> +	status = "okay";
> +};
> +
> +/* right port backside */
> +&usb_host0_ehci {
> +	status = "okay";
> +};
> +
> +&usb_host0_ohci {
> +	status = "okay";
> +};
> +
> +/* front port */
> +&usb_host0_xhci {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
> +/* left port backside */
> +&usb_host1_ehci {
> +	status = "okay";
> +};
> +
> +&usb_host1_ohci {
> +	status = "okay";
> +};

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 05/18] arm64: dts: rockchip: add stdout path on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
@ 2024-10-25 11:58   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:58 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> As most Rockchip boards do, the TS433 also uses uart2 for its serial
> output. Set the correct chosen entry for it.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-6-heiko@sntech.de
>
> [ upstream commit: e1cb5d8a92e41171bf4d5ddc459bd96372500901 ]
>
> (cherry picked from commit 1e1af2af2192490a3d174624ac1bb976aa6afffa)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index da735c4764f..be1c2286c2d 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -13,6 +13,10 @@
>   	model = "Qnap TS-433-4G NAS System 4-Bay";
>   	compatible = "qnap,ts433", "rockchip,rk3568";
>   
> +	chosen {
> +		stdout-path = "serial2:115200n8";
> +	};
> +
>   	dc_12v: regulator-dc-12v {
>   		compatible = "regulator-fixed";
>   		regulator-name = "dc_12v";

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
@ 2024-10-25 11:58   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:58 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The TS433 has 4 bays. The last two are accessed via a pci-connected
> sata controller, while the first two are accessed via the rk3568's
> sata controllers. Enable these two now.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-7-heiko@sntech.de
>
> [ upstream commit: 673c1353b3d476b9c5df6b84a777ed171e5594f5 ]
>
> (cherry picked from commit dfa45bbda057851d0c2167b4c311c0301637cc19)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts   | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index be1c2286c2d..40af4dd0e41 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -80,6 +80,16 @@
>   	status = "okay";
>   };
>   
> +/* connected to sata1 */
> +&combphy1 {
> +	status = "okay";
> +};
> +
> +/* connected to sata2 */
> +&combphy2 {
> +	status = "okay";
> +};
> +
>   &gmac0 {
>   	assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
>   	assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>;
> @@ -156,6 +166,14 @@
>   	};
>   };
>   
> +&sata1 {
> +	status = "okay";
> +};
> +
> +&sata2 {
> +	status = "okay";
> +};
> +
>   &sdhci {
>   	bus-width = <8>;
>   	max-frequency = <200000000>;

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:58   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:58 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Add the aliases for the internal network interface as well as the emmc
> on the board and make sure the dedicated RTC is always the first one.
>
> The TS433 actually has two rtc devices. One coming from the rk809 pmic
> without added functionality and also a dedicated RTC from Mycrocrystal
> that is battery backed to keep the time.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-8-heiko@sntech.de
>
> [ upstream commit: dadd4256e12360d3ff1f6481b2e4697f9d890caf ]
>
> (cherry picked from commit cb53815764403f7f17967a32eec2aeb6625b396f)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 40af4dd0e41..8be36250aa1 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -13,6 +13,12 @@
>   	model = "Qnap TS-433-4G NAS System 4-Bay";
>   	compatible = "qnap,ts433", "rockchip,rk3568";
>   
> +	aliases {
> +		ethernet0 = &gmac0;
> +		mmc0 = &sdhci;
> +		rtc0 = &rtc_rv8263;
> +	};
> +
>   	chosen {
>   		stdout-path = "serial2:115200n8";
>   	};
> @@ -120,7 +126,7 @@
>   &i2c1 {
>   	status = "okay";
>   
> -	rtc@51 {
> +	rtc_rv8263: rtc@51 {
>   		compatible = "microcrystal,rv8263";
>   		reg = <0x51>;
>   		wakeup-source;

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Add the 4 gpio-controlled LEDs to the Qnap-TS433.
>
> They are meant for individual disk activitivy, but I haven't found a
> way for how to connect them to their individual sata slot yet.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-9-heiko@sntech.de
>
> [ upstream commit: ea91aabf18bcad6f5eceae6848ea6570ea61f126 ]
>
> (cherry picked from commit 5a11b1bb40ac7b39e04077c045c3e3409fa352e2)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 59 +++++++++++++++++++
>   1 file changed, 59 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 8be36250aa1..abeb00add42 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -6,6 +6,7 @@
>   
>   /dts-v1/;
>   
> +#include <dt-bindings/leds/common.h>
>   #include <dt-bindings/gpio/gpio.h>
>   #include "rk3568.dtsi"
>   
> @@ -23,6 +24,46 @@
>   		stdout-path = "serial2:115200n8";
>   	};
>   
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-0 {
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_DISK;
> +			gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "disk-activity";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&hdd1_led_pin>;
> +		};
> +
> +		led-1 {
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_DISK;
> +			gpios = <&gpio1 RK_PD6 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "disk-activity";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&hdd2_led_pin>;
> +		};
> +
> +		led-2 {
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_DISK;
> +			gpios = <&gpio1 RK_PD7 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "disk-activity";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&hdd3_led_pin>;
> +		};
> +
> +		led-3 {
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_DISK;
> +			gpios = <&gpio2 RK_PA0 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "disk-activity";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&hdd4_led_pin>;
> +		};
> +	};
> +
>   	dc_12v: regulator-dc-12v {
>   		compatible = "regulator-fixed";
>   		regulator-name = "dc_12v";
> @@ -161,6 +202,24 @@
>   };
>   
>   &pinctrl {
> +	leds {
> +		hdd1_led_pin: hdd1-led-pin {
> +			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +
> +		hdd2_led_pin: hdd2-led-pin {
> +			rockchip,pins = <1 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +
> +		hdd3_led_pin: hdd3-led-pin {
> +			rockchip,pins = <1 RK_PD7 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +
> +		hdd4_led_pin: hdd4_led-pin {
> +			rockchip,pins = <2 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
>   	usb {
>   		vcc5v0_host_en: vcc5v0-host-en {
>   			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Enable the tsadc node to allow for temperature measurements of the soc.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-10-heiko@sntech.de
>
> [ upstream commit: 2dfdddd9d20306fd0d04b88fcbbf36d76fb67f11 ]
>
> (cherry picked from commit d33949501abd1145ea572b605844f0ef4247478d)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index abeb00add42..34fc31ea9a3 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -246,6 +246,12 @@
>   	status = "okay";
>   };
>   
> +&tsadc {
> +	rockchip,hw-tshut-mode = <1>;
> +	rockchip,hw-tshut-polarity = <0>;
> +	status = "okay";
> +};
> +
>   /*
>    * Connected to an MCU, that provides access to more LEDs,
>    * buzzer, fan control and more.

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The TS433 has 3 buttons, power and copy in the front as well as a reset
> pinhole button on the back. The power-button is connected to the embedded
> controller while the other two buttons are just gpio connected.
>
> Add the gpio-keys definition for the two buttons we can handle right now.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-11-heiko@sntech.de
>
> [ upstream commit: 9b682d31b24f1f70b5b4d0618095d46e0722b9d8 ]
>
> (cherry picked from commit f0b858c751382ee9faf18f9b19b0817c6b50ac1c)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 29 +++++++++++++++++++
>   1 file changed, 29 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 34fc31ea9a3..9f964b6f411 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -6,6 +6,7 @@
>   
>   /dts-v1/;
>   
> +#include <dt-bindings/input/input.h>
>   #include <dt-bindings/leds/common.h>
>   #include <dt-bindings/gpio/gpio.h>
>   #include "rk3568.dtsi"
> @@ -24,6 +25,24 @@
>   		stdout-path = "serial2:115200n8";
>   	};
>   
> +	keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&copy_button_pin>, <&reset_button_pin>;
> +		pinctrl-names = "default";
> +
> +		key-copy {
> +			label = "copy";
> +			gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_COPY>;
> +		};
> +
> +		key-reset {
> +			label = "reset";
> +			gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_RESTART>;
> +		};
> +	};
> +
>   	leds {
>   		compatible = "gpio-leds";
>   
> @@ -202,6 +221,16 @@
>   };
>   
>   &pinctrl {
> +	keys {
> +		copy_button_pin: copy-button-pin {
> +			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +
> +		reset_button_pin: reset-button-pin {
> +			rockchip,pins = <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
>   	leds {
>   		hdd1_led_pin: hdd1-led-pin {
>   			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The TS433 seems to use a silergy,syr827 regulator for the cpu supply.
> At least that is the compatible used in the vendor devicetree, though
> it could very well also be another fan53555 clone.
>
> Define the needed regulator node and hook up the cpu-supply to the
> cpu cores.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-12-heiko@sntech.de
>
> [ upstream commit: 99b36ba910d896bddbb9a190ca686c6d9cd0325f ]
>
> (cherry picked from commit 2f0afd1a3cbf6f3192dc7a5c496affab718671b3)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 41 +++++++++++++++++++
>   1 file changed, 41 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 9f964b6f411..4bccefc0537 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -130,6 +130,16 @@
>   		vin-supply = <&vcc5v0_usb>;
>   	};
>   
> +	vcc5v0_sys: regulator-vcc5v0-sys {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&dc_12v>;
> +	};
> +
>   	vcc5v0_usb: regulator-vcc5v0-usb {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc5v0_usb";
> @@ -156,6 +166,22 @@
>   	status = "okay";
>   };
>   
> +&cpu0 {
> +	cpu-supply = <&vdd_cpu>;
> +};
> +
> +&cpu1 {
> +	cpu-supply = <&vdd_cpu>;
> +};
> +
> +&cpu2 {
> +	cpu-supply = <&vdd_cpu>;
> +};
> +
> +&cpu3 {
> +	cpu-supply = <&vdd_cpu>;
> +};
> +
>   &gmac0 {
>   	assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
>   	assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>;
> @@ -175,12 +201,27 @@
>   };
>   
>   &i2c0 {
> +	status = "okay";
> +
>   	pmic@20 {
>   		compatible = "rockchip,rk809";
>   		reg = <0x20>;
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>   	};
> +
> +	vdd_cpu: regulator@40 {
> +		compatible = "silergy,syr827";
> +		reg = <0x40>;
> +		fcs,suspend-voltage-selector = <1>;
> +		regulator-name = "vdd_cpu";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <712500>;
> +		regulator-max-microvolt = <1390000>;
> +		regulator-ramp-delay = <2300>;
> +		vin-supply = <&vcc5v0_sys>;
> +	};
>   };
>   
>   &i2c1 {

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Fill in the missing pieces for RK809 pmic used on the TS433.
>
> The regulator setup comes from the vendor-devicetree, so without proper
> schematics its accuracy is somewhat unclear, but it looks really similar
> to all the other rk3568 boards, so follows the reference design it seems.
>
> The one caveat is related to vcc3v3_sd. This regulator needs to stay on.
> When turned off because of no users, access to both PCIe controllers
> will stall. Maybe this rail does supply the 100MHz refclk generation
> or so.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-13-heiko@sntech.de
>
> [ upstream commit: ee078c7daa98353496410b715a5acbb41d7d3a90 ]
>
> (cherry picked from commit 48951cb085998a5c8e3650351a794b136dac648f)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 227 +++++++++++++++++-
>   1 file changed, 226 insertions(+), 1 deletion(-)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 4bccefc0537..b807da6e850 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -102,6 +102,16 @@
>   		vin-supply = <&dc_12v>;
>   	};
>   
> +	vcc3v3_sys: regulator-vcc3v3-sys {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&dc_12v>;
> +	};
> +
>   	vcc5v0_host: regulator-vcc5v0-host {
>   		compatible = "regulator-fixed";
>   		enable-active-high;
> @@ -207,7 +217,216 @@
>   		compatible = "rockchip,rk809";
>   		reg = <0x20>;
>   		interrupt-parent = <&gpio0>;
> -		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
> +		#clock-cells = <1>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pmic_int_l>;
> +		system-power-controller;
> +		vcc1-supply = <&vcc3v3_sys>;
> +		vcc2-supply = <&vcc3v3_sys>;
> +		vcc3-supply = <&vcc3v3_sys>;
> +		vcc4-supply = <&vcc3v3_sys>;
> +		vcc5-supply = <&vcc3v3_sys>;
> +		vcc6-supply = <&vcc3v3_sys>;
> +		vcc7-supply = <&vcc3v3_sys>;
> +		vcc8-supply = <&vcc3v3_sys>;
> +		vcc9-supply = <&vcc3v3_sys>;
> +		wakeup-source;
> +
> +		regulators {
> +			vdd_logic: DCDC_REG1 {
> +				regulator-name = "vdd_logic";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-initial-mode = <0x2>;
> +				regulator-min-microvolt = <500000>;
> +				regulator-max-microvolt = <1350000>;
> +				regulator-ramp-delay = <6001>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdd_gpu: DCDC_REG2 {
> +				regulator-name = "vdd_gpu";
> +				regulator-always-on;
> +				regulator-initial-mode = <0x2>;
> +				regulator-min-microvolt = <500000>;
> +				regulator-max-microvolt = <1350000>;
> +				regulator-ramp-delay = <6001>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc_ddr: DCDC_REG3 {
> +				regulator-name = "vcc_ddr";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-initial-mode = <0x2>;
> +
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +				};
> +			};
> +
> +			vdd_npu: DCDC_REG4 {
> +				regulator-name = "vdd_npu";
> +				regulator-initial-mode = <0x2>;
> +				regulator-min-microvolt = <500000>;
> +				regulator-max-microvolt = <1350000>;
> +				regulator-ramp-delay = <6001>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc_1v8: DCDC_REG5 {
> +				regulator-name = "vcc_1v8";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdda0v9_image: LDO_REG1 {
> +				regulator-name = "vdda0v9_image";
> +				regulator-always-on;
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <900000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdda_0v9: LDO_REG2 {
> +				regulator-name = "vdda_0v9";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <900000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdda0v9_pmu: LDO_REG3 {
> +				regulator-name = "vdda0v9_pmu";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <900000>;
> +
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +					regulator-suspend-microvolt = <900000>;
> +				};
> +			};
> +
> +			vccio_acodec: LDO_REG4 {
> +				regulator-name = "vccio_acodec";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vccio_sd: LDO_REG5 {
> +				regulator-name = "vccio_sd";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc3v3_pmu: LDO_REG6 {
> +				regulator-name = "vcc3v3_pmu";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +					regulator-suspend-microvolt = <3300000>;
> +				};
> +			};
> +
> +			vcca_1v8: LDO_REG7 {
> +				regulator-name = "vcca_1v8";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcca1v8_pmu: LDO_REG8 {
> +				regulator-name = "vcca1v8_pmu";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +					regulator-suspend-microvolt = <1800000>;
> +				};
> +			};
> +
> +			vcca1v8_image: LDO_REG9 {
> +				regulator-name = "vcca1v8_image";
> +				regulator-always-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc_3v3: SWITCH_REG1 {
> +				regulator-name = "vcc_3v3";
> +				regulator-always-on;
> +				regulator-boot-on;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc3v3_sd: SWITCH_REG2 {
> +				regulator-name = "vcc3v3_sd";
> +				/*
> +				 * turning this off, breaks access to both
> +				 * PCIe controllers, refclk generator perhaps
> +				 */
> +				regulator-always-on;
> +				regulator-boot-on;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +		};
>   	};
>   
>   	vdd_cpu: regulator@40 {
> @@ -290,6 +509,12 @@
>   		};
>   	};
>   
> +	pmic {
> +		pmic_int_l: pmic-int-l {
> +			rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
>   	usb {
>   		vcc5v0_host_en: vcc5v0-host-en {
>   			rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>;

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 13/18] arm64: dts: rockchip: enable gpu on Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
@ 2024-10-25 11:59   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 11:59 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The TS433 doesn't provide display output, but the gpu nevertheless can be
> used for compute tasks for example.
>
> So there is no reason not to enable it.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-14-heiko@sntech.de
>
> [ upstream commit: 9130eb62586f4cef0557d0378fb7e78d7397ab2d ]
>
> (cherry picked from commit e324a9e8ea083ebdca207b5ca2ed86d2b5f862a0)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index b807da6e850..9a0cb69c3cf 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -210,6 +210,11 @@
>   	status = "okay";
>   };
>   
> +&gpu {
> +	mali-supply = <&vdd_gpu>;
> +	status = "okay";
> +};
> +
>   &i2c0 {
>   	status = "okay";
>   

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433
  2024-10-13 19:24 ` [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
@ 2024-10-25 12:00   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 12:00 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Add the two supplies for the pmu-io-domains that are defined in the
> vendor devicetree for the TS433.
>
> Tested-by: Uwe Kleine-König <ukleinek@debian.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240723195538.1133436-15-heiko@sntech.de
>
> [ upstream commit: 64b7f16fb3947e5d08d9e9b860ce966250e45d52 ]
>
> (cherry picked from commit 9b4d4c02b5762196063ab03c5439f96cbbaf2485)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 9a0cb69c3cf..6c4269b3d95 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -531,6 +531,11 @@
>   	};
>   };
>   
> +&pmu_io_domains {
> +	vccio4-supply = <&vcc_1v8>;
> +	vccio6-supply = <&vcc_1v8>;
> +};
> +
>   &sata1 {
>   	status = "okay";
>   };

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433
  2024-10-13 19:24 ` [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433 Heiko Stuebner
@ 2024-10-25 12:00   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 12:00 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek, Andrew Lunn


On 2024/10/14 03:24, Heiko Stuebner wrote:
> From: Uwe Kleine-König <ukleinek@debian.org>
>
> While it requires to have the right phy driver loaded (i.e. motorcomm)
> to make the phy asserting the right delays, this is generally the
> preferred way to define the MAC <-> PHY connection.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Link: https://lore.kernel.org/r/20240304084612.711678-2-ukleinek@debian.org
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> [ upstream commit: e8d45544f806f3b55c30345de84262cbb9504902 ]
>
> (cherry picked from commit e0bbe061fd537bd7b113c53eb046bbcbf0e6597d)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 6c4269b3d95..20e4fa6c185 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -198,15 +198,13 @@
>   	assigned-clock-rates = <0>, <125000000>;
>   	clock_in_out = "output";
>   	phy-handle = <&rgmii_phy0>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&gmac0_miim
>   		     &gmac0_tx_bus2
>   		     &gmac0_rx_bus2
>   		     &gmac0_rgmii_clk
>   		     &gmac0_rgmii_bus>;
> -	rx_delay = <0x2f>;
> -	tx_delay = <0x3c>;
>   	status = "okay";
>   };
>   

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433
  2024-10-13 19:24 ` [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains " Heiko Stuebner
@ 2024-10-25 12:00   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 12:00 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> Contrary to the vendor-kernel the pmu-io-domains are not enabled by
> default. This resulted in the value not being set according to the
> regulator, which in turn made the gmac0 interface that is connected
> to the vccio4 supply inoperable.
>
> Fixes: 64b7f16fb394 ("arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240805162052.3345768-1-heiko@sntech.de
>
> [ upstream commit: 40cc4257169712f0ae3835820a4c5afbdd1a16ff ]
>
> (cherry picked from commit f509fcb1fb82117e551b489592ac5714a6c5cd8d)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 20e4fa6c185..90d8d526629 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -532,6 +532,7 @@
>   &pmu_io_domains {
>   	vccio4-supply = <&vcc_1v8>;
>   	vccio6-supply = <&vcc_1v8>;
> +	status = "okay";
>   };
>   
>   &sata1 {

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433
  2024-10-13 19:24 ` [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
@ 2024-10-25 12:00   ` Kever Yang
  0 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 12:00 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The device contains two i2c-connected eeproms holding some product-
> specific values. One sitting on the mainboard and one on the statically
> connected backplane.
>
> While the eeprom chips themself have a size of 512 byte, the eeprom data
> only uses 256 byte each, probably to stay compatible with other models.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Link: https://lore.kernel.org/r/20240810211438.286441-3-heiko@sntech.de
>
> [ upstream commit: da6f4130234448122fe3e66c8116f7d9eea8a5c7 ]
>
> (cherry picked from commit 0b3109708caf5002ba188ae28eae9ce46b2c39b4)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 20 +++++++++++++++++++
>   1 file changed, 20 insertions(+)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 90d8d526629..e601d9271ba 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -454,6 +454,26 @@
>   		reg = <0x51>;
>   		wakeup-source;
>   	};
> +
> +	/* eeprom for vital-product-data on the mainboard */
> +	eeprom@54 {
> +		compatible = "giantec,gt24c04a", "atmel,24c04";
> +		reg = <0x54>;
> +		label = "VPD_MB";
> +		num-addresses = <2>;
> +		pagesize = <16>;
> +		read-only;
> +	};
> +
> +	/* eeprom for vital-product-data on the backplane */
> +	eeprom@56 {
> +		compatible = "giantec,gt24c04a", "atmel,24c04";
> +		reg = <0x56>;
> +		label = "VPD_BP";
> +		num-addresses = <2>;
> +		pagesize = <16>;
> +		read-only;
> +	};
>   };
>   
>   &mdio0 {

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
@ 2024-10-25 12:01   ` Kever Yang
  2024-10-26  2:39   ` Kever Yang
  2024-10-26  2:44   ` Kever Yang
  2 siblings, 0 replies; 41+ messages in thread
From: Kever Yang @ 2024-10-25 12:01 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek


On 2024/10/14 03:24, Heiko Stuebner wrote:
> The Qnap TS433 is a 4-bay NAS based around the RK3568.
>
> Two SATA bays are connected to the RK3568's own SATA controllers while
> the other two are connected to a JMicron SATA controller living on the
> PCIe bus.
>
> It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
>   arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
>   board/qnap/ts433/Kconfig                   | 12 +++
>   board/qnap/ts433/MAINTAINERS               |  8 ++
>   configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
>   doc/board/qnap/index.rst                   |  9 +++
>   doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++
>   doc/board/rockchip/rockchip.rst            |  1 +
>   include/configs/qnap_ts433.h               | 10 +++
>   9 files changed, 237 insertions(+)
>   create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>   create mode 100644 board/qnap/ts433/Kconfig
>   create mode 100644 board/qnap/ts433/MAINTAINERS
>   create mode 100644 configs/qnap-ts433-rk3568_defconfig
>   create mode 100644 doc/board/qnap/index.rst
>   create mode 100644 doc/board/qnap/ts433.rst
>   create mode 100644 include/configs/qnap_ts433.h
>
> diff --git a/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> new file mode 100644
> index 00000000000..19acbceb468
> --- /dev/null
> +++ b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2024 Heiko Stuebner <heiko@sntech.de>
> + */
> +
> +#include "rk356x-u-boot.dtsi"
> diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig b/arch/arm/mach-rockchip/rk3568/Kconfig
> index 899cf909fbb..2a0fd40874e 100644
> --- a/arch/arm/mach-rockchip/rk3568/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3568/Kconfig
> @@ -27,6 +27,19 @@ config TARGET_POWKIDDY_X55_RK3566
>   	help
>   	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
>   
> +config TARGET_QNAP_TS433_RK3568
> +	bool "QNAP-TS433"
> +	help
> +	  Qnap TS433 4-bay NAS with a RK3568 SoC.
> +
> +	  It provides the following featureset:
> +	   * 4GB LPDDR4
> +	   * 4GB eMMC
> +	   * 2 SATA ports connected to two RK3568's SATA controllers
> +	   * 2 SATA ports connected to a JMicron JMB58x AHCI SATA controller
> +	   * 1 1G network controller
> +	   * 1 2.5G Realtek RTL8125 network controller
> +
>   config TARGET_QUARTZ64_RK3566
>   	bool "Pine64 Quartz64"
>   	help
> @@ -64,6 +77,7 @@ source "board/anbernic/rgxx3_rk3566/Kconfig"
>   source "board/hardkernel/odroid_m1/Kconfig"
>   source "board/pine64/quartz64_rk3566/Kconfig"
>   source "board/powkiddy/x55/Kconfig"
> +source "board/qnap/ts433/Kconfig"
>   source "board/radxa/zero3-rk3566/Kconfig"
>   source "board/xunlong/orangepi-3b-rk3566/Kconfig"
>   
> diff --git a/board/qnap/ts433/Kconfig b/board/qnap/ts433/Kconfig
> new file mode 100644
> index 00000000000..b00e1f9f2ef
> --- /dev/null
> +++ b/board/qnap/ts433/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_QNAP_TS433_RK3568
> +
> +config SYS_BOARD
> +	default "qnap_ts433"
> +
> +config SYS_VENDOR
> +	default "qnap"
> +
> +config SYS_CONFIG_NAME
> +	default "qnap_ts433"
> +
> +endif
> diff --git a/board/qnap/ts433/MAINTAINERS b/board/qnap/ts433/MAINTAINERS
> new file mode 100644
> index 00000000000..c2b31ad9794
> --- /dev/null
> +++ b/board/qnap/ts433/MAINTAINERS
> @@ -0,0 +1,8 @@
> +QNAP-TS433
> +M:	Heiko Stuebner <heiko@sntech.de>
> +S:	Maintained
> +F:	board/qnap/ts433/
> +F:	doc/board/qnap/
> +F:	include/configs/qnap_ts433.h
> +F:	configs/qnap-ts433-rk3568_defconfig
> +F:	arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> diff --git a/configs/qnap-ts433-rk3568_defconfig b/configs/qnap-ts433-rk3568_defconfig
> new file mode 100644
> index 00000000000..cbe4622e468
> --- /dev/null
> +++ b/configs/qnap-ts433-rk3568_defconfig
> @@ -0,0 +1,86 @@
> +CONFIG_ARM=y
> +CONFIG_SKIP_LOWLEVEL_INIT=y
> +CONFIG_COUNTER_FREQUENCY=24000000
> +CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-qnap-ts433"
> +CONFIG_ROCKCHIP_RK3568=y
> +CONFIG_SPL_SERIAL=y
> +CONFIG_TARGET_QNAP_TS433_RK3568=y
> +CONFIG_DEBUG_UART_BASE=0xFE660000
> +CONFIG_DEBUG_UART_CLOCK=24000000
> +CONFIG_SYS_LOAD_ADDR=0xc00800
> +CONFIG_PCI=y
> +CONFIG_DEBUG_UART=y
> +CONFIG_AHCI=y
> +CONFIG_FIT=y
> +CONFIG_FIT_VERBOSE=y
> +CONFIG_SPL_FIT_SIGNATURE=y
> +CONFIG_SPL_LOAD_FIT=y
> +CONFIG_LEGACY_IMAGE_FORMAT=y
> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-qnap-ts433.dtb"
> +# CONFIG_DISPLAY_CPUINFO is not set
> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_SPL_MAX_SIZE=0x40000
> +CONFIG_SPL_PAD_TO=0x7f8000
> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
> +CONFIG_SPL_ATF=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_GPT=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_PCI=y
> +CONFIG_CMD_SATA=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_ROCKUSB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> +# CONFIG_SPL_DOS_PARTITION is not set
> +CONFIG_SPL_OF_CONTROL=y
> +CONFIG_OF_LIVE=y
> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_SPL_DM_SEQ_ALIAS=y
> +CONFIG_SPL_REGMAP=y
> +CONFIG_SPL_SYSCON=y
> +CONFIG_AHCI_PCI=y
> +CONFIG_DWC_AHCI=y
> +CONFIG_SPL_CLK=y
> +CONFIG_ROCKCHIP_GPIO=y
> +CONFIG_SYS_I2C_ROCKCHIP=y
> +CONFIG_LED=y
> +CONFIG_LED_GPIO=y
> +CONFIG_MISC=y
> +CONFIG_SUPPORT_EMMC_RPMB=y
> +CONFIG_MMC_DW=y
> +CONFIG_MMC_DW_ROCKCHIP=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_SDMA=y
> +CONFIG_MMC_SDHCI_ROCKCHIP=y
> +CONFIG_DWC_ETH_QOS=y
> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y
> +CONFIG_RTL8169=y
> +CONFIG_PCIE_DW_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> +CONFIG_SPL_PINCTRL=y
> +CONFIG_DM_PMIC=y
> +CONFIG_DM_PMIC_FAN53555=y
> +CONFIG_PMIC_RK8XX=y
> +CONFIG_REGULATOR_RK8XX=y
> +CONFIG_PWM_ROCKCHIP=y
> +CONFIG_SPL_RAM=y
> +CONFIG_SCSI=y
> +CONFIG_DEBUG_UART_SHIFT=2
> +CONFIG_SYS_NS16550_MEM32=y
> +CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC=y
> +CONFIG_ERRNO_STR=y
> diff --git a/doc/board/qnap/index.rst b/doc/board/qnap/index.rst
> new file mode 100644
> index 00000000000..652ea11a056
> --- /dev/null
> +++ b/doc/board/qnap/index.rst
> @@ -0,0 +1,9 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +Qnap
> +====
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   ts433.rst
> diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
> new file mode 100644
> index 00000000000..5c7fd314b7a
> --- /dev/null
> +++ b/doc/board/qnap/ts433.rst
> @@ -0,0 +1,91 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +U-Boot for Qnap TS433 Devices
> +=================================
> +
> +This allows U-Boot to boot the Qnap TS433 NAS
> +
> +Preparing the serial
> +--------------------
> +
> +Qnap devices run their serial console with a 115200 baudrate. As the
> +binary DDR-init and maskrom-downloader expect a 1500000 rate, it is
> +necessary to adapt the binaries if their output is needed.
> +
> +This can be done with a binary provided in the rkbin repository.
> +First the ddrbin_param.txt in the rkbin repo needs to be modified:
> +
> +.. code-block:: bash
> +
> +    diff --git a/tools/ddrbin_param.txt b/tools/ddrbin_param.txt
> +    index 0dfdd318..82ade7e7 100644
> +    --- a/tools/ddrbin_param.txt
> +    +++ b/tools/ddrbin_param.txt
> +    @@ -11,7 +11,7 @@ lp5_freq=
> +
> +     uart id=
> +     uart iomux=
> +    -uart baudrate=
> +    +uart baudrate=115200
> +
> +     sr_idle=
> +     pd_idle=
> +
> +And after that the ddrbin_tool binary can be used to modify apply this
> +modification and also a new maskrom downloader can be build:
> +
> +.. code-block:: bash
> +
> +    $ tools/ddrbin_tool rk3568 tools/ddrbin_param.txt bin/rk35/rk3568_ddr_1560MHz_v1.21.bin
> +    $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
> +
> +Building U-Boot
> +---------------
> +
> +.. code-block:: bash
> +
> +    $ export CROSS_COMPILE=aarch64-linux-gnu-
> +    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
> +    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin
> +    $ make qnap-ts433-rk3568_defconfig
> +    $ make
> +
> +This will build ``u-boot-rockchip.bin`` which can be written to the
> +on-board eMMC.
> +
> +Image installation
> +------------------
> +
> +The Qnap thankfully provides an easily accessible serial header as well as
> +a very user-friendly jumper-header to bring the device into maskrom mode.
> +
> +To access both, the drive trays need to be removed. Looking at the board,
> +through the upper cutout of the metal frame the white 4-port serial-header
> +can be seen next to a barcode sticker. It's pinout is as follows:
> +
> +.. code-block:: bash
> +
> +   ,_  _.
> +   |1234|  1=TX 2=VCC
> +   `----'  3=RX 4=GND
> +
> +
> +Directly below it, the mentioned 2-pin jumper header can be seen.
> +
> +To write your u-boot to the device, it needs to be powered off first. Then
> +a jumper or suitable cable needs to be used to connect the two pins of the
> +maskrom header. Turning on the device now will start it in maskrom mode.
> +
> +It is important that the jumper gets removed after that stop and before
> +actually trying to write to the emmc.
> +
> +The front usb-port needs to be connected to the host with an USB-A-to-A
> +cable to allow flashing.
> +
> +The flashing itself is done via rkdeveloptool, which can be found for
> +example as package of that name in Debian-based distributions:
> +
> +.. code-block:: bash
> +
> +    $ rkdeveloptool db rk356x_spl_loader_v1.21.113.bin
> +    $ rkdeveloptool wl 64 u-boot-rockchip.bin
> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> index 86d83befb5b..a0349d3ad56 100644
> --- a/doc/board/rockchip/rockchip.rst
> +++ b/doc/board/rockchip/rockchip.rst
> @@ -118,6 +118,7 @@ List of mainline supported Rockchip boards:
>        - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
>        - Generic RK3566/RK3568 (generic-rk3568)
>        - Hardkernel ODROID-M1 (odroid-m1-rk3568)
> +     - QNAP TS-433 (qnap-ts433-rk3568)
>        - Radxa E25 Carrier Board (radxa-e25-rk3568)
>        - Radxa ROCK 3A (rock-3a-rk3568)
>        - Radxa ROCK 3B (rock-3b-rk3568)
> diff --git a/include/configs/qnap_ts433.h b/include/configs/qnap_ts433.h
> new file mode 100644
> index 00000000000..aee4546bf07
> --- /dev/null
> +++ b/include/configs/qnap_ts433.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +
> +#ifndef __QNAP_TS433_H
> +#define __QNAP_TS433_H
> +
> +#define ROCKCHIP_DEVICE_SETTINGS
> +
> +#include <configs/rk3568_common.h>
> +
> +#endif

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
  2024-10-25 12:01   ` Kever Yang
@ 2024-10-26  2:39   ` Kever Yang
  2024-10-28  8:39     ` Kever Yang
  2024-10-26  2:44   ` Kever Yang
  2 siblings, 1 reply; 41+ messages in thread
From: Kever Yang @ 2024-10-26  2:39 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek

Hi Heiko,

     I got a ci error for this patch:

https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929839

+Image 'simple-bin-spi' is missing external blobs and is non-functional: 
rockchip-tpl
+/binman/simple-bin-spi/mkimage/rockchip-tpl (rockchip-tpl):
+drivers/net/rtl8169.c:320:2: error: #warning cache-line size is larger 
than descriptor size [-Werror=cpp]
+  320 | #warning cache-line size is larger than descriptor size
+      |  ^~~~~~~
+cc1: all warnings being treated as errors
+make[3]: *** [scripts/Makefile.build:257: drivers/net/rtl8169.o] Error 1
+make[2]: *** [scripts/Makefile.build:398: drivers/net] Error 2
+make[1]: *** [Makefile:1914: drivers] Error 2
+make: *** [Makefile:177: sub-make] Error 2


Seems for some reason the CI is building the TPL and rtl8169.c is build 
inside TPL?


Thanks,
- Kever
On 2024/10/14 03:24, Heiko Stuebner wrote:
> The Qnap TS433 is a 4-bay NAS based around the RK3568.
>
> Two SATA bays are connected to the RK3568's own SATA controllers while
> the other two are connected to a JMicron SATA controller living on the
> PCIe bus.
>
> It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>   arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
>   arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
>   board/qnap/ts433/Kconfig                   | 12 +++
>   board/qnap/ts433/MAINTAINERS               |  8 ++
>   configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
>   doc/board/qnap/index.rst                   |  9 +++
>   doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++
>   doc/board/rockchip/rockchip.rst            |  1 +
>   include/configs/qnap_ts433.h               | 10 +++
>   9 files changed, 237 insertions(+)
>   create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>   create mode 100644 board/qnap/ts433/Kconfig
>   create mode 100644 board/qnap/ts433/MAINTAINERS
>   create mode 100644 configs/qnap-ts433-rk3568_defconfig
>   create mode 100644 doc/board/qnap/index.rst
>   create mode 100644 doc/board/qnap/ts433.rst
>   create mode 100644 include/configs/qnap_ts433.h
>
> diff --git a/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> new file mode 100644
> index 00000000000..19acbceb468
> --- /dev/null
> +++ b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2024 Heiko Stuebner <heiko@sntech.de>
> + */
> +
> +#include "rk356x-u-boot.dtsi"
> diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig b/arch/arm/mach-rockchip/rk3568/Kconfig
> index 899cf909fbb..2a0fd40874e 100644
> --- a/arch/arm/mach-rockchip/rk3568/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3568/Kconfig
> @@ -27,6 +27,19 @@ config TARGET_POWKIDDY_X55_RK3566
>   	help
>   	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
>   
> +config TARGET_QNAP_TS433_RK3568
> +	bool "QNAP-TS433"
> +	help
> +	  Qnap TS433 4-bay NAS with a RK3568 SoC.
> +
> +	  It provides the following featureset:
> +	   * 4GB LPDDR4
> +	   * 4GB eMMC
> +	   * 2 SATA ports connected to two RK3568's SATA controllers
> +	   * 2 SATA ports connected to a JMicron JMB58x AHCI SATA controller
> +	   * 1 1G network controller
> +	   * 1 2.5G Realtek RTL8125 network controller
> +
>   config TARGET_QUARTZ64_RK3566
>   	bool "Pine64 Quartz64"
>   	help
> @@ -64,6 +77,7 @@ source "board/anbernic/rgxx3_rk3566/Kconfig"
>   source "board/hardkernel/odroid_m1/Kconfig"
>   source "board/pine64/quartz64_rk3566/Kconfig"
>   source "board/powkiddy/x55/Kconfig"
> +source "board/qnap/ts433/Kconfig"
>   source "board/radxa/zero3-rk3566/Kconfig"
>   source "board/xunlong/orangepi-3b-rk3566/Kconfig"
>   
> diff --git a/board/qnap/ts433/Kconfig b/board/qnap/ts433/Kconfig
> new file mode 100644
> index 00000000000..b00e1f9f2ef
> --- /dev/null
> +++ b/board/qnap/ts433/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_QNAP_TS433_RK3568
> +
> +config SYS_BOARD
> +	default "qnap_ts433"
> +
> +config SYS_VENDOR
> +	default "qnap"
> +
> +config SYS_CONFIG_NAME
> +	default "qnap_ts433"
> +
> +endif
> diff --git a/board/qnap/ts433/MAINTAINERS b/board/qnap/ts433/MAINTAINERS
> new file mode 100644
> index 00000000000..c2b31ad9794
> --- /dev/null
> +++ b/board/qnap/ts433/MAINTAINERS
> @@ -0,0 +1,8 @@
> +QNAP-TS433
> +M:	Heiko Stuebner <heiko@sntech.de>
> +S:	Maintained
> +F:	board/qnap/ts433/
> +F:	doc/board/qnap/
> +F:	include/configs/qnap_ts433.h
> +F:	configs/qnap-ts433-rk3568_defconfig
> +F:	arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> diff --git a/configs/qnap-ts433-rk3568_defconfig b/configs/qnap-ts433-rk3568_defconfig
> new file mode 100644
> index 00000000000..cbe4622e468
> --- /dev/null
> +++ b/configs/qnap-ts433-rk3568_defconfig
> @@ -0,0 +1,86 @@
> +CONFIG_ARM=y
> +CONFIG_SKIP_LOWLEVEL_INIT=y
> +CONFIG_COUNTER_FREQUENCY=24000000
> +CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-qnap-ts433"
> +CONFIG_ROCKCHIP_RK3568=y
> +CONFIG_SPL_SERIAL=y
> +CONFIG_TARGET_QNAP_TS433_RK3568=y
> +CONFIG_DEBUG_UART_BASE=0xFE660000
> +CONFIG_DEBUG_UART_CLOCK=24000000
> +CONFIG_SYS_LOAD_ADDR=0xc00800
> +CONFIG_PCI=y
> +CONFIG_DEBUG_UART=y
> +CONFIG_AHCI=y
> +CONFIG_FIT=y
> +CONFIG_FIT_VERBOSE=y
> +CONFIG_SPL_FIT_SIGNATURE=y
> +CONFIG_SPL_LOAD_FIT=y
> +CONFIG_LEGACY_IMAGE_FORMAT=y
> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-qnap-ts433.dtb"
> +# CONFIG_DISPLAY_CPUINFO is not set
> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_SPL_MAX_SIZE=0x40000
> +CONFIG_SPL_PAD_TO=0x7f8000
> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
> +CONFIG_SPL_ATF=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_GPT=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_PCI=y
> +CONFIG_CMD_SATA=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_ROCKUSB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> +# CONFIG_SPL_DOS_PARTITION is not set
> +CONFIG_SPL_OF_CONTROL=y
> +CONFIG_OF_LIVE=y
> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_SPL_DM_SEQ_ALIAS=y
> +CONFIG_SPL_REGMAP=y
> +CONFIG_SPL_SYSCON=y
> +CONFIG_AHCI_PCI=y
> +CONFIG_DWC_AHCI=y
> +CONFIG_SPL_CLK=y
> +CONFIG_ROCKCHIP_GPIO=y
> +CONFIG_SYS_I2C_ROCKCHIP=y
> +CONFIG_LED=y
> +CONFIG_LED_GPIO=y
> +CONFIG_MISC=y
> +CONFIG_SUPPORT_EMMC_RPMB=y
> +CONFIG_MMC_DW=y
> +CONFIG_MMC_DW_ROCKCHIP=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_SDMA=y
> +CONFIG_MMC_SDHCI_ROCKCHIP=y
> +CONFIG_DWC_ETH_QOS=y
> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y
> +CONFIG_RTL8169=y
> +CONFIG_PCIE_DW_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> +CONFIG_SPL_PINCTRL=y
> +CONFIG_DM_PMIC=y
> +CONFIG_DM_PMIC_FAN53555=y
> +CONFIG_PMIC_RK8XX=y
> +CONFIG_REGULATOR_RK8XX=y
> +CONFIG_PWM_ROCKCHIP=y
> +CONFIG_SPL_RAM=y
> +CONFIG_SCSI=y
> +CONFIG_DEBUG_UART_SHIFT=2
> +CONFIG_SYS_NS16550_MEM32=y
> +CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC=y
> +CONFIG_ERRNO_STR=y
> diff --git a/doc/board/qnap/index.rst b/doc/board/qnap/index.rst
> new file mode 100644
> index 00000000000..652ea11a056
> --- /dev/null
> +++ b/doc/board/qnap/index.rst
> @@ -0,0 +1,9 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +Qnap
> +====
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   ts433.rst
> diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
> new file mode 100644
> index 00000000000..5c7fd314b7a
> --- /dev/null
> +++ b/doc/board/qnap/ts433.rst
> @@ -0,0 +1,91 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +U-Boot for Qnap TS433 Devices
> +=================================
> +
> +This allows U-Boot to boot the Qnap TS433 NAS
> +
> +Preparing the serial
> +--------------------
> +
> +Qnap devices run their serial console with a 115200 baudrate. As the
> +binary DDR-init and maskrom-downloader expect a 1500000 rate, it is
> +necessary to adapt the binaries if their output is needed.
> +
> +This can be done with a binary provided in the rkbin repository.
> +First the ddrbin_param.txt in the rkbin repo needs to be modified:
> +
> +.. code-block:: bash
> +
> +    diff --git a/tools/ddrbin_param.txt b/tools/ddrbin_param.txt
> +    index 0dfdd318..82ade7e7 100644
> +    --- a/tools/ddrbin_param.txt
> +    +++ b/tools/ddrbin_param.txt
> +    @@ -11,7 +11,7 @@ lp5_freq=
> +
> +     uart id=
> +     uart iomux=
> +    -uart baudrate=
> +    +uart baudrate=115200
> +
> +     sr_idle=
> +     pd_idle=
> +
> +And after that the ddrbin_tool binary can be used to modify apply this
> +modification and also a new maskrom downloader can be build:
> +
> +.. code-block:: bash
> +
> +    $ tools/ddrbin_tool rk3568 tools/ddrbin_param.txt bin/rk35/rk3568_ddr_1560MHz_v1.21.bin
> +    $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
> +
> +Building U-Boot
> +---------------
> +
> +.. code-block:: bash
> +
> +    $ export CROSS_COMPILE=aarch64-linux-gnu-
> +    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
> +    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin
> +    $ make qnap-ts433-rk3568_defconfig
> +    $ make
> +
> +This will build ``u-boot-rockchip.bin`` which can be written to the
> +on-board eMMC.
> +
> +Image installation
> +------------------
> +
> +The Qnap thankfully provides an easily accessible serial header as well as
> +a very user-friendly jumper-header to bring the device into maskrom mode.
> +
> +To access both, the drive trays need to be removed. Looking at the board,
> +through the upper cutout of the metal frame the white 4-port serial-header
> +can be seen next to a barcode sticker. It's pinout is as follows:
> +
> +.. code-block:: bash
> +
> +   ,_  _.
> +   |1234|  1=TX 2=VCC
> +   `----'  3=RX 4=GND
> +
> +
> +Directly below it, the mentioned 2-pin jumper header can be seen.
> +
> +To write your u-boot to the device, it needs to be powered off first. Then
> +a jumper or suitable cable needs to be used to connect the two pins of the
> +maskrom header. Turning on the device now will start it in maskrom mode.
> +
> +It is important that the jumper gets removed after that stop and before
> +actually trying to write to the emmc.
> +
> +The front usb-port needs to be connected to the host with an USB-A-to-A
> +cable to allow flashing.
> +
> +The flashing itself is done via rkdeveloptool, which can be found for
> +example as package of that name in Debian-based distributions:
> +
> +.. code-block:: bash
> +
> +    $ rkdeveloptool db rk356x_spl_loader_v1.21.113.bin
> +    $ rkdeveloptool wl 64 u-boot-rockchip.bin
> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> index 86d83befb5b..a0349d3ad56 100644
> --- a/doc/board/rockchip/rockchip.rst
> +++ b/doc/board/rockchip/rockchip.rst
> @@ -118,6 +118,7 @@ List of mainline supported Rockchip boards:
>        - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
>        - Generic RK3566/RK3568 (generic-rk3568)
>        - Hardkernel ODROID-M1 (odroid-m1-rk3568)
> +     - QNAP TS-433 (qnap-ts433-rk3568)
>        - Radxa E25 Carrier Board (radxa-e25-rk3568)
>        - Radxa ROCK 3A (rock-3a-rk3568)
>        - Radxa ROCK 3B (rock-3b-rk3568)
> diff --git a/include/configs/qnap_ts433.h b/include/configs/qnap_ts433.h
> new file mode 100644
> index 00000000000..aee4546bf07
> --- /dev/null
> +++ b/include/configs/qnap_ts433.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +
> +#ifndef __QNAP_TS433_H
> +#define __QNAP_TS433_H
> +
> +#define ROCKCHIP_DEVICE_SETTINGS
> +
> +#include <configs/rk3568_common.h>
> +
> +#endif

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
  2024-10-25 12:01   ` Kever Yang
  2024-10-26  2:39   ` Kever Yang
@ 2024-10-26  2:44   ` Kever Yang
  2024-10-26  3:36     ` Tom Rini
  2 siblings, 1 reply; 41+ messages in thread
From: Kever Yang @ 2024-10-26  2:44 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek, Tom Rini

Hi Heiko,

On 2024/10/14 03:24, Heiko Stuebner wrote:
> The Qnap TS433 is a 4-bay NAS based around the RK3568.
>
> Two SATA bays are connected to the RK3568's own SATA controllers while
> the other two are connected to a JMicron SATA controller living on the
> PCIe bus.
>
> It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>   arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
>   arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
>   board/qnap/ts433/Kconfig                   | 12 +++
>   board/qnap/ts433/MAINTAINERS               |  8 ++
>   configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
>   doc/board/qnap/index.rst                   |  9 +++
>   doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++

I got a CI build fail for the doc check:

https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929791

checking consistency... failed
Warning, treated as error:
/builds/u-boot/custodians/u-boot-rockchip/doc/board/qnap/index.rst:document 
isn't included in any toctree
make[1]: *** [doc/Makefile:70: htmldocs] Error 2
make: *** [Makefile:2445: htmldocs] Error 2


Hi Tom,

     Do you have any suggestion for this kind of error?


Thanks,

- Kever

>   doc/board/rockchip/rockchip.rst            |  1 +
>   include/configs/qnap_ts433.h               | 10 +++
>   9 files changed, 237 insertions(+)
>   create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>   create mode 100644 board/qnap/ts433/Kconfig
>   create mode 100644 board/qnap/ts433/MAINTAINERS
>   create mode 100644 configs/qnap-ts433-rk3568_defconfig
>   create mode 100644 doc/board/qnap/index.rst
>   create mode 100644 doc/board/qnap/ts433.rst
>   create mode 100644 include/configs/qnap_ts433.h
>
> diff --git a/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> new file mode 100644
> index 00000000000..19acbceb468
> --- /dev/null
> +++ b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2024 Heiko Stuebner <heiko@sntech.de>
> + */
> +
> +#include "rk356x-u-boot.dtsi"
> diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig b/arch/arm/mach-rockchip/rk3568/Kconfig
> index 899cf909fbb..2a0fd40874e 100644
> --- a/arch/arm/mach-rockchip/rk3568/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3568/Kconfig
> @@ -27,6 +27,19 @@ config TARGET_POWKIDDY_X55_RK3566
>   	help
>   	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
>   
> +config TARGET_QNAP_TS433_RK3568
> +	bool "QNAP-TS433"
> +	help
> +	  Qnap TS433 4-bay NAS with a RK3568 SoC.
> +
> +	  It provides the following featureset:
> +	   * 4GB LPDDR4
> +	   * 4GB eMMC
> +	   * 2 SATA ports connected to two RK3568's SATA controllers
> +	   * 2 SATA ports connected to a JMicron JMB58x AHCI SATA controller
> +	   * 1 1G network controller
> +	   * 1 2.5G Realtek RTL8125 network controller
> +
>   config TARGET_QUARTZ64_RK3566
>   	bool "Pine64 Quartz64"
>   	help
> @@ -64,6 +77,7 @@ source "board/anbernic/rgxx3_rk3566/Kconfig"
>   source "board/hardkernel/odroid_m1/Kconfig"
>   source "board/pine64/quartz64_rk3566/Kconfig"
>   source "board/powkiddy/x55/Kconfig"
> +source "board/qnap/ts433/Kconfig"
>   source "board/radxa/zero3-rk3566/Kconfig"
>   source "board/xunlong/orangepi-3b-rk3566/Kconfig"
>   
> diff --git a/board/qnap/ts433/Kconfig b/board/qnap/ts433/Kconfig
> new file mode 100644
> index 00000000000..b00e1f9f2ef
> --- /dev/null
> +++ b/board/qnap/ts433/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_QNAP_TS433_RK3568
> +
> +config SYS_BOARD
> +	default "qnap_ts433"
> +
> +config SYS_VENDOR
> +	default "qnap"
> +
> +config SYS_CONFIG_NAME
> +	default "qnap_ts433"
> +
> +endif
> diff --git a/board/qnap/ts433/MAINTAINERS b/board/qnap/ts433/MAINTAINERS
> new file mode 100644
> index 00000000000..c2b31ad9794
> --- /dev/null
> +++ b/board/qnap/ts433/MAINTAINERS
> @@ -0,0 +1,8 @@
> +QNAP-TS433
> +M:	Heiko Stuebner <heiko@sntech.de>
> +S:	Maintained
> +F:	board/qnap/ts433/
> +F:	doc/board/qnap/
> +F:	include/configs/qnap_ts433.h
> +F:	configs/qnap-ts433-rk3568_defconfig
> +F:	arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
> diff --git a/configs/qnap-ts433-rk3568_defconfig b/configs/qnap-ts433-rk3568_defconfig
> new file mode 100644
> index 00000000000..cbe4622e468
> --- /dev/null
> +++ b/configs/qnap-ts433-rk3568_defconfig
> @@ -0,0 +1,86 @@
> +CONFIG_ARM=y
> +CONFIG_SKIP_LOWLEVEL_INIT=y
> +CONFIG_COUNTER_FREQUENCY=24000000
> +CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-qnap-ts433"
> +CONFIG_ROCKCHIP_RK3568=y
> +CONFIG_SPL_SERIAL=y
> +CONFIG_TARGET_QNAP_TS433_RK3568=y
> +CONFIG_DEBUG_UART_BASE=0xFE660000
> +CONFIG_DEBUG_UART_CLOCK=24000000
> +CONFIG_SYS_LOAD_ADDR=0xc00800
> +CONFIG_PCI=y
> +CONFIG_DEBUG_UART=y
> +CONFIG_AHCI=y
> +CONFIG_FIT=y
> +CONFIG_FIT_VERBOSE=y
> +CONFIG_SPL_FIT_SIGNATURE=y
> +CONFIG_SPL_LOAD_FIT=y
> +CONFIG_LEGACY_IMAGE_FORMAT=y
> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-qnap-ts433.dtb"
> +# CONFIG_DISPLAY_CPUINFO is not set
> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_SPL_MAX_SIZE=0x40000
> +CONFIG_SPL_PAD_TO=0x7f8000
> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
> +CONFIG_SPL_ATF=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_GPT=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_PCI=y
> +CONFIG_CMD_SATA=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_ROCKUSB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> +# CONFIG_SPL_DOS_PARTITION is not set
> +CONFIG_SPL_OF_CONTROL=y
> +CONFIG_OF_LIVE=y
> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_SPL_DM_SEQ_ALIAS=y
> +CONFIG_SPL_REGMAP=y
> +CONFIG_SPL_SYSCON=y
> +CONFIG_AHCI_PCI=y
> +CONFIG_DWC_AHCI=y
> +CONFIG_SPL_CLK=y
> +CONFIG_ROCKCHIP_GPIO=y
> +CONFIG_SYS_I2C_ROCKCHIP=y
> +CONFIG_LED=y
> +CONFIG_LED_GPIO=y
> +CONFIG_MISC=y
> +CONFIG_SUPPORT_EMMC_RPMB=y
> +CONFIG_MMC_DW=y
> +CONFIG_MMC_DW_ROCKCHIP=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_SDMA=y
> +CONFIG_MMC_SDHCI_ROCKCHIP=y
> +CONFIG_DWC_ETH_QOS=y
> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y
> +CONFIG_RTL8169=y
> +CONFIG_PCIE_DW_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> +CONFIG_SPL_PINCTRL=y
> +CONFIG_DM_PMIC=y
> +CONFIG_DM_PMIC_FAN53555=y
> +CONFIG_PMIC_RK8XX=y
> +CONFIG_REGULATOR_RK8XX=y
> +CONFIG_PWM_ROCKCHIP=y
> +CONFIG_SPL_RAM=y
> +CONFIG_SCSI=y
> +CONFIG_DEBUG_UART_SHIFT=2
> +CONFIG_SYS_NS16550_MEM32=y
> +CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC=y
> +CONFIG_ERRNO_STR=y
> diff --git a/doc/board/qnap/index.rst b/doc/board/qnap/index.rst
> new file mode 100644
> index 00000000000..652ea11a056
> --- /dev/null
> +++ b/doc/board/qnap/index.rst
> @@ -0,0 +1,9 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +Qnap
> +====
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   ts433.rst
> diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
> new file mode 100644
> index 00000000000..5c7fd314b7a
> --- /dev/null
> +++ b/doc/board/qnap/ts433.rst
> @@ -0,0 +1,91 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +U-Boot for Qnap TS433 Devices
> +=================================
> +
> +This allows U-Boot to boot the Qnap TS433 NAS
> +
> +Preparing the serial
> +--------------------
> +
> +Qnap devices run their serial console with a 115200 baudrate. As the
> +binary DDR-init and maskrom-downloader expect a 1500000 rate, it is
> +necessary to adapt the binaries if their output is needed.
> +
> +This can be done with a binary provided in the rkbin repository.
> +First the ddrbin_param.txt in the rkbin repo needs to be modified:
> +
> +.. code-block:: bash
> +
> +    diff --git a/tools/ddrbin_param.txt b/tools/ddrbin_param.txt
> +    index 0dfdd318..82ade7e7 100644
> +    --- a/tools/ddrbin_param.txt
> +    +++ b/tools/ddrbin_param.txt
> +    @@ -11,7 +11,7 @@ lp5_freq=
> +
> +     uart id=
> +     uart iomux=
> +    -uart baudrate=
> +    +uart baudrate=115200
> +
> +     sr_idle=
> +     pd_idle=
> +
> +And after that the ddrbin_tool binary can be used to modify apply this
> +modification and also a new maskrom downloader can be build:
> +
> +.. code-block:: bash
> +
> +    $ tools/ddrbin_tool rk3568 tools/ddrbin_param.txt bin/rk35/rk3568_ddr_1560MHz_v1.21.bin
> +    $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
> +
> +Building U-Boot
> +---------------
> +
> +.. code-block:: bash
> +
> +    $ export CROSS_COMPILE=aarch64-linux-gnu-
> +    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
> +    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin
> +    $ make qnap-ts433-rk3568_defconfig
> +    $ make
> +
> +This will build ``u-boot-rockchip.bin`` which can be written to the
> +on-board eMMC.
> +
> +Image installation
> +------------------
> +
> +The Qnap thankfully provides an easily accessible serial header as well as
> +a very user-friendly jumper-header to bring the device into maskrom mode.
> +
> +To access both, the drive trays need to be removed. Looking at the board,
> +through the upper cutout of the metal frame the white 4-port serial-header
> +can be seen next to a barcode sticker. It's pinout is as follows:
> +
> +.. code-block:: bash
> +
> +   ,_  _.
> +   |1234|  1=TX 2=VCC
> +   `----'  3=RX 4=GND
> +
> +
> +Directly below it, the mentioned 2-pin jumper header can be seen.
> +
> +To write your u-boot to the device, it needs to be powered off first. Then
> +a jumper or suitable cable needs to be used to connect the two pins of the
> +maskrom header. Turning on the device now will start it in maskrom mode.
> +
> +It is important that the jumper gets removed after that stop and before
> +actually trying to write to the emmc.
> +
> +The front usb-port needs to be connected to the host with an USB-A-to-A
> +cable to allow flashing.
> +
> +The flashing itself is done via rkdeveloptool, which can be found for
> +example as package of that name in Debian-based distributions:
> +
> +.. code-block:: bash
> +
> +    $ rkdeveloptool db rk356x_spl_loader_v1.21.113.bin
> +    $ rkdeveloptool wl 64 u-boot-rockchip.bin
> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> index 86d83befb5b..a0349d3ad56 100644
> --- a/doc/board/rockchip/rockchip.rst
> +++ b/doc/board/rockchip/rockchip.rst
> @@ -118,6 +118,7 @@ List of mainline supported Rockchip boards:
>        - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
>        - Generic RK3566/RK3568 (generic-rk3568)
>        - Hardkernel ODROID-M1 (odroid-m1-rk3568)
> +     - QNAP TS-433 (qnap-ts433-rk3568)
>        - Radxa E25 Carrier Board (radxa-e25-rk3568)
>        - Radxa ROCK 3A (rock-3a-rk3568)
>        - Radxa ROCK 3B (rock-3b-rk3568)
> diff --git a/include/configs/qnap_ts433.h b/include/configs/qnap_ts433.h
> new file mode 100644
> index 00000000000..aee4546bf07
> --- /dev/null
> +++ b/include/configs/qnap_ts433.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +
> +#ifndef __QNAP_TS433_H
> +#define __QNAP_TS433_H
> +
> +#define ROCKCHIP_DEVICE_SETTINGS
> +
> +#include <configs/rk3568_common.h>
> +
> +#endif

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-26  2:44   ` Kever Yang
@ 2024-10-26  3:36     ` Tom Rini
  0 siblings, 0 replies; 41+ messages in thread
From: Tom Rini @ 2024-10-26  3:36 UTC (permalink / raw)
  To: Kever Yang; +Cc: Heiko Stuebner, u-boot, philipp.tomsich, sjg, ukleinek

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

On Sat, Oct 26, 2024 at 10:44:59AM +0800, Kever Yang wrote:
> Hi Heiko,
> 
> On 2024/10/14 03:24, Heiko Stuebner wrote:
> > The Qnap TS433 is a 4-bay NAS based around the RK3568.
> > 
> > Two SATA bays are connected to the RK3568's own SATA controllers while
> > the other two are connected to a JMicron SATA controller living on the
> > PCIe bus.
> > 
> > It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >   arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
> >   arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
> >   board/qnap/ts433/Kconfig                   | 12 +++
> >   board/qnap/ts433/MAINTAINERS               |  8 ++
> >   configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
> >   doc/board/qnap/index.rst                   |  9 +++
> >   doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++
> 
> I got a CI build fail for the doc check:
> 
> https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929791
> 
> checking consistency... failed
> Warning, treated as error:
> /builds/u-boot/custodians/u-boot-rockchip/doc/board/qnap/index.rst:document
> isn't included in any toctree
> make[1]: *** [doc/Makefile:70: htmldocs] Error 2
> make: *** [Makefile:2445: htmldocs] Error 2
> 
> 
> Hi Tom,
> 
>     Do you have any suggestion for this kind of error?

Hey, yes, "qnap/index" needs to be listed in doc/board/index.rst

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-26  2:39   ` Kever Yang
@ 2024-10-28  8:39     ` Kever Yang
  2024-10-28 18:49       ` Heiko Stuebner
  0 siblings, 1 reply; 41+ messages in thread
From: Kever Yang @ 2024-10-28  8:39 UTC (permalink / raw)
  To: Heiko Stuebner, u-boot, philipp.tomsich, sjg; +Cc: ukleinek

Hi Heiko,


On 2024/10/26 10:39, Kever Yang wrote:
> Hi Heiko,
>
>     I got a ci error for this patch:
>
> https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929839
>
> +Image 'simple-bin-spi' is missing external blobs and is 
> non-functional: rockchip-tpl
> +/binman/simple-bin-spi/mkimage/rockchip-tpl (rockchip-tpl):
> +drivers/net/rtl8169.c:320:2: error: #warning cache-line size is 
> larger than descriptor size [-Werror=cpp]
> +  320 | #warning cache-line size is larger than descriptor size
> +      |  ^~~~~~~
> +cc1: all warnings being treated as errors

The other boards are using below Kconfig to fix this warning, which is 
suggest by the driver:

CONFIG_SYS_HAS_NONCACHED_MEMORY=y

  307  * Warn if the cache-line size is larger than the descriptor size. 
In such
  308  * cases the driver will likely fail because the CPU needs to 
flush the cache
  309  * when requeuing RX buffers, therefore descriptors written by the 
hardware
  310  * may be discarded.
  311 *
  312  * This can be fixed by defining CONFIG_SYS_NONCACHED_MEMORY which 
will cause
  313  * the driver to allocate descriptors from a pool of non-cached 
memory.
  314 *
  315  * Hardware maintain D-cache coherency in RISC-V architecture.


Thanks,

- Kever

> +make[3]: *** [scripts/Makefile.build:257: drivers/net/rtl8169.o] Error 1
> +make[2]: *** [scripts/Makefile.build:398: drivers/net] Error 2
> +make[1]: *** [Makefile:1914: drivers] Error 2
> +make: *** [Makefile:177: sub-make] Error 2
>
>
> Seems for some reason the CI is building the TPL and rtl8169.c is 
> build inside TPL?
>
>
> Thanks,
> - Kever
> On 2024/10/14 03:24, Heiko Stuebner wrote:
>> The Qnap TS433 is a 4-bay NAS based around the RK3568.
>>
>> Two SATA bays are connected to the RK3568's own SATA controllers while
>> the other two are connected to a JMicron SATA controller living on the
>> PCIe bus.
>>
>> It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
>>
>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>   arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi |  6 ++
>>   arch/arm/mach-rockchip/rk3568/Kconfig      | 14 ++++
>>   board/qnap/ts433/Kconfig                   | 12 +++
>>   board/qnap/ts433/MAINTAINERS               |  8 ++
>>   configs/qnap-ts433-rk3568_defconfig        | 86 ++++++++++++++++++++
>>   doc/board/qnap/index.rst                   |  9 +++
>>   doc/board/qnap/ts433.rst                   | 91 ++++++++++++++++++++++
>>   doc/board/rockchip/rockchip.rst            |  1 +
>>   include/configs/qnap_ts433.h               | 10 +++
>>   9 files changed, 237 insertions(+)
>>   create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>>   create mode 100644 board/qnap/ts433/Kconfig
>>   create mode 100644 board/qnap/ts433/MAINTAINERS
>>   create mode 100644 configs/qnap-ts433-rk3568_defconfig
>>   create mode 100644 doc/board/qnap/index.rst
>>   create mode 100644 doc/board/qnap/ts433.rst
>>   create mode 100644 include/configs/qnap_ts433.h
>>
>> diff --git a/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi 
>> b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>> new file mode 100644
>> index 00000000000..19acbceb468
>> --- /dev/null
>> +++ b/arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>> @@ -0,0 +1,6 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * (C) Copyright 2024 Heiko Stuebner <heiko@sntech.de>
>> + */
>> +
>> +#include "rk356x-u-boot.dtsi"
>> diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig 
>> b/arch/arm/mach-rockchip/rk3568/Kconfig
>> index 899cf909fbb..2a0fd40874e 100644
>> --- a/arch/arm/mach-rockchip/rk3568/Kconfig
>> +++ b/arch/arm/mach-rockchip/rk3568/Kconfig
>> @@ -27,6 +27,19 @@ config TARGET_POWKIDDY_X55_RK3566
>>       help
>>         Powkiddy X55 handheld gaming console with an RK3566 SoC.
>>   +config TARGET_QNAP_TS433_RK3568
>> +    bool "QNAP-TS433"
>> +    help
>> +      Qnap TS433 4-bay NAS with a RK3568 SoC.
>> +
>> +      It provides the following featureset:
>> +       * 4GB LPDDR4
>> +       * 4GB eMMC
>> +       * 2 SATA ports connected to two RK3568's SATA controllers
>> +       * 2 SATA ports connected to a JMicron JMB58x AHCI SATA 
>> controller
>> +       * 1 1G network controller
>> +       * 1 2.5G Realtek RTL8125 network controller
>> +
>>   config TARGET_QUARTZ64_RK3566
>>       bool "Pine64 Quartz64"
>>       help
>> @@ -64,6 +77,7 @@ source "board/anbernic/rgxx3_rk3566/Kconfig"
>>   source "board/hardkernel/odroid_m1/Kconfig"
>>   source "board/pine64/quartz64_rk3566/Kconfig"
>>   source "board/powkiddy/x55/Kconfig"
>> +source "board/qnap/ts433/Kconfig"
>>   source "board/radxa/zero3-rk3566/Kconfig"
>>   source "board/xunlong/orangepi-3b-rk3566/Kconfig"
>>   diff --git a/board/qnap/ts433/Kconfig b/board/qnap/ts433/Kconfig
>> new file mode 100644
>> index 00000000000..b00e1f9f2ef
>> --- /dev/null
>> +++ b/board/qnap/ts433/Kconfig
>> @@ -0,0 +1,12 @@
>> +if TARGET_QNAP_TS433_RK3568
>> +
>> +config SYS_BOARD
>> +    default "qnap_ts433"
>> +
>> +config SYS_VENDOR
>> +    default "qnap"
>> +
>> +config SYS_CONFIG_NAME
>> +    default "qnap_ts433"
>> +
>> +endif
>> diff --git a/board/qnap/ts433/MAINTAINERS b/board/qnap/ts433/MAINTAINERS
>> new file mode 100644
>> index 00000000000..c2b31ad9794
>> --- /dev/null
>> +++ b/board/qnap/ts433/MAINTAINERS
>> @@ -0,0 +1,8 @@
>> +QNAP-TS433
>> +M:    Heiko Stuebner <heiko@sntech.de>
>> +S:    Maintained
>> +F:    board/qnap/ts433/
>> +F:    doc/board/qnap/
>> +F:    include/configs/qnap_ts433.h
>> +F:    configs/qnap-ts433-rk3568_defconfig
>> +F:    arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
>> diff --git a/configs/qnap-ts433-rk3568_defconfig 
>> b/configs/qnap-ts433-rk3568_defconfig
>> new file mode 100644
>> index 00000000000..cbe4622e468
>> --- /dev/null
>> +++ b/configs/qnap-ts433-rk3568_defconfig
>> @@ -0,0 +1,86 @@
>> +CONFIG_ARM=y
>> +CONFIG_SKIP_LOWLEVEL_INIT=y
>> +CONFIG_COUNTER_FREQUENCY=24000000
>> +CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3568-qnap-ts433"
>> +CONFIG_ROCKCHIP_RK3568=y
>> +CONFIG_SPL_SERIAL=y
>> +CONFIG_TARGET_QNAP_TS433_RK3568=y
>> +CONFIG_DEBUG_UART_BASE=0xFE660000
>> +CONFIG_DEBUG_UART_CLOCK=24000000
>> +CONFIG_SYS_LOAD_ADDR=0xc00800
>> +CONFIG_PCI=y
>> +CONFIG_DEBUG_UART=y
>> +CONFIG_AHCI=y
>> +CONFIG_FIT=y
>> +CONFIG_FIT_VERBOSE=y
>> +CONFIG_SPL_FIT_SIGNATURE=y
>> +CONFIG_SPL_LOAD_FIT=y
>> +CONFIG_LEGACY_IMAGE_FORMAT=y
>> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3568-qnap-ts433.dtb"
>> +# CONFIG_DISPLAY_CPUINFO is not set
>> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>> +CONFIG_SPL_MAX_SIZE=0x40000
>> +CONFIG_SPL_PAD_TO=0x7f8000
>> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
>> +CONFIG_SPL_ATF=y
>> +CONFIG_CMD_GPIO=y
>> +CONFIG_CMD_GPT=y
>> +CONFIG_CMD_I2C=y
>> +CONFIG_CMD_MMC=y
>> +CONFIG_CMD_PCI=y
>> +CONFIG_CMD_SATA=y
>> +CONFIG_CMD_USB=y
>> +CONFIG_CMD_ROCKUSB=y
>> +CONFIG_CMD_USB_MASS_STORAGE=y
>> +# CONFIG_CMD_SETEXPR is not set
>> +CONFIG_CMD_PMIC=y
>> +CONFIG_CMD_REGULATOR=y
>> +# CONFIG_SPL_DOS_PARTITION is not set
>> +CONFIG_SPL_OF_CONTROL=y
>> +CONFIG_OF_LIVE=y
>> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent 
>> assigned-clocks assigned-clock-rates assigned-clock-parents"
>> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>> +CONFIG_SPL_DM_SEQ_ALIAS=y
>> +CONFIG_SPL_REGMAP=y
>> +CONFIG_SPL_SYSCON=y
>> +CONFIG_AHCI_PCI=y
>> +CONFIG_DWC_AHCI=y
>> +CONFIG_SPL_CLK=y
>> +CONFIG_ROCKCHIP_GPIO=y
>> +CONFIG_SYS_I2C_ROCKCHIP=y
>> +CONFIG_LED=y
>> +CONFIG_LED_GPIO=y
>> +CONFIG_MISC=y
>> +CONFIG_SUPPORT_EMMC_RPMB=y
>> +CONFIG_MMC_DW=y
>> +CONFIG_MMC_DW_ROCKCHIP=y
>> +CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_SDMA=y
>> +CONFIG_MMC_SDHCI_ROCKCHIP=y
>> +CONFIG_DWC_ETH_QOS=y
>> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>> +CONFIG_RTL8169=y
>> +CONFIG_PCIE_DW_ROCKCHIP=y
>> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
>> +CONFIG_SPL_PINCTRL=y
>> +CONFIG_DM_PMIC=y
>> +CONFIG_DM_PMIC_FAN53555=y
>> +CONFIG_PMIC_RK8XX=y
>> +CONFIG_REGULATOR_RK8XX=y
>> +CONFIG_PWM_ROCKCHIP=y
>> +CONFIG_SPL_RAM=y
>> +CONFIG_SCSI=y
>> +CONFIG_DEBUG_UART_SHIFT=2
>> +CONFIG_SYS_NS16550_MEM32=y
>> +CONFIG_SYSRESET=y
>> +CONFIG_USB=y
>> +CONFIG_USB_XHCI_HCD=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_EHCI_GENERIC=y
>> +CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_OHCI_GENERIC=y
>> +CONFIG_USB_DWC3=y
>> +CONFIG_USB_DWC3_GENERIC=y
>> +CONFIG_ERRNO_STR=y
>> diff --git a/doc/board/qnap/index.rst b/doc/board/qnap/index.rst
>> new file mode 100644
>> index 00000000000..652ea11a056
>> --- /dev/null
>> +++ b/doc/board/qnap/index.rst
>> @@ -0,0 +1,9 @@
>> +.. SPDX-License-Identifier: GPL-2.0+
>> +
>> +Qnap
>> +====
>> +
>> +.. toctree::
>> +   :maxdepth: 2
>> +
>> +   ts433.rst
>> diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
>> new file mode 100644
>> index 00000000000..5c7fd314b7a
>> --- /dev/null
>> +++ b/doc/board/qnap/ts433.rst
>> @@ -0,0 +1,91 @@
>> +.. SPDX-License-Identifier: GPL-2.0+
>> +
>> +U-Boot for Qnap TS433 Devices
>> +=================================
>> +
>> +This allows U-Boot to boot the Qnap TS433 NAS
>> +
>> +Preparing the serial
>> +--------------------
>> +
>> +Qnap devices run their serial console with a 115200 baudrate. As the
>> +binary DDR-init and maskrom-downloader expect a 1500000 rate, it is
>> +necessary to adapt the binaries if their output is needed.
>> +
>> +This can be done with a binary provided in the rkbin repository.
>> +First the ddrbin_param.txt in the rkbin repo needs to be modified:
>> +
>> +.. code-block:: bash
>> +
>> +    diff --git a/tools/ddrbin_param.txt b/tools/ddrbin_param.txt
>> +    index 0dfdd318..82ade7e7 100644
>> +    --- a/tools/ddrbin_param.txt
>> +    +++ b/tools/ddrbin_param.txt
>> +    @@ -11,7 +11,7 @@ lp5_freq=
>> +
>> +     uart id=
>> +     uart iomux=
>> +    -uart baudrate=
>> +    +uart baudrate=115200
>> +
>> +     sr_idle=
>> +     pd_idle=
>> +
>> +And after that the ddrbin_tool binary can be used to modify apply this
>> +modification and also a new maskrom downloader can be build:
>> +
>> +.. code-block:: bash
>> +
>> +    $ tools/ddrbin_tool rk3568 tools/ddrbin_param.txt 
>> bin/rk35/rk3568_ddr_1560MHz_v1.21.bin
>> +    $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
>> +
>> +Building U-Boot
>> +---------------
>> +
>> +.. code-block:: bash
>> +
>> +    $ export CROSS_COMPILE=aarch64-linux-gnu-
>> +    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
>> +    $ export 
>> ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin
>> +    $ make qnap-ts433-rk3568_defconfig
>> +    $ make
>> +
>> +This will build ``u-boot-rockchip.bin`` which can be written to the
>> +on-board eMMC.
>> +
>> +Image installation
>> +------------------
>> +
>> +The Qnap thankfully provides an easily accessible serial header as 
>> well as
>> +a very user-friendly jumper-header to bring the device into maskrom 
>> mode.
>> +
>> +To access both, the drive trays need to be removed. Looking at the 
>> board,
>> +through the upper cutout of the metal frame the white 4-port 
>> serial-header
>> +can be seen next to a barcode sticker. It's pinout is as follows:
>> +
>> +.. code-block:: bash
>> +
>> +   ,_  _.
>> +   |1234|  1=TX 2=VCC
>> +   `----'  3=RX 4=GND
>> +
>> +
>> +Directly below it, the mentioned 2-pin jumper header can be seen.
>> +
>> +To write your u-boot to the device, it needs to be powered off 
>> first. Then
>> +a jumper or suitable cable needs to be used to connect the two pins 
>> of the
>> +maskrom header. Turning on the device now will start it in maskrom 
>> mode.
>> +
>> +It is important that the jumper gets removed after that stop and before
>> +actually trying to write to the emmc.
>> +
>> +The front usb-port needs to be connected to the host with an USB-A-to-A
>> +cable to allow flashing.
>> +
>> +The flashing itself is done via rkdeveloptool, which can be found for
>> +example as package of that name in Debian-based distributions:
>> +
>> +.. code-block:: bash
>> +
>> +    $ rkdeveloptool db rk356x_spl_loader_v1.21.113.bin
>> +    $ rkdeveloptool wl 64 u-boot-rockchip.bin
>> diff --git a/doc/board/rockchip/rockchip.rst 
>> b/doc/board/rockchip/rockchip.rst
>> index 86d83befb5b..a0349d3ad56 100644
>> --- a/doc/board/rockchip/rockchip.rst
>> +++ b/doc/board/rockchip/rockchip.rst
>> @@ -118,6 +118,7 @@ List of mainline supported Rockchip boards:
>>        - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
>>        - Generic RK3566/RK3568 (generic-rk3568)
>>        - Hardkernel ODROID-M1 (odroid-m1-rk3568)
>> +     - QNAP TS-433 (qnap-ts433-rk3568)
>>        - Radxa E25 Carrier Board (radxa-e25-rk3568)
>>        - Radxa ROCK 3A (rock-3a-rk3568)
>>        - Radxa ROCK 3B (rock-3b-rk3568)
>> diff --git a/include/configs/qnap_ts433.h b/include/configs/qnap_ts433.h
>> new file mode 100644
>> index 00000000000..aee4546bf07
>> --- /dev/null
>> +++ b/include/configs/qnap_ts433.h
>> @@ -0,0 +1,10 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +
>> +#ifndef __QNAP_TS433_H
>> +#define __QNAP_TS433_H
>> +
>> +#define ROCKCHIP_DEVICE_SETTINGS
>> +
>> +#include <configs/rk3568_common.h>
>> +
>> +#endif
>

^ permalink raw reply	[flat|nested] 41+ messages in thread

* Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
  2024-10-28  8:39     ` Kever Yang
@ 2024-10-28 18:49       ` Heiko Stuebner
  0 siblings, 0 replies; 41+ messages in thread
From: Heiko Stuebner @ 2024-10-28 18:49 UTC (permalink / raw)
  To: u-boot, philipp.tomsich, sjg, Kever Yang; +Cc: ukleinek

Hi Kever,

Am Montag, 28. Oktober 2024, 09:39:27 CET schrieb Kever Yang:
> On 2024/10/26 10:39, Kever Yang wrote:
> > Hi Heiko,
> >
> >     I got a ci error for this patch:
> >
> > https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929839
> >
> > +Image 'simple-bin-spi' is missing external blobs and is 
> > non-functional: rockchip-tpl
> > +/binman/simple-bin-spi/mkimage/rockchip-tpl (rockchip-tpl):
> > +drivers/net/rtl8169.c:320:2: error: #warning cache-line size is 
> > larger than descriptor size [-Werror=cpp]
> > +  320 | #warning cache-line size is larger than descriptor size
> > +      |  ^~~~~~~
> > +cc1: all warnings being treated as errors
> 
> The other boards are using below Kconfig to fix this warning, which is 
> suggest by the driver:
> 
> CONFIG_SYS_HAS_NONCACHED_MEMORY=y
> 
>   307  * Warn if the cache-line size is larger than the descriptor size. 
> In such
>   308  * cases the driver will likely fail because the CPU needs to 
> flush the cache
>   309  * when requeuing RX buffers, therefore descriptors written by the 
> hardware
>   310  * may be discarded.
>   311 *
>   312  * This can be fixed by defining CONFIG_SYS_NONCACHED_MEMORY which 
> will cause
>   313  * the driver to allocate descriptors from a pool of non-cached 
> memory.
>   314 *
>   315  * Hardware maintain D-cache coherency in RISC-V architecture.

thanks so much for this pointer, I started looking into the issue
today, but your pointer made everything so much easier.

Thanks a lot
Heiko



^ permalink raw reply	[flat|nested] 41+ messages in thread

end of thread, other threads:[~2024-10-28 18:49 UTC | newest]

Thread overview: 41+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
2024-10-21  1:32   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433 Heiko Stuebner
2024-10-13 19:24 ` [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
2024-10-25 11:58   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
2024-10-25 11:58   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
2024-10-25 11:58   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
2024-10-25 11:58   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
2024-10-25 11:58   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
2024-10-25 11:59   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
2024-10-25 12:00   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433 Heiko Stuebner
2024-10-25 12:00   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains " Heiko Stuebner
2024-10-25 12:00   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
2024-10-25 12:00   ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
2024-10-25 12:01   ` Kever Yang
2024-10-26  2:39   ` Kever Yang
2024-10-28  8:39     ` Kever Yang
2024-10-28 18:49       ` Heiko Stuebner
2024-10-26  2:44   ` Kever Yang
2024-10-26  3:36     ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox