[PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

Changes since v2:

Add a second patch to deal with CI failures due to the new options.

Changes since v1:

Updated Kconfig depends

Angus Ainslie (2):
  usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver
  configs: get rid of build warnings due to SPL_USB_DWC3_GENERIC

 configs/am43xx_evm_defconfig              | 2 ++
 configs/am43xx_evm_usbhost_boot_defconfig | 2 ++
 configs/am43xx_hs_evm_defconfig           | 2 ++
 configs/am57xx_hs_evm_usb_defconfig       | 2 ++
 configs/am65x_evm_a53_defconfig           | 2 ++
 configs/am65x_evm_r5_usbdfu_defconfig     | 2 ++
 configs/dra7xx_evm_defconfig              | 2 ++
 configs/dra7xx_hs_evm_defconfig           | 2 ++
 configs/dra7xx_hs_evm_usb_defconfig       | 2 ++
 drivers/usb/dwc3/Kconfig                  | 7 +++++++
 drivers/usb/dwc3/Makefile                 | 2 +-
 11 files changed, 26 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH v3 1/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

Suppress warnings when building the SPL without USB_DWC3_GENERIC

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 drivers/usb/dwc3/Kconfig  | 7 +++++++
 drivers/usb/dwc3/Makefile | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 62aa65bf0c..f010291d02 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -30,6 +30,13 @@ config USB_DWC3_GENERIC
 	  Select this for Xilinx ZynqMP and similar Platforms.
 	  This wrapper supports Host and Peripheral operation modes.
 
+config SPL_USB_DWC3_GENERIC
+	bool "Generic implementation of a DWC3 wrapper (aka dwc3 glue) for the SPL"
+	depends on SPL_DM_USB && USB_DWC3 && SPL_MISC
+	help
+	  Select this for Xilinx ZynqMP and similar Platforms.
+	  This wrapper supports Host and Peripheral operation modes.
+
 config USB_DWC3_MESON_G12A
 	bool "Amlogic Meson G12A USB wrapper"
 	depends on DM_USB && USB_DWC3 && ARCH_MESON
diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
index 0dd1ba87cd..97b4f7191c 100644
--- a/drivers/usb/dwc3/Makefile
+++ b/drivers/usb/dwc3/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_USB_DWC3_GADGET)		+= gadget.o ep0.o
 obj-$(CONFIG_USB_DWC3_OMAP)		+= dwc3-omap.o
 obj-$(CONFIG_USB_DWC3_MESON_G12A)	+= dwc3-meson-g12a.o
 obj-$(CONFIG_USB_DWC3_MESON_GXL)	+= dwc3-meson-gxl.o
-obj-$(CONFIG_USB_DWC3_GENERIC)		+= dwc3-generic.o
+obj-$(CONFIG_$(SPL_)USB_DWC3_GENERIC)		+= dwc3-generic.o
 obj-$(CONFIG_USB_DWC3_UNIPHIER)		+= dwc3-uniphier.o
 obj-$(CONFIG_USB_DWC3_LAYERSCAPE)	+= dwc3-layerscape.o
 obj-$(CONFIG_USB_DWC3_PHY_OMAP)		+= ti_usb_phy.o
-- 
2.34.1

[PATCH v3 2/2] configs: get rid of build warnings due to SPL_USB_DWC3_GENERIC

[Angus Ainslie]

Adding the SPL_USB_DWC3_GENERIC symbol broke some ti builds. This
should fix the builds but untested on HW.

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 configs/am43xx_evm_defconfig              | 2 ++
 configs/am43xx_evm_usbhost_boot_defconfig | 2 ++
 configs/am43xx_hs_evm_defconfig           | 2 ++
 configs/am57xx_hs_evm_usb_defconfig       | 2 ++
 configs/am65x_evm_a53_defconfig           | 2 ++
 configs/am65x_evm_r5_usbdfu_defconfig     | 2 ++
 configs/dra7xx_evm_defconfig              | 2 ++
 configs/dra7xx_hs_evm_defconfig           | 2 ++
 configs/dra7xx_hs_evm_usb_defconfig       | 2 ++
 9 files changed, 18 insertions(+)

diff --git a/configs/am43xx_evm_defconfig b/configs/am43xx_evm_defconfig
index 7a736b6fe1..13a305a53c 100644
--- a/configs/am43xx_evm_defconfig
+++ b/configs/am43xx_evm_defconfig
@@ -59,6 +59,7 @@ CONFIG_DFU_MMC=y
 CONFIG_DFU_RAM=y
 CONFIG_DFU_SF=y
 CONFIG_MISC=y
+CONFIG_SPL_MISC=y
 CONFIG_SYS_I2C_EEPROM_ADDR=0x50
 CONFIG_MMC_OMAP_HS=y
 CONFIG_MTD=y
@@ -93,6 +94,7 @@ CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_OMAP=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/am43xx_evm_usbhost_boot_defconfig b/configs/am43xx_evm_usbhost_boot_defconfig
index e844106243..b1f17c6a9e 100644
--- a/configs/am43xx_evm_usbhost_boot_defconfig
+++ b/configs/am43xx_evm_usbhost_boot_defconfig
@@ -8,6 +8,7 @@ CONFIG_DM_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm"
 CONFIG_AM43XX=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_SPL_LOAD_FIT=y
 # CONFIG_USE_SPL_FIT_GENERATOR is not set
@@ -94,6 +95,7 @@ CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_OMAP=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/am43xx_hs_evm_defconfig b/configs/am43xx_hs_evm_defconfig
index d436b41a0c..206e5cf7bc 100644
--- a/configs/am43xx_hs_evm_defconfig
+++ b/configs/am43xx_hs_evm_defconfig
@@ -15,6 +15,7 @@ CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
 CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
 CONFIG_SPL_DRIVERS_MISC=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT_IMAGE_POST_PROCESS=y
 CONFIG_SPL_LOAD_FIT=y
@@ -97,6 +98,7 @@ CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_OMAP=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/am57xx_hs_evm_usb_defconfig b/configs/am57xx_hs_evm_usb_defconfig
index 194103a7e6..9cfc31cb9f 100644
--- a/configs/am57xx_hs_evm_usb_defconfig
+++ b/configs/am57xx_hs_evm_usb_defconfig
@@ -14,6 +14,7 @@ CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
 CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
 CONFIG_TARGET_AM57XX_EVM=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
@@ -114,6 +115,7 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
index 9f41b397c3..8cf24dd25f 100644
--- a/configs/am65x_evm_a53_defconfig
+++ b/configs/am65x_evm_a53_defconfig
@@ -12,6 +12,7 @@ CONFIG_ENV_SIZE=0x20000
 CONFIG_ENV_OFFSET=0x680000
 CONFIG_DM_GPIO=y
 CONFIG_SPL_DM_SPI=y
+CONFIG_SPL_MISC=y
 CONFIG_DEFAULT_DEVICE_TREE="k3-am654-base-board"
 CONFIG_SPL_TEXT_BASE=0x80080000
 CONFIG_SPL_MMC=y
@@ -163,6 +164,7 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/am65x_evm_r5_usbdfu_defconfig b/configs/am65x_evm_r5_usbdfu_defconfig
index 57cd0f35a5..0430a94a7c 100644
--- a/configs/am65x_evm_r5_usbdfu_defconfig
+++ b/configs/am65x_evm_r5_usbdfu_defconfig
@@ -3,6 +3,7 @@ CONFIG_ARCH_K3=y
 CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SYS_MALLOC_F_LEN=0x55000
 CONFIG_SPL_GPIO=y
+CONFIG_SPL_MISC=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
 CONFIG_NR_DRAM_BANKS=2
@@ -111,6 +112,7 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
index e972d3b117..f118c172fe 100644
--- a/configs/dra7xx_evm_defconfig
+++ b/configs/dra7xx_evm_defconfig
@@ -10,6 +10,7 @@ CONFIG_SPL_TEXT_BASE=0x40300000
 CONFIG_OMAP54XX=y
 CONFIG_TARGET_DRA7XX_EVM=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
@@ -136,6 +137,7 @@ CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_OMAP=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig
index 1e872b5cb6..225942e397 100644
--- a/configs/dra7xx_hs_evm_defconfig
+++ b/configs/dra7xx_hs_evm_defconfig
@@ -13,6 +13,7 @@ CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
 CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
 CONFIG_TARGET_DRA7XX_EVM=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
@@ -135,6 +136,7 @@ CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_OMAP=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
diff --git a/configs/dra7xx_hs_evm_usb_defconfig b/configs/dra7xx_hs_evm_usb_defconfig
index 8c07da9872..d171b18d6d 100644
--- a/configs/dra7xx_hs_evm_usb_defconfig
+++ b/configs/dra7xx_hs_evm_usb_defconfig
@@ -15,6 +15,7 @@ CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
 CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
 CONFIG_TARGET_DRA7XX_EVM=y
 CONFIG_SPL=y
+CONFIG_SPL_MISC=y
 CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
@@ -123,6 +124,7 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_XHCI_OMAP=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
-- 
2.34.1

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

Did this fix the CI issues now ?

On 2022-05-30 10:15, Angus Ainslie wrote:
> Changes since v2:
> 
> Add a second patch to deal with CI failures due to the new options.
> 
> Changes since v1:
> 
> Updated Kconfig depends
> 
> Angus Ainslie (2):
>   usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver
>   configs: get rid of build warnings due to SPL_USB_DWC3_GENERIC
> 
>  configs/am43xx_evm_defconfig              | 2 ++
>  configs/am43xx_evm_usbhost_boot_defconfig | 2 ++
>  configs/am43xx_hs_evm_defconfig           | 2 ++
>  configs/am57xx_hs_evm_usb_defconfig       | 2 ++
>  configs/am65x_evm_a53_defconfig           | 2 ++
>  configs/am65x_evm_r5_usbdfu_defconfig     | 2 ++
>  configs/dra7xx_evm_defconfig              | 2 ++
>  configs/dra7xx_hs_evm_defconfig           | 2 ++
>  configs/dra7xx_hs_evm_usb_defconfig       | 2 ++
>  drivers/usb/dwc3/Kconfig                  | 7 +++++++
>  drivers/usb/dwc3/Makefile                 | 2 +-
>  11 files changed, 26 insertions(+), 1 deletion(-)

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

Hi,

Are there any problems with these patches ?

Thanks
Angus

On 2022-05-30 10:15, Angus Ainslie wrote:
> Changes since v2:
> 
> Add a second patch to deal with CI failures due to the new options.
> 
> Changes since v1:
> 
> Updated Kconfig depends
> 
> Angus Ainslie (2):
>   usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver
>   configs: get rid of build warnings due to SPL_USB_DWC3_GENERIC
> 
>  configs/am43xx_evm_defconfig              | 2 ++
>  configs/am43xx_evm_usbhost_boot_defconfig | 2 ++
>  configs/am43xx_hs_evm_defconfig           | 2 ++
>  configs/am57xx_hs_evm_usb_defconfig       | 2 ++
>  configs/am65x_evm_a53_defconfig           | 2 ++
>  configs/am65x_evm_r5_usbdfu_defconfig     | 2 ++
>  configs/dra7xx_evm_defconfig              | 2 ++
>  configs/dra7xx_hs_evm_defconfig           | 2 ++
>  configs/dra7xx_hs_evm_usb_defconfig       | 2 ++
>  drivers/usb/dwc3/Kconfig                  | 7 +++++++
>  drivers/usb/dwc3/Makefile                 | 2 +-
>  11 files changed, 26 insertions(+), 1 deletion(-)

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Marek Vasut]

On 7/14/22 16:21, Angus Ainslie wrote:
> Hi,

Hi,

> Are there any problems with these patches ?

I missed them, sigh ... sorry.

Can you rebase them on usb/master and resend, so I can pick them up?

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

On 2022-07-14 07:31, Marek Vasut wrote:
> On 7/14/22 16:21, Angus Ainslie wrote:
>> Hi,
> 
> Hi,
> 
>> Are there any problems with these patches ?
> 
> I missed them, sigh ... sorry.
> 
> Can you rebase them on usb/master and resend, so I can pick them up?

Sure, could you remind me how to run the CI tests again.

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Marek Vasut]

On 7/14/22 16:52, Angus Ainslie wrote:
> On 2022-07-14 07:31, Marek Vasut wrote:
>> On 7/14/22 16:21, Angus Ainslie wrote:
>>> Hi,
>>
>> Hi,
>>
>>> Are there any problems with these patches ?
>>
>> I missed them, sigh ... sorry.
>>
>> Can you rebase them on usb/master and resend, so I can pick them up?
> 
> Sure, could you remind me how to run the CI tests again.

I don't think you can do that yourself unless you have a repo at 
source.denx.de/u-boot , but I might be wrong.

Really just run git rebase -i on git://source.denx.de/u-boot-usb.git / 
master and then git send-email --annontate , that's all.

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Angus Ainslie]

On 2022-07-14 07:54, Marek Vasut wrote:
> On 7/14/22 16:52, Angus Ainslie wrote:
>> On 2022-07-14 07:31, Marek Vasut wrote:
>>> On 7/14/22 16:21, Angus Ainslie wrote:
>>>> Hi,
>>> 
>>> Hi,
>>> 
>>>> Are there any problems with these patches ?
>>> 
>>> I missed them, sigh ... sorry.
>>> 
>>> Can you rebase them on usb/master and resend, so I can pick them up?
>> 
>> Sure, could you remind me how to run the CI tests again.
> 
> I don't think you can do that yourself unless you have a repo at
> source.denx.de/u-boot , but I might be wrong.
> 

Ah I found it in the gitlab ci script

./tools/buildman/buildman -o /tmp -P -E -W arm


> Really just run git rebase -i on git://source.denx.de/u-boot-usb.git /
> master and then git send-email --annontate , that's all.

Ok I'll send ASAP

Re: [PATCH v3 0/2] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

[Marek Vasut]

On 7/14/22 16:59, Angus Ainslie wrote:
> On 2022-07-14 07:54, Marek Vasut wrote:
>> On 7/14/22 16:52, Angus Ainslie wrote:
>>> On 2022-07-14 07:31, Marek Vasut wrote:
>>>> On 7/14/22 16:21, Angus Ainslie wrote:
>>>>> Hi,
>>>>
>>>> Hi,
>>>>
>>>>> Are there any problems with these patches ?
>>>>
>>>> I missed them, sigh ... sorry.
>>>>
>>>> Can you rebase them on usb/master and resend, so I can pick them up?
>>>
>>> Sure, could you remind me how to run the CI tests again.
>>
>> I don't think you can do that yourself unless you have a repo at
>> source.denx.de/u-boot , but I might be wrong.
>>
> 
> Ah I found it in the gitlab ci script
> 
> ./tools/buildman/buildman -o /tmp -P -E -W arm
> 
> 
>> Really just run git rebase -i on git://source.denx.de/u-boot-usb.git /
>> master and then git send-email --annontate , that's all.
> 
> Ok I'll send ASAP

Thanks !